diff mbox

ASoC: audio-graph-scu-card: add missing MIX binding example

Message ID 87h8zvdq17.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kuninori Morimoto June 5, 2017, 4:25 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../bindings/sound/audio-graph-scu-card.txt        | 47 +++++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)

Comments

James Cameron June 5, 2017, 5:15 a.m. UTC | #1 
On Mon, Jun 05, 2017 at 04:25:15AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  .../bindings/sound/audio-graph-scu-card.txt        | 47 +++++++++++++++++++++-
>  1 file changed, 46 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt b/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt
> index b2dd23f..ca494cf 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt
> @@ -35,7 +35,7 @@ Required properties:
>  - compatible				: "audio-graph-scu-card";
>  - dais					: list of CPU DAI port{s}
>  
> -Example
> +Example 1. Sampling Rate Covert

Other documentation refers to sampling rate conversion or converter
unit, but simple-scu-card.txt and your patch refer to making the
sampling rate covert.  Perhaps "covert" should be "convert."
Kuninori Morimoto June 5, 2017, 6:23 a.m. UTC | #2 
Hi James

> On Mon, Jun 05, 2017 at 04:25:15AM +0000, Kuninori Morimoto wrote:
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> >  .../bindings/sound/audio-graph-scu-card.txt        | 47 +++++++++++++++++++++-
> >  1 file changed, 46 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt b/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt
> > index b2dd23f..ca494cf 100644
> > --- a/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt
> > +++ b/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt
> > @@ -35,7 +35,7 @@ Required properties:
> >  - compatible				: "audio-graph-scu-card";
> >  - dais					: list of CPU DAI port{s}
> >  
> > -Example
> > +Example 1. Sampling Rate Covert
> 
> Other documentation refers to sampling rate conversion or converter
> unit, but simple-scu-card.txt and your patch refer to making the
> sampling rate covert.  Perhaps "covert" should be "convert."

Let's use "Sampling Rate Conversion".
will do in v2

Best regards
---
Kuninori Morimoto
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt b/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt
index b2dd23f..ca494cf 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt
+++ b/Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt
@@ -35,7 +35,7 @@  Required properties:
 - compatible				: "audio-graph-scu-card";
 - dais					: list of CPU DAI port{s}
 
-Example
+Example 1. Sampling Rate Covert
 
 	sound_card {
 		compatible = "audio-graph-scu-card";
@@ -70,3 +70,48 @@  Example
 			};
 		};
 	};
+
+Example 2. 2 CPU 1 Codec (Mixing)
+
+	sound_card {
+		compatible = "audio-graph-scu-card";
+
+		label = "sound-card";
+		prefix = "codec";
+		routing = "codec Playback", "DAI0 Playback",
+			"codec Playback", "DAI1 Playback";
+		convert-rate = <48000>;
+
+		dais = <&cpu_port0
+			&cpu_port1>;
+	};
+
+	audio-codec {
+		...
+
+		port {
+			codec_endpoint: endpoint {
+				remote-endpoint = <&cpu_endpoint0>;
+			};
+		};
+	};
+
+	dai-controller {
+		...
+		ports {
+			cpu_port0: port {
+				cpu_endpoint0: endpoint {
+					remote-endpoint = <&codec_endpoint>;
+
+					dai-format = "left_j";
+					...
+				};
+			};
+			cpu_port1: port {
+				cpu_endpoint1: endpoint {
+					dai-format = "left_j";
+					...
+				};
+			};
+		};
+	};