diff mbox series

[2/5] ASoC: soc-pcm: tidyup soc_pcm_hw_clean() - step2

Message ID 87ilxvt7e6.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Accepted
Commit 86e4aef6c9a113374f69c6dc63877e10935926a7
Headers show
Series ASoC: cleanup / tidyup soc-pcm/core/component | expand

Commit Message

Kuninori Morimoto Oct. 18, 2021, 2:05 a.m. UTC
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

DAI active count is not exchanged during for_each_rtd_dais()
loops. We don't need to keep snd_soc_dai_stream_active() as
"active" on soc_pcm_hw_clean(). This patch avoid verbose code.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/soc-pcm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 0e51dd6d95bd..4309e6131c40 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -879,12 +879,10 @@  static int soc_pcm_hw_clean(struct snd_pcm_substream *substream, int rollback)
 
 	/* clear the corresponding DAIs parameters when going to be inactive */
 	for_each_rtd_dais(rtd, i, dai) {
-		int active = snd_soc_dai_stream_active(dai, substream->stream);
-
 		if (snd_soc_dai_active(dai) == 1)
 			soc_pcm_set_dai_params(dai, NULL);
 
-		if (active == 1)
+		if (snd_soc_dai_stream_active(dai, substream->stream) == 1)
 			snd_soc_dai_digital_mute(dai, 1, substream->stream);
 	}