Message ID | 87k1z0p5of.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <alsa-devel-bounces@alsa-project.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C6FD7601EB for <patchwork-alsa-devel@patchwork.kernel.org>; Thu, 9 Nov 2017 02:35:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AFAC22A89A for <patchwork-alsa-devel@patchwork.kernel.org>; Thu, 9 Nov 2017 02:35:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A49B42A8B5; Thu, 9 Nov 2017 02:35:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B7F6D2A8B9 for <patchwork-alsa-devel@patchwork.kernel.org>; Thu, 9 Nov 2017 02:35:36 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 8866026777E; Thu, 9 Nov 2017 03:21:26 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id D205B2676A7; Thu, 9 Nov 2017 03:15:57 +0100 (CET) Received: from relmlie3.idc.renesas.com (relmlor4.renesas.com [210.160.252.174]) by alsa0.perex.cz (Postfix) with ESMTP id 78CF8267722 for <alsa-devel@alsa-project.org>; Thu, 9 Nov 2017 03:14:36 +0100 (CET) Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie3.idc.renesas.com with ESMTP; 09 Nov 2017 11:14:34 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 8F8296F7CC; Thu, 9 Nov 2017 11:14:34 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.44,367,1505746800"; d="scan'208";a="262925430" Received: from mail-pu1apc01lp0023.outbound.protection.outlook.com (HELO APC01-PU1-obe.outbound.protection.outlook.com) ([65.55.88.23]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 09 Nov 2017 11:14:34 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rnadAxWjw57928hRPG9C0VgqJyC3LEZ+4wVMJhT96u8=; b=X/JG5Gk56babD0lWu0MXmm6+PMsL3+99Jmi3+CMtIfZwX+XMzIF//by4FglzWup0Sje0tpt1+cEYYFQ9ZOO5ZvBPaUA8zPLZSn3Kh+RA8dSJb55VCyZxUeg7sTRRt7o/YeetN67cs7M5qZtFq6AAqpUsNzNG7lIzqJ9ph62Haes= Received: from morimoto-PC.renesas.com (211.11.155.138) by PS1PR0601MB1881.apcprd06.prod.outlook.com (2603:1096:803:8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.218.12; Thu, 9 Nov 2017 02:14:31 +0000 Message-ID: <87k1z0p5of.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de> In-Reply-To: <87r2t8p5tz.wl%kuninori.morimoto.gx@renesas.com> References: <87r2t8p5tz.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Thu, 9 Nov 2017 02:14:31 +0000 X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: PS1PR0601CA0090.apcprd06.prod.outlook.com (2603:1096:803:1::16) To PS1PR0601MB1881.apcprd06.prod.outlook.com (2603:1096:803:8::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 99770217-3148-4eac-cc6a-08d527179d5b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603249); SRVR:PS1PR0601MB1881; X-Microsoft-Exchange-Diagnostics: 1; PS1PR0601MB1881; 3:ZjaHhQ+ZUuyBk2biG5grm5D/0COccmMkdF3HqfXQISHoq0Qp70e3x8CEN2R29kz31B34YeVz3qOpFiUcHZH2QmKjxjLTkcEGW9deZf3y72bY+bm0HEgVxc3y2lDZnx5g7DxqDyAEIKoq43tg200NTkZ3k3WBdhmppqPp0wqi5AbA2G2hQXnycsfJmEna5j97cFRx4S6amitVBDNkncvfAeS3fkqWEVbJpIWjl94N6I46L2B63u3K24OyN1GCNsiC; 25:cq4dPNpX/4eQfmuZZMacjREdw1HBPVYRzwo/bJR2r2DVlBz2L3Ij5t6nZX6uHyz9A/O2/LHxP1ngDLmTuccICDRJ81ltkJmOecgi2APnee+9PHQBhuSZl/UaHpWvB+j5ttRbx1N8gpYFnR0yLcTQnR1fwt+rbARc+aK0o7Zq9ct3gp3E5E/v9ndIe3vaUt9mMiSLLnbJ/vL+hLEnOoEjfB7fJGMAEQdAkoEIKCrfIYPGpnTsnFtQfK5GiMMjGaShhs5WjchWmXxzJLM6K8C+Er2V7f5pbrusgblX/rg4hWymdTtDQUj3Yo+NMv+I8Z7T/csO321wxu1sXP7PmdI6CA==; 31:ET9HP25K7hnE5/UQmQRY+JFsS7vfUEQZi3IVQJ3BGpPIUOs9GLikrfSOi0lnte/D8TQVczCEkF5iImoSbswtjuvkRgWUYZrXSpuCfFzb/82ykm2ipDsvCpu9f5NSdXaZMC1e6izxSk2hn2ZYd/O8nRfBse1LdSR4J77l+s7UxRpMhbLroV4wJr2Iye3yvFAGeWdMHcgl+2ad+ZysmBVyXBePE6MJ2uaHFp7kacwC2P0= X-MS-TrafficTypeDiagnostic: PS1PR0601MB1881: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; X-Microsoft-Exchange-Diagnostics: 1; PS1PR0601MB1881; 20:sZpmOVOJqDXAjFzPrUNXv6OfkA67FX6z8yzrVPEFIMXeZY9k2F4iZZg1U6sUgDY+Dk+hdyqt7HWG3mmXd2xNb5UaiFYf4zJuVuaPaQr5fVDhkeGB2g3pb8Ok1LWDXuKaI1sP6xuP7SavDB/N93dPgERAOPFMdl4+jSoPe2qZJtXYdsBdGiIa0c3JRBLSWGff6lgdGCUG7h3/EASmmZdEwo8SKyQ5MUduGRATYKxJunKYpl+34aVnyFTGVqqOgypI9mXh0LSSrhQMgYKP7OVPslVf6WUQMexWUwI1yzzq153FDRn6uy8+A3YQcQ5MEh8OwNTWd99ACpwSI534HrKBWJUutTVX7SQ/KXlWOtdGZX/6VMZAthec/0xHehk2v8s6ZPfK4hNOP+x/WMdyiAypwl4EUUkOziT3JsMg10nTloFdNhfl3x/MUtRqoV3KwX4prbY+d8q14lIBqWv+YuRLnoTKq59cP65MbPyE5PQnK0g/keBzYvXkm/kO03nkU4l4; 4:RA5gweXyu4Fs47AHym1c8vjGgKyQyapx3lIL/00oaE19XwyC4k5ixIjVG1ev3qLz4DXNwPTorraUSJ5QA55I4T1U69C/0zD8AwUOQH8meXI33hZzDFf6F8W/zZ/XbgHybumlJJf6MEcnX5qDB2XCZ32lL7am34Bn5b+Wi+YO7RxIO2X1T02z1U7uV2OSzhTZJxtMJ1hPa4CdbdY3rWPZ83e4yFgEktbD9rcV3/jvZ5lA5bB4Wx/pDSFZ3s9WSqQwWI0t3UWKB4RABg1ZZRGAzA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: <PS1PR0601MB188173873F68518CDD9A5AA3D4570@PS1PR0601MB1881.apcprd06.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(3231021)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:PS1PR0601MB1881; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:PS1PR0601MB1881; X-Forefront-PRVS: 0486A0CB86 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(979002)(6009001)(346002)(376002)(39860400002)(189002)(199003)(50466002)(33646002)(106356001)(2950100002)(97736004)(316002)(2906002)(58126008)(5660300001)(54906003)(68736007)(110136005)(4326008)(16586007)(66066001)(76176999)(54356999)(81156014)(81166006)(8676002)(8936002)(6116002)(3846002)(6486002)(69596002)(50986999)(23726003)(53936002)(47776003)(478600001)(53416004)(105586002)(36756003)(86362001)(575784001)(16526018)(101416001)(25786009)(189998001)(83506002)(7736002)(305945005)(16060500001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:PS1PR0601MB1881; H:morimoto-PC.renesas.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; PS1PR0601MB1881; 23:ZdwEo8JB4uWGIfjR0Ls04eQ8h+S6UJM7uT0t1eG?= =?us-ascii?Q?81VNIQSvkN3ixo0lAAiP+lcC8HMz9SeeJIKuVuKtfqA1levkZd3P6UjJO9vY?= =?us-ascii?Q?1c1OM0f+Enu2E7l4NiswQIAc5soKOegWeBGfnFyZQ66Ml3iz46qowUuNW7cs?= =?us-ascii?Q?yDkkkt5DwgSZ8ikK8iOkBw1h/LuHi1U5z0RzYgKshL+BdUO6detwxmNA8ORW?= =?us-ascii?Q?Pj70DLCWaW1jponvkPC3/UVnG8CBVxWX2Ej3P5XbpchZV70EBMVbnbYnPwc/?= =?us-ascii?Q?VGcg4gRjD7eo32ntb4hg0un6L3UouZ1hoJWL9L0TE8la9/oaFE6yrDQpua/r?= =?us-ascii?Q?GysYo5g/qwxP6H3QS4KkclcooucmNfyhe/Lk6F8A0nr8qgJ4HJ36MPSWWaJg?= =?us-ascii?Q?Jtmx4DMd2X/gsrt02GpWTqcIvEjN2lAdxpf4QwUVvmDX5vSXHV8423F/cLLe?= =?us-ascii?Q?gfWFWg3nWWmqhn2707mDM8QOYCtbd5fZRzs/eCu9afkNpdvG1mpu+UXxd2lX?= =?us-ascii?Q?1ause40+Qt4ZAwi0Zs2moHXLX12DDwGnJG0zrkDIfPDY8Jj09GjRhFBcgYjx?= =?us-ascii?Q?VFAELdxz0qEGRqR79NMHGVcjy1Abvd34eR2P5K/WWqwCaKNwhgtBdfFucXk1?= =?us-ascii?Q?Bjzm54YSO7JXqXC5psSgoiUutHlqyHSg83bvTYJUeJngifVJtHigtkHjNl+f?= =?us-ascii?Q?BdqPL4AX5tpkO5z+2BfmZEq++oCohRew9LX2dTwzMNKZuwwKW/wOv1lqwhhn?= =?us-ascii?Q?nxpRwcRikS4wCzTwFI8QL0JglV9KnpNU8phroVU3Lb/V+CYuFq73KVpykw+s?= =?us-ascii?Q?rLlY5vuRsyihgVsYYwvlrgw/fPfimUk1eRBvGPT9I7Dia1h20jeLTnZibKy0?= =?us-ascii?Q?l4tbgH8FoN3CFffkxNCRLdSE+HWArBfy2TA/NKIbo6HqPUDNhSgST0fV72wO?= =?us-ascii?Q?joppueakt6cq+ik8ynwWo4di+UR3uMcZvYeXFHefFe7DNMZS2VHC6BuxuNLf?= =?us-ascii?Q?mfT3mHjHJUNlxX+ctaMmGMKu3TbJIKdqpz8O2cVL2OsYCgmitzaVmeqGFqIA?= =?us-ascii?Q?3ijXAUsY9NjgWhcKnGeA9DNEkUfUEmlmgGQZduv0kTqGqQj13+ANPac8uSwj?= =?us-ascii?Q?D1JURZ2484YemHC3HYV/rzRI26gMDx1H87J4oU/Ori/FmZxILm1Tip5VQyrq?= =?us-ascii?Q?9JHFwgIhhR9WUZXo0CnkBzHt0EMupBEwTD+BXpKYuCt0hlFyK8APrIhu0Qvx?= =?us-ascii?Q?W+VlUAwAPKG50I2nfbPI=3D?= X-Microsoft-Exchange-Diagnostics: 1; PS1PR0601MB1881; 6:i0Q0g/Y+YbdWvCOFcCH3/874a9jHD/531608vJR3tI9h4fmM+gE5IlsVdNwuDQn7jbp745KZsFxbqtrlxduUofWJFy53OABMGkXxcvT3WiGsq3eVFt4tiN9hkOGpo/ckYDxoUUqyNOyh/7KZQmhJYdsbAQPhseWmdKq1ok4fvOoieVGlaxEPNI84Q35xLl0mmRITnJZZMVE5UEcPMYgtKYkIr1AgA6DdfyGwDoUVqcz+AAquRWuB/UYAOQSgdtfRUUjyfRY26IiLXY5dXU8AIHYun/DzGxdSl/VmIJAgxlonbXkukcb1+JXXy5Jv+mqp3M989ka5cW9n+drS6Cvcgrd8gFyZdY2YEdQHSaYmo3k=; 5:zvqqIPW8xIdKuD9ElSYNLUYjFj1nyHPATVJ5Jzcso0OGsL99qD6ZzaX6vWb7++LL857SqI8rdnVes7g3BcyvzKtMoMJMEAaVJySeYVl0NE2GUGj8kipdOt8FZr+64DMVKXSM6HS2WNzgm/ZEt62427OtvFLj4PT1sQCyuz5zxaM=; 24:D/EZ2kydDEWwU6dBh3zvX6ylasi8U8kG5ZQtgb1ZOZk6V/H+91mG7HvnYO2hiaY66iJR2H6iuAokOBTtAIaP9ykOJBQvSYXf4/WfSOCL88w=; 7:bj4Q9DTAION1JVsj5O/5EH9kwGF3+C4px66iLPkZyJe9N5hisVglJoxhlKvHKmIB8fIhqhFmG11nqYIarNNOrgpSckKtIBfw1S6UwgTzBRScXDVuN681UN7DgpMHUJ5ZcrtXuNAPX6pm/uXefJ3/RM7sXB2ubU6nxjRUpfTkXjSagYoEYV9de+KRNtuYWtzlwSzJ8doJBs31ojiEcg0axH1NfYeOlYs5Ah3M4vFm3gu5F3HNtLycbFNgBTul4a5+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; PS1PR0601MB1881; 20:5sT7RwQabsZzC2GaXGt8eCr5NhotBJGd9X7BkWDZ1yryNxTdQJAlFLPPc/HMr+KZXfreIKt65CM5mFnW5xwSAv08tJGGClZMUVg1Zu9tOWmv8qEjJTLmWSRsHVFXsyarbNhDJY2nosNzD7aceM0AwRJ3c9H7ebF28Gb51cTXJIU= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2017 02:14:31.6813 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99770217-3148-4eac-cc6a-08d527179d5b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR0601MB1881 Cc: Linux-ALSA <alsa-devel@alsa-project.org>, Simon <horms@verge.net.au> Subject: [alsa-devel] [PATCH 5/6] ASoC: xtfpga-i2s: remove unneeded check for snd_pcm_running() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" <alsa-devel.alsa-project.org> List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>, <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe> List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/> List-Post: <mailto:alsa-devel@alsa-project.org> List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help> List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>, <mailto:alsa-devel-request@alsa-project.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/sound/soc/xtensa/xtfpga-i2s.c b/sound/soc/xtensa/xtfpga-i2s.c index bc3151c..bf0c7b7 100644 --- a/sound/soc/xtensa/xtfpga-i2s.c +++ b/sound/soc/xtensa/xtfpga-i2s.c @@ -163,7 +163,7 @@ static bool xtfpga_pcm_push_tx(struct xtfpga_i2s *i2s) rcu_read_lock(); tx_substream = rcu_dereference(i2s->tx_substream); - tx_active = tx_substream && snd_pcm_running(tx_substream); + tx_active = snd_pcm_running(tx_substream); if (tx_active) { unsigned tx_ptr = ACCESS_ONCE(i2s->tx_ptr); unsigned new_tx_ptr = i2s->tx_fn(i2s, tx_substream->runtime, @@ -254,7 +254,7 @@ static irqreturn_t xtfpga_i2s_threaded_irq_handler(int irq, void *dev_id) rcu_read_lock(); tx_substream = rcu_dereference(i2s->tx_substream); - if (tx_substream && snd_pcm_running(tx_substream)) { + if (snd_pcm_running(tx_substream)) { snd_pcm_period_elapsed(tx_substream); if (int_status & XTFPGA_I2S_INT_UNDERRUN) dev_dbg_ratelimited(i2s->dev, "%s: underrun\n",