diff mbox series

ASoC: rsnd: core.c: indicate warning if strange TDM width was set

Message ID 87lel6ksqn.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Accepted
Commit 1ad059a15707cfb066ae3d7342d59770f04aac5a
Headers show
Series ASoC: rsnd: core.c: indicate warning if strange TDM width was set | expand

Commit Message

Kuninori Morimoto Feb. 10, 2023, 5:13 a.m. UTC
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current rsnd silently uses default TDM width if it was strange
settings. It is difficult to notice about it.
This patch indicates warning for it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/sh/rcar/core.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Mark Brown Feb. 10, 2023, 4:50 p.m. UTC | #1
On Fri, 10 Feb 2023 05:13:43 +0000, Kuninori Morimoto wrote:
> Current rsnd silently uses default TDM width if it was strange
> settings. It is difficult to notice about it.
> This patch indicates warning for it.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rsnd: core.c: indicate warning if strange TDM width was set
      commit: 1ad059a15707cfb066ae3d7342d59770f04aac5a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
index a9125c1ff75a..cb17f7d0cf0c 100644
--- a/sound/soc/sh/rcar/core.c
+++ b/sound/soc/sh/rcar/core.c
@@ -828,6 +828,13 @@  static int rsnd_soc_set_dai_tdm_slot(struct snd_soc_dai *dai,
 		break;
 	default:
 		/* use default */
+		/*
+		 * Indicate warning if DT has "dai-tdm-slot-width"
+		 * but the value was not expected.
+		 */
+		if (slot_width)
+			dev_warn(dev, "unsupported TDM slot width (%d), force to use default 32\n",
+				 slot_width);
 		slot_width = 32;
 	}