From patchwork Wed Oct 17 01:55:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 10644505 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 69871109C for ; Wed, 17 Oct 2018 01:55:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A1842905C for ; Wed, 17 Oct 2018 01:55:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4CEDE2908E; Wed, 17 Oct 2018 01:55:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60FCC2905C for ; Wed, 17 Oct 2018 01:55:12 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id E37AB2675AE; Wed, 17 Oct 2018 03:55:10 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id C35C12675AC; Wed, 17 Oct 2018 03:55:07 +0200 (CEST) Received: from relmlie2.idc.renesas.com (relmlor3.renesas.com [210.160.252.173]) by alsa0.perex.cz (Postfix) with ESMTP id 10121267546 for ; Wed, 17 Oct 2018 03:55:04 +0200 (CEST) Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie2.idc.renesas.com with ESMTP; 17 Oct 2018 10:55:03 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 8D11C7A215; Wed, 17 Oct 2018 10:55:03 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.54,389,1534777200"; d="scan'208";a="295342069" Received: from mail-os2jpn01lp0147.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([23.103.139.147]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Oct 2018 10:55:03 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CbAiODuyA78AgRVs3fpLMcRGY0QRufl6wDZKlw2OQTI=; b=fq0ngFz5dnP+fvCBV1pAkhhvcAVTymGegLVdvMj3x94hkCYnsI39iXJmeliGEQ86bzT5GV7okqekkj1bNnXJH5R7NDMv0pXHNfnXkLrR0Ot+njG1PQj5pkCL8UVYqxw4JgRbjz/wXzy9Ni2LZzofR3p/d/IlXe8Ns7hzW/M+AKQ= Received: from morimoto-PC.renesas.com (211.11.155.130) by TYXPR01MB0622.jpnprd01.prod.outlook.com (2603:1096:401:6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.23; Wed, 17 Oct 2018 01:55:01 +0000 Message-ID: <87murdz6nq.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 To: Mark Brown MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Wed, 17 Oct 2018 01:55:01 +0000 X-Originating-IP: [211.11.155.130] X-ClientProxiedBy: TY2PR06CA0008.apcprd06.prod.outlook.com (2603:1096:404:42::20) To TYXPR01MB0622.jpnprd01.prod.outlook.com (2603:1096:401:6::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73457169-1990-4a2a-58aa-08d633d38d18 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:TYXPR01MB0622; X-Microsoft-Exchange-Diagnostics: 1; TYXPR01MB0622; 3:AerdYrUCufQc2s2Yvl2RpSCpnZhhDpxS+hBvXnoV+EwCZsJVYpR7K/Cor230KHcEEkxH35P5tAhjpEDZmvJyOrWcFALsSJvc2A3VUFWssXvJl0vH+Tf8vLhVNlE7Mkg2ZxyuQ8cELHFlgHMbDoKEIjnGL/VZ+BqbOHlrowpzClQ8wXNUmTEpN47MKwdHpUb/Z/WYBCSCKuVTWkzdOVhDfenOPqR9mkQnDI6G9GSe/UiW0JqRZwLF2fsvJY0mvs7W; 25:19qX0TjZBc6/Lq2Uqi2hzzRYXwg5ki+zXiesALgZG8kYLH8C9PPX3dGUuAnpDI0EtnVbQ0VF4FFvauLXomwqoSWQ3peaidyYAz2zoNfgEiafafy+huIxe0MvRbKszIVLWrD5PxlmNcGyF3XcB0xYakWcXXJoAmlp36DON1jC+ATcE1+BD9VgoxMCjkeLaIwnFgkmOVQeyJG+iK7xFCTivTK3ZriaC7fGab6MBkRqT+nKaC9MRXnYrBIWlrWPms9D8/gfDT1hCbsfgxJbXyUOD2qtNW8oEDj04bpT2t0X09IA22UTEk3QCPm8oAdzfC6IIjOtlbKKgRUtG8aJRu9Jzw==; 31:Zngr7GXLd04CTjExmOvxAc6DBVZ3nvYS7SSeDAZaN8gQzfIQuWAaTw2dOFPbQ25NVAV9siqVuiAbBoiM+gCdXHmJQQPexpWEK/vjkugCUzGIbJJDAiVJuWPPV0a7vrrFGB/afiYWw9CtGPFpMquee5Ukz6H021mlM545VQpvyl6QjdPBMYuM8EaHbEZErSWRtLZBgHQBf3kh39IUyCg/2rO8VAJMiqifEqmaAqJgpA4= X-MS-TrafficTypeDiagnostic: TYXPR01MB0622: X-Microsoft-Exchange-Diagnostics: 1; TYXPR01MB0622; 20:F9GCWkajUXtqUisGj1HXKzFLlgDjVEAWJX3FchjY6wJob8KaG1ZKBsg7NOpju6Tz5mF8ybFwvp3qrccpBky/dIKEqfM3wDRNPL3B55+Jb1CMY+IcwMIVHHdQR1GetlxeKKJ7B7bv8MX7PbzJAhfLUV/CcbbMFzKEaz3DMW50nWLMwX2l95UjeXYzgVzBWPfrHg/lnzeoZnpcfYpkWoUeau89TdUgz0JfzOZF2goQOFOgVObyi+vpYxNGlnGziBETtjo4h7Ytq12EyF/9atVKkwhhHbcGq2znO0S7pgXe1Qa5cYmEdM52kjDE8RRLlVuM8E8YELVW1TAQVsPJ7i83Ds5Jk7DFXWgGDLosFxJmifOYxvlVaLVFOVDY/youYWNsGqC0hnxTxw9C15aIxeHn33cKmXbMbCpSYm4c5kYAajn9nX9yEfmc7ReClFkEYYztb4tM8k/wZrJN4cbNTO0V/L8CgU4HW8l9jrfa4cd9V5nyj4ZbrDg8e095UueFeIDt; 4:M71El8PCIcbXZXs008jurOzMZ04qLRw6SU5OzKYPrZozzb7z16V6iLf5OB47GusUrTPQtio8tygNy91k96IQTDpLq+xm4IpbWY9QJI1i+2VrFhY69eaEHLdc/IMvH4gWWqWD+C5bz8k7sJUOTVmrQ5JqBCAKIqZ4/G1jPs3Pq0dsgnRkt8K5E0iKJfTmBOoO+qMxp6crUQMAEiv4dg8scWK2Jm9xPti0E3y/zFBHNNyxBHYwv4gEiDR0WoxblSd3NMweakDskdmBIsoYKQlp1g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991084); SRVR:TYXPR01MB0622; BCL:0; PCL:0; RULEID:; SRVR:TYXPR01MB0622; X-Forefront-PRVS: 08286A0BE2 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(979002)(346002)(396003)(376002)(136003)(366004)(39860400002)(199004)(189003)(305945005)(8936002)(36756003)(86362001)(7736002)(53416004)(97736004)(68736007)(105586002)(26005)(6346003)(81156014)(69596002)(50466002)(8676002)(106356001)(81166006)(47776003)(4326008)(2906002)(6486002)(386003)(6916009)(486006)(478600001)(53936002)(58126008)(66066001)(2616005)(956004)(25786009)(476003)(16526019)(23726003)(6116002)(16586007)(316002)(52116002)(7696005)(3846002)(5660300001)(186003)(1857600001)(16060500001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:TYXPR01MB0622; H:morimoto-PC.renesas.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TYXPR01MB0622; 23:PZlTWXM9K3VIXMTqvPRcnJMlyKlNQQpyhOfXeeCUI?= U8Kt5cUo1NEMjrFrgDSkokN+P4reI1zSB4HCo6MJktuR7Bnf1O6Lmqs6htTmboCxTcWi6PXFSYlEm0jlOYk6boE5leBZV97CmZzfECf7DVeyu7snQzmdOONnh3KGHRK2gxw1VQwjXSxSUtrtlc+kgNQQmCCRCgt7Ricsg+BcBulMhmOMjFQeuQmyZws5RGssp+1kxUl3kT/9l1kcAKI98sbAunOXsiNMfsIYOYqQvBHzJ+p21KxNkRk9Eunl5C0jBDv6cI4uQIwmNCAinX8dM9ZzDhpFm9IBz6CvZqSL+y2x4v0IxZT7oqdDoyrCj5nt92H1qbyi3IEaSRKnsUYePArdHe6lF0wnfaIthA1O/4uOXpijSuZWwygBfk8dqzQ2c8gbUayup47r7vPOtl5DFdJZWa3iaRazWOOFZckzHvPF9ZRR7OF6h2bYNCFQBQUx1OgZlK7kHCW20vRzO3NBJFJWNupE0h2Yf5GtIogl+lY1I9ravoa4UT+vfjJmG+q5O0kCGzJ8/uMHV1yQjsYrU4Pm95gOR5PkBfQcM9eEpHCfE1TIFtVYvUJAt+6mGpv8blFzVEAQ9jdjVCAr6dhubiUOnKGT4fT02dCBxrQHf2WPdtWPj6c2f2Si5CKW3hngaOM0K5wy5u8ZMw9At97PmKp7GbhQkRnEdgUFByjqzcyND5mHy4lT8717nRKfCUKyWvpy/b5Wdv38Tx9Gxfrm/RWLnhZ12tZ77gaB0cX77lNTxFOzvv98JvTJvLRVwMqy4f9jBKyxj6D6vQkeTVR9pvoFRHkQIWqs3hvclqPDXU4hFxUTjq/EHZ4+Whr21vrUsBIO1yIcrwbsizWghFJVsElKa4QXjC6U9Y5zIb4Fj2IOcB2bUzDnqwOqsLP0dcAW6lXSQLRCEsuK+NJY2Hj1m9a6c2xIw6n4J+OXDk1I+awasyoAcBFnTFTnWlZsywgNvQmPDyAg7wmoR6lCuFc/6y+HaP7I226BQP+ooxIYFx20mC4P9lf8YG5B5NMadCGCRbJHENW0L7i4KDfoI2qm6DB7UVKB3EBVvZYHU1dlnPI5/oiYuQqdimPZnuLTcQ/GWnNzXNnmpVqpfwEFeZI3LUQ5sOPNjYskFGC0g5Hu1Z1vylBRgPvoSfROt3k3LGTBBsxHCHTfgS1Lzajqwob2iEYyA2gXwNcTI3yVrJnXSUIaqcBqB1HtNQOTiDwjsj9lRav7CyK2x06Zg1KRc8NTHxv X-Microsoft-Antispam-Message-Info: nFTPAqrU+6Ghz/s32bFCsrO2DEXXX6mJJcTEceu6O2HqqUANA51W4PZ2bOaRZXcN3r6WyPElf5+mqZEq41UjwstKislvVQRSPn4FrAnDdfs8bIDyQ3g27NMGlRUyy+Myp02dQ5vNUi/LsVnP68Jk+bIpAv41wR6EMOfAI6ZIhPIyOTV9g/LdlUqlrzU1Q+s8DFQim/nm1CS5duvvSmf+8lmUeXBQ+REZeVdwX/ciqYbmY8DOWtTaw+e6C3lc8/q+q8pEbtsGStuj/qPCjW63im5ec+K/bcJFkUQ0FGNraMIp7rzwc9yHCTSACfN5Moqvu/rABrROXD1rKl0Rk/TUP+18J/b2kDknMrZb6IstmDg= X-Microsoft-Exchange-Diagnostics: 1; TYXPR01MB0622; 6:dItfkkD67WLhFigVynEniQTxJUtvKaIR7gfIN8Pq0PW11bd1elnzkz6V/A9wiXeta3JozkUWjFICcYsNLyDjjmTivgIhNUYtsii8R7YZMulJH4xB45KtBPObdLRmUg5zd8GtYCcjh+SOASedYuSFTmPxWvLgbKbTYv8C/ekcQN2KuwVbIpVNL3Jt993upeysE4qvayQZFVBkshaSHuenGqdkaevQJKalDh2B/eJ/o3LHIJQcLlUSno5OMQZZlwV5KdnR+Zoey+p83RH7JzesucjFE/Y5FC+m4QMs7RK7q1j01eXTHUph1Mn6u/UpER2PmLGpQkT2qJccmNHiUgLSr/HQwt+qbREn/L1F3MNYbPZI+V4VkeYIuDWy8vkeF6Mpx/V+yruQ35E/KovsFDOvSQ19kEhy4ZYXJlS5JBeV73jseBcpC6uq7onnUNdzwH8zC3kwmktHNnc0vkoUJgXXEg==; 5:H984/nvSEJAvtX2okuQG5VAvW16os+7uPelkrxlsUoMapLch/j0PDHwqh65KLwvtg1GPC8bXQjcnB/DdITmyrwOkdKQiKJFUouq1ept/Ie5ihWAQYZrunHEbSpZt1R0vKHMAMZwlassxg9y2fWfvlxFD6wAlehkAs/kTT4v0lE4=; 7:jV7uBWejTHzfO/augNITgYleaw4gxbYwhiQ5YrMflUK1L3xY95QTo+4PxEUjRZXFt2eZn89LJywcbU3hZO9IhochD+8/RGqLRhbH3fC4b5UOjNdZSlk4xtZJF270joNQ4+XsQEAerWvmlt/s8GhZWooXGDch0PgOB1m04JreAnKelYBQQrSTYhLs3V59lTcfSE8MtYzTSSyEg7BvCnRpTnBuDk0PrxiRqEXkIPlvi518/6MEuEJX8rqFcSNir4kB SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TYXPR01MB0622; 20:flk3h4PyRhgfsXvOpUOWfcGXnMHiThA/HtYhB/J6PnFyNpQzP+XYJW0yY8gqUFoZbtbSlzlaDBUyhiPVXe3LFD67UHqiemUPOpz6UxXW8eanIO0QHLc0GiXzowvW0VURdvMDbTJbugAJzSPsoQjyrj4lEnxgiSBcOFgyMUSkQS0= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2018 01:55:01.7334 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73457169-1990-4a2a-58aa-08d633d38d18 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYXPR01MB0622 Cc: Linux-ALSA Subject: [alsa-devel] [PATCH] ASoC: pcm3168a: remove read-only status register from snd_kcontrol_new X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto "DACn Zero Flag" and "ADCn Overflow Flag" are read-only status register. There is no detail explanation of these register on datasheet, but, judging from it behavior, it seems these register needs clock to reading. Therefor, amixer command will be failed under non working timing. Let's ignore these from snd_kcontrol_new so far, but keep it under #if 0. Without this patch, amixer command offten failed and can't sound settings. This patch is tested on R-Car H3 ulcb-kf board, SSI3/4 TDM sound. Signed-off-by: Kuninori Morimoto --- sound/soc/codecs/pcm3168a.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index 52cc950..29eaf9d 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -133,10 +133,13 @@ static const struct snd_kcontrol_new pcm3168a_snd_controls[] = { SOC_DOUBLE("DAC2 Invert Switch", PCM3168A_DAC_INV, 2, 3, 1, 0), SOC_DOUBLE("DAC3 Invert Switch", PCM3168A_DAC_INV, 4, 5, 1, 0), SOC_DOUBLE("DAC4 Invert Switch", PCM3168A_DAC_INV, 6, 7, 1, 0), +#if 0 + /* read-only status register needs clocks */ SOC_DOUBLE_STS("DAC1 Zero Flag", PCM3168A_DAC_ZERO, 0, 1, 1, 0), SOC_DOUBLE_STS("DAC2 Zero Flag", PCM3168A_DAC_ZERO, 2, 3, 1, 0), SOC_DOUBLE_STS("DAC3 Zero Flag", PCM3168A_DAC_ZERO, 4, 5, 1, 0), SOC_DOUBLE_STS("DAC4 Zero Flag", PCM3168A_DAC_ZERO, 6, 7, 1, 0), +#endif SOC_ENUM("DAC Volume Control Type", pcm3168a_dac_volume_type), SOC_ENUM("DAC Volume Rate Multiplier", pcm3168a_dac_att_mult), SOC_ENUM("DAC De-Emphasis", pcm3168a_dac_demp), @@ -176,9 +179,12 @@ static const struct snd_kcontrol_new pcm3168a_snd_controls[] = { SOC_DOUBLE("ADC1 Mute Switch", PCM3168A_ADC_MUTE, 0, 1, 1, 0), SOC_DOUBLE("ADC2 Mute Switch", PCM3168A_ADC_MUTE, 2, 3, 1, 0), SOC_DOUBLE("ADC3 Mute Switch", PCM3168A_ADC_MUTE, 4, 5, 1, 0), +#if 0 + /* read-only status register needs clocks */ SOC_DOUBLE_STS("ADC1 Overflow Flag", PCM3168A_ADC_OV, 0, 1, 1, 0), SOC_DOUBLE_STS("ADC2 Overflow Flag", PCM3168A_ADC_OV, 2, 3, 1, 0), SOC_DOUBLE_STS("ADC3 Overflow Flag", PCM3168A_ADC_OV, 4, 5, 1, 0), +#endif SOC_ENUM("ADC Volume Control Type", pcm3168a_adc_volume_type), SOC_ENUM("ADC Volume Rate Multiplier", pcm3168a_adc_att_mult), SOC_ENUM("ADC Overflow Flag Polarity", pcm3168a_adc_ov_pol),