From patchwork Fri May 19 00:58:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 9735443 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6883F601A1 for ; Fri, 19 May 2017 00:59:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 51871288A8 for ; Fri, 19 May 2017 00:59:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 466A3288E5; Fri, 19 May 2017 00:59:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89046288A8 for ; Fri, 19 May 2017 00:59:03 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 69AA2267576; Fri, 19 May 2017 02:59:00 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 88AEE267575; Fri, 19 May 2017 02:58:58 +0200 (CEST) Received: from relmlie2.idc.renesas.com (relmlor3.renesas.com [210.160.252.173]) by alsa0.perex.cz (Postfix) with ESMTP id 101D7267584 for ; Fri, 19 May 2017 02:58:26 +0200 (CEST) Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie2.idc.renesas.com with ESMTP; 19 May 2017 09:58:22 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 6959F68AC0; Fri, 19 May 2017 09:58:22 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.38,361,1491231600"; d="scan'208";a="244366269" Received: from mail-sg2apc01lp0241.outbound.protection.outlook.com (HELO APC01-SG2-obe.outbound.protection.outlook.com) ([65.55.88.241]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 19 May 2017 09:58:21 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8Xf5iP1cFKrRTs1v3ECYoe0jFK0N3ZnlTeu6twphG1Y=; b=Y4vcA+FIZyoMH6tq1h0/9dMF65WW/9zNpJMmwOuU05XV/q/k9z5crOwyDs1B8ItY7O4gr1AHwqdl4bkK2hwhZSx2p0tzDRzio4R+IVaeJLIgZrG2eUGBvJShuI1s6GnxZXecdB8LgS33Mw2UVM8Q1CnTfO7d7pHc7yHcfK1V1PA= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by HK2PR0601MB1876.apcprd06.prod.outlook.com (10.170.149.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Fri, 19 May 2017 00:58:19 +0000 Message-ID: <87mva93bw4.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown , Dan Carpenter In-Reply-To: <87shk13c1z.wl%kuninori.morimoto.gx@renesas.com> References: <87shk13c1z.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Fri, 19 May 2017 00:58:19 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: SG2PR01CA0039.apcprd01.prod.exchangelabs.com (10.165.9.177) To HK2PR0601MB1876.apcprd06.prod.outlook.com (10.170.149.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62fe05ea-1a18-4305-7021-08d49e5224b0 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:HK2PR0601MB1876; X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 3:wYf6ZdofSY2p3wM2+kU7Cg3BpVn9kcWo6ITFVH5opyUm79lUHfpX2nAg4E7v0cEMt8QduoI3Hne2RKq1ZNT3pVrwZEH2YsYcNH1jvTa4LNCLP68ncvM9I37kG42usHtJfM572JhmJjLdp+7NmTXAtgw2MSaMntfpV5HgFgCHyJ+eBMXa+786StXkOPKmEFVdjHprn/CSr5ZYShkjsp8g3yalBzjEnNUNSy5BK6KzHSSf3bCVweJETepF/59hy7Ek5c6Rq9UkoVZa6J/p2ZUri1bwPEE/9BcgLcwR5IXkO2s1dTTANcUPMo7DWQRtq3cbqDd0M+rxN5LhQLSWc1vAjVK1M07Vs04Y0cXPyzxWL8A=; 25:Sm6W+Z293RLOZFaxkim1mWmf34trgA5+CgvYMi+QpouGdfaXaTv1aNGzMFK2aZ3KLSb3PJS//3o9VWUWA4uvmWu8dmv3Qz68QHrm/cuk3di5TA6sIoYj2IYY3P90pxW0YMNmsSR/iEO6sJkYrKOsmzTYCQYVcc8RzW12w1WPHREpevEby8HlNYZhg1QMM/opHOEX/0weIuEFUhPWeHbn1aoq+jTWqj/SB5aBPOCzWhOhUh9Pe1fg38u+5Zof4udRbHMNwWsAqCF6wSptWAscL9mM3qBAqftl+hOjNCowFQCizedCaKuEW+4gKi3m7NsL/N2ajM20IoRm+exlFjTyCN6zstDb0/0qLRlvjLbdLL2Si7ghDmtNvsjRmnsClNJ8C67pkCBIBoXRaIgEuwQ4P/C2mGWCUcCgtH0iZ9BI/7LxAsteF2EF+a0BDC3Dyld/MZWc54/CHcRLYxreBLMJH6Xw1S0W4SzASbD5H5pNky4= X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 31:NtI4qc1/DVi3HY9Wx0FqEvLtQ/rWg7+nvoZWg1nvdXG0jiHfNtzG6XYetInXQUbZ7fkcoWHKi28DI6Fot2CO85sZrstgoG3iajaJv3QPP/5Z6vPANChFoXbViyrSJwMTEL6GPeb7CjLmjK8jg7g9zZ0zjVxAhZbh69sK8X3hX+SyNekHJYxU/X6I4efalnzy5OpFOZmb1bgFdfsDdH0TMPsxP/YnchUmwn/bucIR7qY/aQ210bTp0UmGaZNX25QTIoorrD9n39aMTgHfOT2UJQ==; 20:JSIOARbY6c1ABhQgffgKIgY1aM8AxuepBZcmRdDtrbuoeA0ZaIXj+VQS+iR/prwQJMUU31HbUtruzwhXqi28JEnIkT+7ATwiTFSXm++3j+wxbMN3S1mVFbC59ujKTLu+I9wlQJOvU3tegq4f601VRLRPfoeYAuiVzEFAHEV/j5/N7z24m098iSIT/vM9xcztFsd7iEQVVTs+gWFS5T7mavyfdZsUpyGRMFZ/SSzChSJCL0Un/TSaf/SCbpZPcb3gyz6GmQ/RsPuKu5k5/QIDNhEqA2AIwEzNDhRSK2vbwnQeM9lbrKzWEb7yuW06n4yzfRXJ7V3IVLfQIwxy/bIJRq52Qo62ueu/s7L9SrVHIeObz8HSm/I6sHsCdM0b97kgTO/eeA1Yr0fu0+DhLVZRPkDit+JN/bQNG2pcCq/rugVITyxorqB0PWaS+zz7MxmkOsOFZYgoJSrLkf9dHpVcojM6eTrQR25n9QAxHapYA9HtabhpSOoCEXSjoPW2b0W5 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(6072148); SRVR:HK2PR0601MB1876; BCL:0; PCL:0; RULEID:; SRVR:HK2PR0601MB1876; X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 4:POeFBYN7GNgC3iFIYfg1I8H9xUrSL0SyYJyXHDDLcidPSj+WUC41A3SQBDkjfJXkiGEYGku+o9VKbcIB+2zuZjY/t1/vTxchUsHGyGbC8RbcO/3vuiR0D/0GYhJsiZc9wv5O6Ry0hstSje3+zbclvyEmkTN76RyPgo3EXoLP+hHOBbzv6xy8f3hCfq3XI5IhTdUbpwANU91gxlSREdX5h6q3jJSAwexahpC9uA86DG2Xn/TvMSj+r5g0Si/PWeeNRdRnPgNJ2s+h+8i7AHnWceNom35fq1EFCaQtQJaKDnNBQc4u4yFsJcgza7zjTNL8VDFZ+JrYJDDXATYpRUFcmcCkdK5gMePBv5FKkof64I17t/udxsD9VgV7Vn4/uXx9ufkGGjHM7SdWz9/R63oog2qaTPbusxGjwphrxa1a/91muufnKCNQuofHF2/E+UjmvMrJb8ZEOmuYf1ICaWZBbaT0fim5JQms/jX4mNyEHyiIRyPAxK97f+cbXXTTQ60hgRz5bUlFY+20j7toy2KqXN/3fDRgchinH4P4xaaLkHyp/jdLzBAMdd+lrfNtI0l+hS2FKrQq6aWMLhMHdZYaEey/f4LmqxY6vPdaGSVo+MaYg68Z7SHWh1qVslUYMdbIM0Ine0DfS883XeIv7HVJ3CtXAK0sf8SDtpua7ikZsaPOMbOytBjWBSimwKAHSuPE+EJswtqkdHfF90KJzcntjVx3O6K3eqyYiMxhnE+0IuehDUwG9pdvUPaqoYiAk2+vDWjWvtDPZc/3D8lSUtnjIC2p1soBWKfMVF/8RjNi5cdo0hvCr1dGgDexel5jJJgn9xCKZGpkcGs6MzRXgF6ekPnZtQAOybNQzshdOaat5S4= X-Forefront-PRVS: 031257FE13 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39840400002)(39450400003)(39860400002)(39400400002)(39850400002)(39410400002)(33646002)(4001350100001)(230783001)(6486002)(50466002)(2950100002)(8676002)(81166006)(36756003)(86362001)(189998001)(2906002)(53936002)(66066001)(47776003)(4326008)(83506001)(5660300001)(53416004)(50986999)(305945005)(25786009)(46406003)(7736002)(54356999)(42186005)(3846002)(23726003)(478600001)(38730400002)(6116002)(54906002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:HK2PR0601MB1876; H:morimoto-PC.renesas.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HK2PR0601MB1876; 23:P/YBgLDq8hkSnr345lWCcj8QsWB13l4k31Qp6qj?= =?us-ascii?Q?9j3qw18YxVIniZQiHxdH52JgS9TnNOckV9IV8ilXZVEqx0qEeFDamy7lNaL0?= =?us-ascii?Q?LrQ5PxfT9WTKRKu3Vqe13hY9ccf2Cj0rKdQqBiGK8gn1albjWTpM0RnaGztX?= =?us-ascii?Q?aNjRnBKpcsOI4544DvID/t1kFyHudVn+LAeyATk+WhKQvw+XkY3HU6gsnMHz?= =?us-ascii?Q?KvxdwnF3UB1vKguuj1Tg6mCszXxg/6SgHxcC6ewZGkols6GrkGqr6+WMLIwb?= =?us-ascii?Q?IeBPnYSoPUzQWyjiOQswjALZwK7ut7a64llnzg7QLoJgEAojLrQXECHGvoeM?= =?us-ascii?Q?e/ieb5TFmDDfQGdGdRsAsSJvn+RaFlkuG5K2BXvIPi/HoQvl4LswLXmxSc7W?= =?us-ascii?Q?FMcB0DHhsHctGLLYHg42fcDCmXEtF++0m8zYeCeFm3Q7y82ypUIIGge0/hgH?= =?us-ascii?Q?xyaixJDxBn3QFOQerPsz/HGNz0ILwehMjCZdM0aHcaet52q0axph9NAfUlX2?= =?us-ascii?Q?BaSisRc3vWWKNHOBZDJHJZfAROYbGFUn1f7vm+1AYPU2pMCjq+20LyfB0X4a?= =?us-ascii?Q?8mHxPpnqmxkbZL3Y8db/IH7kDcmsZjhwjTq0AAPWHknkU/ScwnLmr+RPqM88?= =?us-ascii?Q?kaAdgpYMAtbecKmcZe9RO2/3JiwPTCA0qOoArc4ZmNUkQLeiFVyh1SgntnSY?= =?us-ascii?Q?XlLHaF5zFKTH2PPSqrXTNw9fyn+/BL/Yw4VW5Wqh8elBcm/eUVtS3LVETOOM?= =?us-ascii?Q?KTU8W3aSkP6DXH0mMXjeS48pEzoFG906tmC3lMck6KARIL9e4Mus18JSsQek?= =?us-ascii?Q?pctT15g4rmoLcmhosrnDjhqON2aTTs/DnwyE0sgUnNYKYTjlRdX2X8W6+hlj?= =?us-ascii?Q?TM1hDGTXckAcEbqz9TGNqKp/7W9Pc0csS+CB9mqVx6r3LLvGrQ1Dj/GCY+UB?= =?us-ascii?Q?NAl7DPXlnpRCscqE9akC1wHM6MEJYFCY5z4nnjZBMMP46tW+hbqreLkzMDgM?= =?us-ascii?Q?Fz2+GrnQNUTWMLySfKM7NJjJLP1AVBZa8j94OSuIwTia9TTX1BVDuj7Omd9T?= =?us-ascii?Q?jWlXhWZu3LrCESxYiDGRp16HdeHp0?= X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 6:bhFiTUANLKiW+7UHycmRkccZbWYbG5NdRgPdHsWZdy4hw1us065XkWpp9MNLgvq12dZZIPwLe5P9rbmXtdnQz+wGDSFTeOp8KMXO4mh+x2GBdmBb8u27oDjHmf7A/vpB3y8Adb0mw4r8FrXplfmm8pyISyXeyh3i7Xip6cSqtDAyVubea6Z0ouOrliQs1oi0HmHm8Vukb8zrGGvzYFyMhMX/MBxLtjAJEFMi36nUnqBMLAJxwrh9u//LTvHDNy0aPdZyBRtQnJr3LjDzTBVQVghlVjodh9gosL1+9VbqYNZjud/bvbFtr4d/dt1BDfUHr46V+E/EE3tSOpUg3Imwuuoi5PTO6nl0GpO5rvn9pq/NwM2nmkP0nPiv+sJ9SP9D1/V7cbKghFrqwJN5J1xXtJ4o9lA9TCrSXbqdkRylO0mhB7IexZ2L0Uyxgvu9+BMsHe8q4ntVr9mLu52bEEYTmSP82JfS3+f+Bob7PC55wpcfFGCp/vh8LFSUDFYOOnPeg7+KrpAmLuvdMdfOPwgopnPlx4OPDOVcXPnsieeablE=; 5:4lUrafkngztJB6c/nDFyUUvZNy4pQ3NnWwO5R3yjBhtw3W2UI+Few6ujK67EiqMIA2aJsBf7qKV3JXxezhkVKSTgjGxgGWVbGoFecCccx5ebAqs2wjUfZaajy8nKjZM+yHkK7mswJVwYzlZD68C0xA==; 24:Ppn0jhJIONngJm0MRSPOwxSM1EUkj0HAgHUOW6MF1kTMVryBdG6L6HpDqWjUqEPeulecGvfPQDK3ERRoAXyyxssv9RZzXQChdO1JKCETn14= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 7:hX1pyNBv8gyFPz0x4g5KOJ18tB3GZs+KiK7syKPtRvwmAIgM9wOmQBK1BCPY395T3WExrRRLlVx/JKmjxMYauP95iHnJllZBuCQ4MbjT/SVGohcQw9Ene4DiHIwUYAwyRqlUDm6hGeTNWWcGc+wUGo6TY9117rClxUP+Qc9RgGH2FEMJmiIKn2e2JMvUmCfQTiHyR8Qk8b9/pGNF41m6bhj+dxr22okoTDXgggpVWITC5lcAD/rSdrdLUYaiEhXExwIDbs3wEDQU20QtV6rOVLpXvz8bjADkbHgdDL7jKFWLYjs1wdD143kyzYgU0G0WD3I3KNfHEBXSZl6GuL4YlA==; 20:pfYnhF+v41vUGG9Id8an0IA/PGAoe8fdxKS/eVFfiSSg1BL3YfvjfTI+gv1ejShGn7mDW/rsEeZWh6Ee9verL82Bca/WpgRjvejIqYWkhlPfT0CFEqjDzIaiiPJrpBCB2+xqs3tk7ZfjjK+KgY2jIZ5xfdTUaWihYrww1e8W9bM= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 00:58:19.6123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR0601MB1876 Cc: Linux-Renesas , Linux-ALSA , Simon Subject: [alsa-devel] [PATCH 4/4] ASoC: audio-graph-scu-card: tidyup return method from probe() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto Current return method from probe() is very confusable. This patch tidyup it to normal return method Reported-by: Dan Carpenter Signed-off-by: Kuninori Morimoto --- sound/soc/generic/audio-graph-scu-card.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/generic/audio-graph-scu-card.c b/sound/soc/generic/audio-graph-scu-card.c index 8465ce6..05934b2 100644 --- a/sound/soc/generic/audio-graph-scu-card.c +++ b/sound/soc/generic/audio-graph-scu-card.c @@ -350,8 +350,10 @@ static int asoc_graph_card_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, priv); ret = devm_snd_soc_register_card(dev, card); - if (ret >= 0) - return ret; + if (ret < 0) + goto err; + + return 0; err: asoc_simple_card_clean_reference(card);