From patchwork Thu Nov 9 02:11:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 10049999 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2113C6032D for ; Thu, 9 Nov 2017 02:22:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0ABA92A8EE for ; Thu, 9 Nov 2017 02:22:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F2BFA2A8F8; Thu, 9 Nov 2017 02:22:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3CA912A8F8 for ; Thu, 9 Nov 2017 02:22:35 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id A840A2676BC; Thu, 9 Nov 2017 03:17:02 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 70905266F1E; Thu, 9 Nov 2017 03:14:13 +0100 (CET) Received: from relmlie1.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa0.perex.cz (Postfix) with ESMTP id 92ED9266F1E for ; Thu, 9 Nov 2017 03:12:00 +0100 (CET) Received: from unknown (HELO relmlir3.idc.renesas.com) ([10.200.68.153]) by relmlie1.idc.renesas.com with ESMTP; 09 Nov 2017 11:11:57 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id A3A1A6690C; Thu, 9 Nov 2017 11:11:57 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.44,367,1505746800"; d="scan'208";a="262925102" Received: from mail-hk2apc01lp0212.outbound.protection.outlook.com (HELO APC01-HK2-obe.outbound.protection.outlook.com) ([65.55.88.212]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 09 Nov 2017 11:11:57 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VKRUZCP9XiTxKeh8SUUiGQKx6xTWsPMbOZDprGYo83o=; b=bEqu9TmMr28kc3PK45VzZanWANzNSlpXMnERAxTfPxEF7wX+ZFWDicUkfMibQVRLo5tqLmvOSEph8VosOs3oUIRs9pGLIHb95HrsyMuSkh57vVgRztaF9Te4R6RjQE7y/JpG43iuhxCOc7L8Aa3nQ9YV6zkpcMOMAy4TTcZB4Zg= Received: from morimoto-PC.renesas.com (211.11.155.138) by HK2PR0601MB1875.apcprd06.prod.outlook.com (2603:1096:202:a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Thu, 9 Nov 2017 02:11:54 +0000 Message-ID: <87po8sp5sr.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown , Takashi Iwai In-Reply-To: <87r2t8p5tz.wl%kuninori.morimoto.gx@renesas.com> References: <87r2t8p5tz.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Thu, 9 Nov 2017 02:11:54 +0000 X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: SG2PR0601CA0019.apcprd06.prod.outlook.com (2603:1096:3::29) To HK2PR0601MB1875.apcprd06.prod.outlook.com (2603:1096:202:a::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 70b7bf19-f8cd-4759-2fe0-08d527173fe2 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603249); SRVR:HK2PR0601MB1875; X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1875; 3:JOxvsvNEl5uD/+tgKNJJNPGsYJBZm1aN5F/B6uQEutnZDb7Wx1Fe2TumVNdqQHSbMsrsplMbqJAFM9leGCGuGwCMuallyURrFFvGMuMkdqcKD51NkqpkPdSNLBDPjJCBWSlVIGdvkJJ3x6mhhsDZBT4f5llw3FAcZnF1Ib/mp8c9kuy3De5DfRaLQuHohV7KKxSZ4ItoTUJVMC7zBes3Mo4i1uez0F9J8DY+xNWHzypJlGzZXjuYKBPaXkmWWO3b; 25:A2lhDJb+fNhmvG5Dhv+bTMzHCYK8AZuHx52K7TAh2NlHgDYtU+uZGM7q+m7gnbCXE1+5lxzeonNg20UDTxmuvKShbZgiP4rp3B4uxyJOlpCgUt9KuUG2uPNObO0lwtspkEhUELEo2k4e3n3tt4aHkLie5ECEHSMLQgh++iQu3Az8f28CRcgpRQ6X9W3OiYNbhL7xNued3xy0yGCRoMK8BbDKt1xcQ4iw17pQGRvusmF21Smdn8BC7250OpA/s8lT15XI/b12/dU7IhdzTbhtHqeMDqwu0UCWgi+TSzwFhEa/sz5aGtPL8nwcH7fhYVwZ7oj+lJWQqI6gAdiAEBKvZQ==; 31:2LqZls5b08pTVu0uZmWY/j9ga3Gj8UwOnBwp8fCtT062WugEAqgQiwKYlIICB3Lp9qwY/YE+gFP5UmTQLSkjRqe8TnpEqOqcPPVFL5gX76cP+FeyTxWtpqKLTJS+MG61+c3VZ8aq/izpI7VMJQosQsggZxBc4OzRSZ80J3Imv5qp8mYwYDlA5B/NNXK18GB1GYEAVHLXr2NRP5Fm6IBxbc+5FCV3wukSiCvNx0nSH2Q= X-MS-TrafficTypeDiagnostic: HK2PR0601MB1875: X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1875; 20:4jEIWo2F59cNg3sz1kIZo+Q9thZl8wOarBibWj4eTlAoGyy5oNL7FL9QpjgFSEsWWzbdOjraQWtYtdnchHU0Z/AXBDsqU7HLYuW+qUhpTWchIEaidfMnqPwQusOa++0hgbRLKhXzBTE/qSyhJu8bmOdvQwhlCPHMi3WaOzEOaXYMFWqDy8j820cWYf0bANYtqSpxOxFEtEfcjj66qNNE72Ztd6s6g/o5M92dIC5Z/24OLdWM4EGpO2Y6XT/qwVAmEcCRio8hCnJ+/AmLW9/y2BkbLaE2MT4OVzOIUaj5wqe/keEgZhvHbtpO3MipcmBfXK/dZ417VuGOKuw6kyeRXkMxSLZfC8j84W0VZY51CG9b7sI+jUCxynVbbQqC1UuCGb2VNA7LFe6EqCtuPl6HJnRTdOkeBXDFtX48/NJn0Cyy680gLDCQhRBYt+RZec6OhCR+lh2/e1aHHcBMCQfUfjqDinn+Px5+egA3DHYk8tItcIMplTa5TdjJGlgNmRU0; 4:OyBogweXUGUnJXn1UTfgZnTMuqkkrsHRaGq7B9ftUCI7fnc0YRWZvsxFWNtMsSKvrgJifsOdfJdXm+mNOyDn15HPgEdjOuZ1U8x3KkOhoUyDKwGTzarxI1gaamSW+EO7LNUPJTIdbutYBGQqBP6os4TLbCg3z3Lb+3ugexeOuqxT+5Nk/F5ANkY8qx++w7RnPPMTteRQIUBgBDr8XzQMV26AjiZDNicFbICBeoaSAHjLCUonjSPdwSYJWDRdqo2rqEE3VE70Y3NsPa5D8E+bmg== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231021)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HK2PR0601MB1875; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HK2PR0601MB1875; X-Forefront-PRVS: 0486A0CB86 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(346002)(39860400002)(376002)(199003)(189002)(66066001)(110136005)(58126008)(36756003)(54906003)(50986999)(83506002)(54356999)(16586007)(305945005)(76176999)(7736002)(16526018)(5660300001)(2906002)(23726003)(2950100002)(101416001)(33646002)(6116002)(3846002)(69596002)(81166006)(50466002)(25786009)(8676002)(81156014)(53416004)(478600001)(316002)(68736007)(105586002)(8936002)(53936002)(106356001)(86362001)(4326008)(6486002)(47776003)(97736004)(189998001)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:HK2PR0601MB1875; H:morimoto-PC.renesas.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HK2PR0601MB1875; 23:j/6PcSNWdq1s21zYZ8jgpAxaj22RFhANDGj4NYB?= =?us-ascii?Q?bTUSiDzAv1AteWfL/Lun3w1++Mqj5uq3bqbuvcXDN6T4HvVDok0oxoiq5g1Y?= =?us-ascii?Q?OqfkccX+7rC/JhWFnquHUlXU40ES0Qg/CObUzaPIrzWyhjHI5KS7KPz7/Xce?= =?us-ascii?Q?otYJPlTgYPu3dvG5oGZ+emsIKBI1yCg6HOWGvr6cd2H852A0yNs6wnBj4/UE?= =?us-ascii?Q?DFspCAM6Ta4yiatWtiEAmjrwJilw5A+vQU52wGfZOAHanGsrQVxljzEu6uW1?= =?us-ascii?Q?RTDS1RrmVIB92SPcujRM0M0nEBHJMU7H5lrHgIdRkn28eA1HUOkIS1utSe1k?= =?us-ascii?Q?rL5QMOBbLwg83LM9II6ezRPH+u0crmlygsMefEMYtTwIXAQ4w7XT/onUSrPR?= =?us-ascii?Q?Jlk6VOffez05KhlkSB6psakCShHELyjWLtQP+bMk4/LSRIe8K8JKoWXe3jdS?= =?us-ascii?Q?pxoGpGbTuIza4DMVKE1i/DU+6vPbTuVyJtu2+4jvxQGtxZDqL29qlDGHZhoW?= =?us-ascii?Q?PclfssfoZHCq1JK6CxRJ16yKrHefBgO4XTpdgTgVluuM1PJuGkFkEAOQVwrV?= =?us-ascii?Q?q9c3r4l+ZKYEG3IArluS0HYAwPSnx0gwDNmiYDoBHSfGJ0uog8AsCJu0GTZN?= =?us-ascii?Q?KetZP1TGnKNl355Kuu6rgpKQ5G7gJl1xxBAEC5Mjt8E73iBY50xilEd0CS4F?= =?us-ascii?Q?DJMBodRweHPB+8rkszqp4Hcgi0VqPMqwocXFaXhyuzeuHxE1d2dTodigyodx?= =?us-ascii?Q?Iy/sFsy9qkWCP+Q+oPM6vc9HS7ukE73dk+PZhrBaIcBDlCsYmk9Lu0+fMtUz?= =?us-ascii?Q?7pjxj2W8KBVmlSLFreLmwImDQggKYtIzCXi6q0aeNnmBwZT04uw8lkP2ICxi?= =?us-ascii?Q?9RXHcZIBh+i/EoWTaKbNvwtimii/OtPpU3kVRDkKwoGv0IY8ANAsF5EjQLNZ?= =?us-ascii?Q?hZaA3dvQVPrPov+UriVHK6FL3h/m9heGSzOppXisgrx7laGgYS8upyc8t3Ou?= =?us-ascii?Q?MpukEZvfVKKasfD6iyV1p4u36r3MfqWLE5ZsPFZcN0LP0S/a/+1DLDokWml6?= =?us-ascii?Q?PuxaPnVNJ2gnO1JiL4n9197r10nY9H9/+abujmamoanVHOR2Ypyq+NkKr8BE?= =?us-ascii?Q?rU80074O4YVXIwH2CzpXPut6tNTFGngv8?= X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1875; 6:YqvxQj4frq5BanjWdLlT8/B++HzL7GTCg6Vwt/0oqQxNbjUY9+wt5OP4brYMLaqty6YSuwIcrbvDdLVSQkdqNU5iXCjbwbBDU7Dkh328XRND5k5/PW1iw97Qrpw9AQsPBU1/hAi8/CgNEGhmb6FZ8h5At3H3A9CtUTRILNTZz47OSjAWCwBuicLM1w46CO/a0OTkXLdcrB72kCNSvohauc7To0RB1tla2hzSYtzbZot3O532yKOBb00Vk9bcoJq69ZI1gJ3VB2GbH4wC5NSjDn6XHRboOYXDvx8n7QluNQv6zoC9yFtwqkyNAtGX6RV5FMmnPPFTJnlYLAZZcFS+6bN2WNMUAIfhuoqwubw7PrQ=; 5:mNQ70pedfr+dxopeCmTZ1Pb/aXYirGK3MjohvY4HCE54NRBj0794Pdxbxj5G9f347PBc2snaX78eUXjSnhy5r3yUxB4l+Gf49ltZMps3DBjg5bXo18CLO6MsBoUkn0dIvy+26VlLhUCgzyAhDG3TQE+COgWOibjOgIfbmUQ1qA8=; 24:7VBhJJLk3tJNjFrVifPC+4cRNlo4gxNsVChi0ypR8Sqh8A8Fy6BwPbyyfbuCFDVozeIbAAOVlNXbraddsX8WXIXaLtghRYiUVvTmsvx2eXY=; 7:IA9Ej+XafKLzrT0K2HdTtGJV/r2P5C/YSW9pEW6OoAQfJwBq0Ko6GjbN/X/8WwHmUL3GA4wt4WZ/g/PK2bSZuPe0y0I04dL2tXof9gDc8lJ4xRgj9+NzW0bzGodRl2vtHW4LdiUxTIs/wTq+5SVrlX/0ofm04sKjn2J3E0teRvXMcPxNZ5i9KsOzGVhUe2VVfbP1J/xhyu0g/8uiycnFCtfV4W0EOgUm+bzF41aX7Mse82uL38jauHKiCI51VZG5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1875; 20:7wA6UaRH96OR5Y8BuB9fjtMNTUZjMIyekziU8Vv0CJuJ6t3pepLq+59G+EbMXz7iv6j/EuquSNp53610Ty/Xpwyqr2+Q6+hnDha2uxgGjqj1XdliPZqzur2jXY/GuvjmnZE/6YS1InHGTsEoBD0/CmZKKQZxsWDp5tIL0r9dqkw= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2017 02:11:54.4500 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 70b7bf19-f8cd-4759-2fe0-08d527173fe2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR0601MB1875 Cc: Linux-ALSA , Simon Subject: [alsa-devel] [PATCH 1/6] ALSA: pcm: check parameter on snd_pcm_running() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto snd_pcm_running() is using "substream" and "substream->runtime" pointer. Let's check it before use it. Signed-off-by: Kuninori Morimoto --- include/sound/pcm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/sound/pcm.h b/include/sound/pcm.h index 24febf9..a8e49f5 100644 --- a/include/sound/pcm.h +++ b/include/sound/pcm.h @@ -664,6 +664,9 @@ void snd_pcm_stream_unlock_irqrestore(struct snd_pcm_substream *substream, */ static inline int snd_pcm_running(struct snd_pcm_substream *substream) { + if (!substream || !substream->runtime) + return 0; + return (substream->runtime->status->state == SNDRV_PCM_STATE_RUNNING || (substream->runtime->status->state == SNDRV_PCM_STATE_DRAINING && substream->stream == SNDRV_PCM_STREAM_PLAYBACK));