From patchwork Fri May 19 00:57:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 9735435 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C8194601A1 for ; Fri, 19 May 2017 00:58:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B1AFB288E5 for ; Fri, 19 May 2017 00:58:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A51ED288E6; Fri, 19 May 2017 00:58:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E0748288A8 for ; Fri, 19 May 2017 00:58:05 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 90E49267568; Fri, 19 May 2017 02:57:55 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9D44F26757C; Fri, 19 May 2017 02:57:54 +0200 (CEST) Received: from relmlie3.idc.renesas.com (relmlor4.renesas.com [210.160.252.174]) by alsa0.perex.cz (Postfix) with ESMTP id BC2AB266A76 for ; Fri, 19 May 2017 02:57:48 +0200 (CEST) Received: from unknown (HELO relmlir3.idc.renesas.com) ([10.200.68.153]) by relmlie3.idc.renesas.com with ESMTP; 19 May 2017 09:57:47 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id D9E1049D84; Fri, 19 May 2017 09:57:46 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.38,361,1491231600"; d="scan'208";a="243439779" Received: from mail-sg2apc01lp0247.outbound.protection.outlook.com (HELO APC01-SG2-obe.outbound.protection.outlook.com) ([65.55.88.247]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 19 May 2017 09:57:45 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2WKfbBIZtpnyXZLNIZpsxC07SlSqFMalnVa1IkZ9LEQ=; b=lOV2ZmudIgRpSEITZ3WU/Prqc/R8aM416AeOfGZZWW0U9wtjTXCTJEPZJAsoCFFG/lhSsweTHlAmivPqLHoFGWyzBPg0UEd+rDhASjRnL6Zt3UyDgzedOqezIs+cMbQRMnmCUcHHO2M5zp8qn6ll0nXN1GfxcS8QjF4C18EScCU= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by HK2PR0601MB1876.apcprd06.prod.outlook.com (10.170.149.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Fri, 19 May 2017 00:57:44 +0000 Message-ID: <87pof53bx6.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown , Dan Carpenter In-Reply-To: <87shk13c1z.wl%kuninori.morimoto.gx@renesas.com> References: <87shk13c1z.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Fri, 19 May 2017 00:57:44 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: PS1PR04CA0022.apcprd04.prod.outlook.com (10.169.60.32) To HK2PR0601MB1876.apcprd06.prod.outlook.com (10.170.149.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3fa7c65-3bf5-4a4f-67ac-08d49e520f8f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:HK2PR0601MB1876; X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 3:+k35X4VaT+wnzzVJXXDvG7Y4eRYJgFuynIbb1iHaYFLrQoQOcTeQzDAdK6OB7miJFMcSeznZVH9LIkRiMSuJiUyq6GLUCWPFJ6hfM5HtoQVPWPZoIMz38xWouxuRVqe8wUUvE84MaKaxMfrlxAP61P4bFlDHzV23KorXZHnFYeV8UfczIenlP0cTOXT9aikbRTDLoeCICiD0AW+HtIGpKa+xrnU2gwEaS64atWDNvktLs+HKnF50JsGJz91IXi5TkxA2u/F0MA0Fmbk71YNHimvUp8s59UpwMz8dooov1lEf+LmJyX6fe2W04/6buNagR4Rtn22tD3mC3AKVJVue4tAM8JnvHtUr0/PkDoJRvbs=; 25:s9dNTLhsuzXDd5VRKkWTRj8Bx9hP1qnxiCGnPZ5xHuwhxwygEK1sXnq/5o2V9CD7TNN8h+QUnDMDD0L75WO/j7KCW1uGOUB/U/A5QASgXfe6gztTWcw9DqDYdOAojCXEGUkYMzNAXmga63LBGokyvsB1hYGtQ+E2pKV94kaNYNSxWUNOz6PFAo/bTOKpKO7fnSa5RAq5mDrBE6SPPf6SjUWJK7Jx1DtKLmCygNcioh1Z7xsuakdZvuQy7Li52dhFLgKqy0Rg/RElMGRh+W19UDHL/qHFSXBL2XdPtcr5fhow5Yw1Hn0svT6FinRhMszxDGJPSgWFPOQAJ8/ilB25/lz1tQtYfiW45zFLATt4FxVH+tViCtVVevbHIOI+RCXTQ2Y4YQvegW63WjVxlaz2NhjyMLCp6skpup2uW2vCIvrxrTiV8pXHC0zhFnOfDtBfzJwt3puPSI1VdWYUui9ezlD/tpe7e1+7CucC0ZrEkT4= X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 31:K+si2XkdqNMwecTWCCVdA3NLk+fGm643vOfU00aFn9OvoFmvHnH26dMjPpIfLD6c0+uzXCxpHKS/bApTddkV+5itvJsHImo2Yk3UUgyejecQOkWGHlLTjVu8ee1Kn/TTi43p5NKntkZr0aoP1wU+NwFlfR18Yhp9oyEfezQkZo2xrb6T2wuaoU1+LhKmK2t1bXEN8gYTsPaqXoQ5uQAlmfV5vIDA/pqr2NwpDIksL4krdyBiTvCxWpdlHPG3hqCWJZDQPgRIupOnVMaY6BGnow==; 20:DEjhiUyYx1QtredXiyaPDDnHDeMTzX68SrAQSN+a23BfKU1oqFQCW6AXVmmD3XLhuS4gtfOeNahnRnUpbWckTg4PBH1qNAMGMDPzlPoe8O1wTbfeE9RXN0oooNb/YtRVqPZUTRgTswaQ+cx5ZsBwX+2lS7sjUXueI82VmvRzCu8e8oSXGZLkrbJzWn07u4TfmcXU9WCDGcXEw62OKAnsi99V3uzJXYjzqM/g4B8zl46QJmvNU3HKFtpRgWiwTz8Z+wFxMXcJ2tuvx8wQqEQMlkXyTm3nF0YTAygsKrbIaQt6e57ES+FMNdyrMvMuJbDDk6pwo+h5Pz7kKidhCxHHehl5eXrDjREdnThu8hR96MYYZLQeNGjCwka2QlPQanKBOQZuajZsRQmDk7c+GG2o03//ehueQiz4IPnM94a7XNOk2o4PpoI9KGNIjDgD+5piu0WzijLE92PjDopp6yFwnqcV15UH2+ADqlgvO//jrOjgG2OZQW4aEAk5AQDWZU0Z X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(6072148); SRVR:HK2PR0601MB1876; BCL:0; PCL:0; RULEID:; SRVR:HK2PR0601MB1876; X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 4:y2DaaMqlAEJEAScvbm+3EMePw9b3FpZOzkxLs0nfI90JReWmHfJSJFsZ+DrAeqQUBVbN7HH3giKlz0VyE/G9D6CEQIoZDqcCo+qiKZVErAa9hDIt0OO4q1Tw6iXpBKobnlT8oRoF2keXQDOzsbsIK0tDHH/Q2HbHr+9X0gpbPYT90vxG5t/+ITATOAfeOQaqSlTV8SpMj539Ocf/UIwIrfj56ZAWxa68tOJgf2NhElZXWA90iTK0pC9OQRbFj/KfrQYT7tS7tD6rL4+8e8iWyz8RtRW6gMHAXSLQU2Hi/9geREMpNloN3n6n/D4458EFn1iW8N1aErsOL4Au9smiotLxz0Kvbkb8VOLtsjrbPyEnkxtJmn4PHIKSC4tAWvjGvOS7kFX/hK6UhQYG6CXDhBFZtELaNkCT+UAITvJLNa0HrRQ7Y9Bzn6YLEITWpkJBg5cYdSvH81xmfgmxurKGJQtLi5CJK2xKeXIalO6mjYckMQvcpWohxSmzQTzul/4RPdBCAtwvT8hVvH4Btk0sM7gu7P0H8Gg2j60sefWr3LEhMU2/C2ym+Q6gzAbatXA/xzOV//+SJVBltCQElMB3elvYFYWWKMiR4SHAvxZCEJTzphbK0Fmn651X3XV1UiuUM9EX7bbyoy8K8fp8J5iwVGobS2mcEpyhpkoXVW9Jj5w5Pi8Hh36KnTCj5MzT7sqvXSoeTHviHyDQ3vS0VTDnyEpOWQ58IGxCYN/1hwo7ICBOg+IuOeVFI/KA5eyZDj+itnkpqzbkMiqXGDkWSag703KDVoVpFDO2R1nErtcx40NkKpjOOQSF6TEN8KoPhx53zuS4khObea5XyAJDFCBfSptC6bcK6+5/8j5SO2IGOjI= X-Forefront-PRVS: 031257FE13 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39840400002)(39450400003)(39860400002)(39400400002)(39850400002)(39410400002)(33646002)(4001350100001)(230783001)(6486002)(50466002)(2950100002)(8676002)(81166006)(36756003)(86362001)(189998001)(2906002)(53936002)(66066001)(47776003)(4326008)(83506001)(5660300001)(53416004)(50986999)(305945005)(25786009)(46406003)(7736002)(54356999)(42186005)(3846002)(23726003)(478600001)(38730400002)(6116002)(54906002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:HK2PR0601MB1876; H:morimoto-PC.renesas.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HK2PR0601MB1876; 23:HAbgDePpGuIzDnG6RGvdL4RK7QsG0ylVqUexzOd?= =?us-ascii?Q?wJbijVulyi1vMmbH7h39NcUTkul6X8dHcVQaZnYb8BGbJb2VZKJ7QCzDDoQR?= =?us-ascii?Q?3v0BVWwZLLRjxdOEPV0UwdjVKbM1X8Qo0sfRsJpaV1zGh34UAuApGQwlJCtv?= =?us-ascii?Q?GdKgFTndxbIHBwdd5lVBznhLfSehi7CCMF2qTCL4m44ZbdWTdJRVw08m/G+J?= =?us-ascii?Q?l8VIxMlnOGsFYyq6vmeVHigkXtu5fCXmQzT9TCxqipv7im8qJiZYZJpVaXuO?= =?us-ascii?Q?Cxaa32kWIw4T0jkOOj6XmNyfkckguM0rmX6CbfG/5Co7hoFzjrDFtZGEbcvk?= =?us-ascii?Q?DNXqjnJSFxbf21uxJdpKmUB/mCYVhwKSFZqdDqUaz+rbKMG/mJrlaw2/ggGb?= =?us-ascii?Q?/7/Qpe4KrKKP8V2XjB0/sQFwf3NSerYmgJubBsl6FMIyYMehJroJUsFWCsoY?= =?us-ascii?Q?U/EMn0pfq6WRkVeZj/qdxFjOkjNFVyauYK+X8ERWxvPKGMtPOEyYu7N9X1uX?= =?us-ascii?Q?gYGkwHr13zedNegcui4OoUuTN9slLfasA0vtZ3jTURGD0Z9ZDEbtd/6uVp/i?= =?us-ascii?Q?FxMmQHFSYuw+h+az4L0yNpco+ItYSeBAl1/w77oBkGhftUuO7nKrpS0rMXK2?= =?us-ascii?Q?ng0yByk5MP+Wl6gOyS8ORmC4cizKut6kxZWP/VCnM9bs/1j1deVL579jNNWn?= =?us-ascii?Q?qjzCs6xagomHYh/ucaJhVPOhW05eAJ5UbsOqb5xbtYa5zUhAIHiGODx5GyTW?= =?us-ascii?Q?4ldZ5gKbzhecuEk4gkPoNyFUqW+l+a/Dddzx+FoUXUs9/hfJ3547tIO/6HDH?= =?us-ascii?Q?guU/jcrF3Qm8D3UtlX/5nm7YhCrcrrpdWx0BKjyPOsSCwdleGpxWDiQqDOPU?= =?us-ascii?Q?lQH8kBg7eMXv3C3EV35Z7Hsn1qgIWUE3Y3aL/Etr9VKq6TXnk1DC2qhx/FIS?= =?us-ascii?Q?a2s5cQH6S52emTb0qRyQnCgYlWD6a4gPHc4fG9y8XFw29nvT29zWQmhBVu3E?= =?us-ascii?Q?7FwFlt9wzcHvqn+Jx7SP3Avn+qP04MI+kqOZZdoWR8z43qqSKVUISMqM9UWt?= =?us-ascii?Q?hN0JVqfGG3D4Zlkj3pwLeB6bz4d7g?= X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 6:6Ox9HH3z2iiUqKlODEBRRFx98tYdouUf5Geag5v5rmJxlFZb1Qs3WPJj0t1MFrJ2Dft8yzI75Lbmp6kqHfA1UKDiHUxBB+2wnUWCfh5USqndk6WWnFCOu3aMRaFTgnkO2ovrnNVaP0tymar8QIN4B9uv4QXNGwU+LQ8mr/vaxToht19qBN0LnFr7CVn/kcuZ4Mmcj8UPCyRAtObn93MjWq4EFqJga8/cWk17782RB5K1t2/h7Wp0cEStrXKgYxiSfT7bi3Klsnfey120JPVs13mco7jGdQ2kwiR7Hd+ieGQL2ST6f19jASbcQUfumPSBiy8KtbjA1lWUgIgU7ZauUey79H8p0qBtT9Tu8/ZGJaXgjfE+67V1CadR8Qui/M95YS/IObByhVptEhcFqvAldQM7Q2gB9hKbJzNuB7DYJsqzkseRELFhv53JerLZgFOUSZQE6nU4DG0tI9Ptn7S9Kn3sfRPhJ99OOuuBE0VGPKEEwnIHk9x6bNtYRH0aXoX5sXuxPxngWhj+G4ZQpuZ3Yu68UwGceLgch9nyo5fZEaE=; 5:9ngND9hLxforv4ikW4MQ48W8eMwESiAMdnTO5Kb7H5nfI+6kNcdXVol+tyLP1P8FJBcFHwH9x6myoKHUjjb2Rxu7nid79EeKnFcXQS80mGCJUwwDQ6fnoO3atI48HZmAvy290/vKKTi4ELYbvpkI4w==; 24:d8h2Jh9c4Aq2H5RRGYEOrV9PSfbKQgVVC/tmoM8puggqur2Afy8/UR2xb12x7dFKB97QY5BiDRyxCPSH3eulGXhjea3JYgdbT4NBckBSOTA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 7:HXHdQV8awZUW9WqXtcXnv+jLbgqSEKZ7EyvcOynzFh17pOk73wD1e53fhJ5clh4WIcfTZGa+m76oZs4PBHvPgWB9qstX1rGVofGp5UGWitvPsALv/LlwzVqCyotv1MwxKqF8HImZmGgV+ksUnBF3G9DoRyJK9EcntyspzfHVERFbVBb34lVe79mwFdiCm0+RzfyggB1IBVDfpvFc3YBqk0bVaaT0ydWgDOA1cufHZYVt0tvZ1eIz8XQWn12RTo1APSavvMDylZ/9KZCDBAD5cf45UE1M1DOOSEHGXtFDmnZ8FpN2hVFAvL+8neuuXH2vUVtzooS/UeuhueqTDVdDFw==; 20:cpM82m+vw7w3/jiwLShZ6dA0e5H5IO9vIkQvPu1KPOWgYJ/4ZloZD8ZQAxC9PzTuLcQ9YVWmj3aVPXH09cMsiXXZmafqnMyO6vQ4GmRz0mcn7O4VV1pXlaeTbJRmo+4owgApKE+5ijylJ/pKoJJv5fEgdYugIqhAlewcoTPbCLg= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 00:57:44.4469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR0601MB1876 Cc: Linux-Renesas , Linux-ALSA , Simon Subject: [alsa-devel] [PATCH 2/4] ASoC: simple-scu-card: tidyup return method from probe() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto Current return method from probe() is very confusable. This patch tidyup it to normal return method Reported-by: Dan Carpenter Signed-off-by: Kuninori Morimoto --- sound/soc/generic/simple-scu-card.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/generic/simple-scu-card.c b/sound/soc/generic/simple-scu-card.c index 1e8c42d..a75b385 100644 --- a/sound/soc/generic/simple-scu-card.c +++ b/sound/soc/generic/simple-scu-card.c @@ -269,8 +269,10 @@ static int asoc_simple_card_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, priv); ret = devm_snd_soc_register_card(dev, card); - if (ret >= 0) - return ret; + if (ret < 0) + goto err; + + return 0; err: asoc_simple_card_clean_reference(card);