| Message ID | 87r0uu8g8x.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0438499a7f098c35e83134fc04899fe2188e4ef2 |
| Headers | show |
| Series | ASoC: dt-bindings: renesas,rsnd.yaml: add R-Car Gen4 support | expand |
On 13/02/2023 03:13, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > SSI is supporting both "PIO mode" and "DMA mode", thus "dmas/dma-names" > are not mandatory property. Drop these from rcar_sound,ssi's required:. > This is prepare for Gen4 support. See more details on Link What did you change here? I still need to read 4 different discussions/links to have understanding why? > > Link: https://lore.kernel.org/all/87zg9vk0ex.wl-kuninori.morimoto.gx@renesas.com/#r What details are here? There is a patch with gen4 but I don't understand how does it answer anything here. > Link: https://lore.kernel.org/all/87r0v2uvm7.wl-kuninori.morimoto.gx@renesas.com/#r This is previous version, so it also does not bring more details. > Link: https://lore.kernel.org/all/87r0v1t02h.wl-kuninori.morimoto.gx@renesas.com/#r This as well... so you say "more details under X, where X says more details under Y, where Y links somewhere else"? > Link: https://lore.kernel.org/all/87y1p7bpma.wl-kuninori.morimoto.gx@renesas.com/#r > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > index c3bea5b0ec40..12ccf29338d9 100644 > --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > @@ -256,8 +256,6 @@ properties: > $ref: /schemas/types.yaml#/definitions/flag > required: > - interrupts > - - dmas > - - dma-names > additionalProperties: false > > # For DAI base Best regards, Krzysztof
Hi Morimoto-san, Thanks for your patch! On Mon, Feb 13, 2023 at 3:13 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > SSI is supporting both "PIO mode" and "DMA mode", thus "dmas/dma-names" > are not mandatory property. Drop these from rcar_sound,ssi's required:. BTW, do SSIU and DVC support PIO mode? > This is prepare for Gen4 support. See more details on Link "This is preparation" or "This prepares"? > Link: https://lore.kernel.org/all/87zg9vk0ex.wl-kuninori.morimoto.gx@renesas.com/#r > Link: https://lore.kernel.org/all/87r0v2uvm7.wl-kuninori.morimoto.gx@renesas.com/#r > Link: https://lore.kernel.org/all/87r0v1t02h.wl-kuninori.morimoto.gx@renesas.com/#r > Link: https://lore.kernel.org/all/87y1p7bpma.wl-kuninori.morimoto.gx@renesas.com/#r > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On 13/02/2023 09:56, Geert Uytterhoeven wrote: > Hi Morimoto-san, > > Thanks for your patch! > > On Mon, Feb 13, 2023 at 3:13 AM Kuninori Morimoto > <kuninori.morimoto.gx@renesas.com> wrote: >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> >> SSI is supporting both "PIO mode" and "DMA mode", thus "dmas/dma-names" >> are not mandatory property. Drop these from rcar_sound,ssi's required:. > > BTW, do SSIU and DVC support PIO mode? > >> This is prepare for Gen4 support. See more details on Link > > "This is preparation" or "This prepares"? Use imperative. https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 Best regards, Krzysztof
Hi Geert > > SSI is supporting both "PIO mode" and "DMA mode", thus "dmas/dma-names" > > are not mandatory property. Drop these from rcar_sound,ssi's required:. > > BTW, do SSIU and DVC support PIO mode? Only SSI has PIO mode, others need DMA Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml index c3bea5b0ec40..12ccf29338d9 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml @@ -256,8 +256,6 @@ properties: $ref: /schemas/types.yaml#/definitions/flag required: - interrupts - - dmas - - dma-names additionalProperties: false # For DAI base