From patchwork Fri May 19 00:57:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 9735429 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7F7DB601A1 for ; Fri, 19 May 2017 00:57:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 69258288A8 for ; Fri, 19 May 2017 00:57:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5D1E5288E5; Fri, 19 May 2017 00:57:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40B73288A8 for ; Fri, 19 May 2017 00:57:34 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id C3A9E26755E; Fri, 19 May 2017 02:57:30 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 286FF26755F; Fri, 19 May 2017 02:57:30 +0200 (CEST) Received: from relmlie3.idc.renesas.com (relmlor4.renesas.com [210.160.252.174]) by alsa0.perex.cz (Postfix) with ESMTP id 8BCC2266A76 for ; Fri, 19 May 2017 02:57:25 +0200 (CEST) Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie3.idc.renesas.com with ESMTP; 19 May 2017 09:57:24 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 059EB6899E; Fri, 19 May 2017 09:57:24 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.38,361,1491231600"; d="scan'208";a="244366159" Received: from mail-hk2apc01lp0212.outbound.protection.outlook.com (HELO APC01-HK2-obe.outbound.protection.outlook.com) ([65.55.88.212]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 19 May 2017 09:57:23 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WyxXKqZYzT/0tghGL5VlAod+TTrIYROS+ClBEul31MU=; b=KdHpFKCbtkwZFJtmSOQDorMMEgBcdtGG5JepBu73q65M/stNzmTH8X0FGnf7aNTlqlFRZbZprDVkRLPgfBEvUS9z4H5qFwAFrqyPuyTvcmWNHSW3zs5+VDIafSw98Bec2AafUuJBarkgm/UwAHMGGl1z2XSsuUnu2jkj+LNAe3g= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by SG2PR0601MB1885.apcprd06.prod.outlook.com (10.170.132.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Fri, 19 May 2017 00:57:21 +0000 Message-ID: <87r2zl3bxr.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown , Dan Carpenter In-Reply-To: <87shk13c1z.wl%kuninori.morimoto.gx@renesas.com> References: <87shk13c1z.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Fri, 19 May 2017 00:57:21 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: PS1PR04CA0010.apcprd04.prod.outlook.com (10.169.60.20) To SG2PR0601MB1885.apcprd06.prod.outlook.com (10.170.132.146) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PR0601MB1885: X-MS-Office365-Filtering-Correlation-Id: 6aa4cee1-5584-4abb-9c31-08d49e5201dc X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:SG2PR0601MB1885; X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1885; 3:R9Gm4jpjJgBE2T9yk+nTY1iGrK37CnQ1wqHlwiOKVRXpWgA1x30CSNEE1PLk8g4EdghJrW2OzuOcb8rpepQ4K7JfBb15YHOEf3Q/e0Z8e2iiVn10kMrCSbo9/rwRnl3puzP9brORECDngRATUs57jzZZFFD/rvHBv0ZKwGUBHqQCBm/78W//6inEkSvdp5aShJmoUtgmewxwGqZCjnOyVeOCqKpLrh0Za1tEZOQVHi+VyBUSDZ5ubiA80lxzqEeWjtY1R3l1mNePYlxUQrsQKOOroNBEGI7K+91Ascdw8SUUjI0GfPn/5l8IGLPPMiZWQTdUg5XYJqw5XOqFwRX8Re2cnRNlXNHgWzN3501mfLc=; 25:UJupRbCP8n54dlVlIHR2DvYiRjON28s8GI37nDDHN1XFQaa2VL3Bz2G/iwZFlK097B4rIbGA6VO1ShPbGXih/ujTaagpSh1CImm2yGXkFYyql+ZNAuE/Nbm4GXI2aZ2NMllXBQtgYTd2km5t8edqYKyw1J15GgOMRFam0sm+waSZ6AQPV5WkOBE+j0IZCQ51lwNhjUU+fZbt6JDf2FywKXSMQDA0lpbyhpa+82gQPpwL0TWzat5XPUhuxQiYZmQ4trSRZgshrw3KUnISQRIiADMSdKXK78BvytzO5olf6ULHbYsJNxUTmmV5g/MosmOEAyH5gDKr5mBCGxIaT+8GGE9IhK3IP2rLkIPhrSvieVKx5fJd9riZ9gSonRB3gpg0MceKRi4QzLR1vKMTq0b3kzvRp8yN+BLNS9lwhLV8m8Vj0Urkuez3qY0LqduBBZGh8oapFEdK1nRLrrl1/3ALFmg9LLdysAqKKnSJ0deDrC0= X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1885; 31:tpKXKrIKawem+uuu66EcoC8kp3pGF0D335bDZc/jSv4GLPBHZSKVER7Q1whnJmsJFLfyC82qTRpuvJXoHg+PA5xOUQ493SXocZh5ePnBe4FxbBx4Gc8QNLCjrQ5xjMZP4s1mKfUkg/cBL8lICVeYLWuIgWt0+OsxuS6DDBaofZCpIN2IwnFBDOo/lPpKzOKfX4dHraf8f2O8o4tyBgREocYnfui0uMYneFWcklUq/F4y9u+ZEiAHAPKA80cYfc0x2ol0PA8hWj/L9dzA9ZB4Vw==; 20:E2NlYS22dTmRDhicCyDYvf3uCRhgpNJEUfruG/yJNQshKQ276vzB7OeBF1t4OSrmEMcE9YsaiuZ6TuvNlvv2IHt3RwSdPoX5fP6BzQpxCgAJkaAZGxiojaaf1gr94L0tFcu4goHKQtk7B6jIlRhPnoyiRKYI6tZcqVk5MMgeIsXWfrlJfASxqQS2yuqybC0pbwCesBrwbXI2oQQugsrBmOk+uQeB77b2Z5z3w5nmDFraZYdvgICPMVeh3Ymp1m01H4BjfS3txQBcaRDO/gmaUFSK/ujC0ZL/xb+4FiBvQiPm8qt+k6fk93b2vxHfZWc+q9fpdGMkFVPc7VWnN5OIebFlTDp8qIUWr3rrsL/SnjuUonQJxFStgFpEP9yAQzoBx5N0Hg2NW4B0CjkrtuovDnchu6pSjcZWKG7+MEtlUNtK1nFzyCV4kGhE4a5NhrqB9HfQJ2T3LacVvfWIC/HLYWGuSBv8k3AwYzhMQWQmD4eLd4UYt6AEWuVAP02W2ZME X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148); SRVR:SG2PR0601MB1885; BCL:0; PCL:0; RULEID:; SRVR:SG2PR0601MB1885; X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1885; 4:XMjn8ZJ2aizpQ+QQeoY2Mh1CvApnSgrnZU7WvfUllYIgjd8x03ozZmH5Wy+WLB5xww500xXTjT6rdhxgs8MdRUyrdlzQA4b1WXhlXR8AFyW06EXXV/f0y6MCon8WTY4NKjLTHFv/BBpXeDCZdrAbYFKiSvxyu6nSVacI8ghTAhZKVC0g1w8GLWBIUoOHy7mSO5QW8PH0xlkoMrUc9+rtH+Eu/iGxvmWmGMSzG0G6DdkgS/pfiK9rj1k4Pqc/l8Z7rUudABy8MHtKqkDmg9mqc3DQ2Ci/NDyhc97PIrT9h2/IRaiRb21UNhSmmZJ6aSEQ3wY59Y2LhhrJbjTn7gLhjNHOgD7cnYSW0UTgBEmd3Lea+zExJpDwOVvCtHrWTRcOVf2Td98pOy5Csit2w0IYlSw/bICSwiu7SHrG8DMxBhlfGU1uoKF5weuip5HQTizNQUE2uToFWzh3ijkAQnAKi+aSugR/umCNZaqw2XpLnWyEPvVf+KCvJ+OsFWjyHHj1pC1hL+sOvmtWSWIQa57TEmjNFaKgcavasYMreJe+T574287Ynvjzy7uM5/06UfN2whTy45pxaYaKMrG7PyS1buaAJ2JtFCsPdALk2u2j1su3Di7Yr6tKJNZZSwagUKd2qg/VS+xtJUhad5h1Y320fRz7sWMEqZAhmH7KQP2aH8FVq7mKRghkQ/k6dtUaRYWVpf3LqIUJRkZ6WXfhc8Zkw2doMxeaxyZT0gj5WmUGwihvQOsOet/Ew5RIY1GazPEfvLPwE3n0I4q8qustDhuVxPS70UG5ICN2aT235YEPnLofi9BaoyZEtAGO2gWdrGKI/ylbxdHP0KWn22k4Ri+KThs0xNhmq8Y7uuVeGcc8oHk= X-Forefront-PRVS: 031257FE13 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39450400003)(39860400002)(39850400002)(39410400002)(39840400002)(39400400002)(5660300001)(54356999)(50986999)(4001350100001)(478600001)(66066001)(4326008)(189998001)(47776003)(33646002)(36756003)(2950100002)(42186005)(23726003)(53416004)(305945005)(25786009)(6486002)(53936002)(83506001)(2906002)(3846002)(6116002)(81166006)(86362001)(7736002)(50466002)(8676002)(46406003)(54906002)(38730400002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:SG2PR0601MB1885; H:morimoto-PC.renesas.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SG2PR0601MB1885; 23:ynOQpDfFy2KwzhVOH2ESxoCZkWNfm8nG0uH3b+6?= =?us-ascii?Q?49Tb7vdh232iPNHA8wyOjWWcB/YmQc2t5DnnpWOeZAul2SnrQBmMfYOXBO37?= =?us-ascii?Q?IsFRYlk16uye6zo8ZUFwyeyEAvdD7RjAwfUcPhgy+1VdGiJ0zqQJqKGZwMV1?= =?us-ascii?Q?W3geDyiCIVJiZz6WF0zwbnZgeCZTq1kiF+ld/2MmI6Mo2iz8Bzi2HAequxMp?= =?us-ascii?Q?+drIU9mExXsqfBoXm9JZelhN1LyfHkSBt21efgG+Jn/eF5XRwkzcA6xLlf/I?= =?us-ascii?Q?1X0UNMcVNtkvzyDsPuNiLrFgH82NaesBxvp8He7lv3itFkD3JbfHrAMad1py?= =?us-ascii?Q?z0yTyC+3dYhK33FXYSstncC00quGmIy4yNILlXvcJPmHdj5nLdMWbUGdNJrN?= =?us-ascii?Q?r25M90aQfUzKByTxAHWn85M5kWQwInqLr1l9j4m8iesiKGPJulsXqVFaEyRz?= =?us-ascii?Q?6cN9YyUvBIhqXFSRNpOToNWKcKhciP6YlJd6BAlEfVLrHTU5uUjfcg7lO6e5?= =?us-ascii?Q?11T9gGlDYu/gnEY1ZqkEg2a6llPKMZY7+iMsMTSBiQAqjUdbYvOBVrY4v10C?= =?us-ascii?Q?mgfZ6ARp0aNKDqCf+6e6/CRDFSKGTGJQxrX7bxzt0N/gllUrqVpyP7KxhMd7?= =?us-ascii?Q?9YKDGYs3J/FaUNPtko/ejH+KyrS80h75I79/Ny60Dx5lnwQyZSHfbCDrV6fk?= =?us-ascii?Q?Tp4qFK7ShG5Hn/kVamupXphqrrAFj/GNONJqTakiP3m8Lzw1cgnzlv1muzvt?= =?us-ascii?Q?VYYEXCANqYiOB72+XfKz6w2sJycMyvXth/BWVdVURreJUSlgy8Xs5p8+iTfU?= =?us-ascii?Q?oAvrE/ovy4SCdzETzKtZKopRk67MmrIPtA8axCC6LEOKOiOSE+Q1uidvrcI/?= =?us-ascii?Q?Eg4P/ol6gE7Axc6261+0FJWk6Ign5XYvf9qNMl2uZGRSqOXDqs2fXVqguCls?= =?us-ascii?Q?/4laJbwtu3BjyLORV1ee687M6cJuxH79/i3bzZPu1zwMfWASEgMiod6aLg7c?= =?us-ascii?Q?N7uDg0UKJAc95Pw/A2YUDhsqReHuFrwcSfzOSqECd/CrxkQMLcOpwxyL0fC/?= =?us-ascii?Q?q0YcADsU=3D?= X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1885; 6:jG4bRQ3ifmZKTBw8eVEuRkPasmqpgjOVhcOa+QzEqL/t2/OYWciT2DAb0QJZUo3AUxuKKHf/2jWJcHb4bY3Xsj3ny4DVyokKWQsDriiluMhijfNFLUhF+PHdO3x8sDLKztQilZMHNxRF312xjgIrjDt4Cp+B5ftovWI2hmEQZzLX7lXklfoMTuRTj7nuGipaXeRB3n9oVAAnjAE2Y5BJWa2yi/4hAB1M9JExxVsWmi/x4f7Un58pCA8vasO+eO9A0MmadJP63IpkqNoxptXo2bpcKXDSTCpB4e1cfM+rua1mKlefQXuSXyn1o+zCkrwT5iTTql3yRYZGUsni8ZGM4MHPOlQ2Z2EaXmeiPiBW/1VGAcHrolSHtI4jvGbiZBE7jDpRa4H0ZaQ4U2bCMSeMHxeidjFRDqP/SlXtbW3gixjcTAyjZzOgJ8Nn9rg7SPO+wROLzF9gNEYcR6CDa8vo5VWdpuBjqXweunezh6umGEMQUlvLkEVv0LgLO/w6gilTPt86vDc4h1fZNKSOV9gvKdci4g6cevBzvxkCbYMePSE=; 5:+4ch4yHDASmHmgp5kd0ZNHgVgRbrAKT/mYiyZAN89t/nzNznWjCaI2DG/NAxi9iC/KmJvxcLTCdEJ8cJO4D1B9EW0DwXaF30NhlixZ2XXZll3XtuA9ROeGZRAbl8fSFEyauSL26YNpwKqejqus6QLg==; 24:jrl3/8AvuijX2EbcQo19LdXiMoId5TGM8FZg19GD2gOoe0C3lR5CiRyrH/hP0V+u2gQLrWSZy4wEiGd1N2mraSRb5vDCrp7GDR7rx0NnDzg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1885; 7:AgmMvJnbPtxBkTSpgCQuv45lFe9aE/Wt2F6fxUzkUJHOFe0N0bCbLAD4QVs87egAlecKWhDd5I33C6lMsZgfgPLQk+bG7JSvBCCw4Q8cGL0tuGruTlf/qzE5Ze5QTZMm3yPaogKLiKS8vbDSwy8K8VKsuYmu+O6Un49Y4KVJ6fwerFaK2Rmur24uORybxgBtguSQZ6cdN/m5tdXb09p/q9CjnYzKfBtI7XdfTIJnfJF0CQmCwzKU+sc7ZLyVky8vWSWc8eFaatSkZM+XYLX1w5yb37stXkSzen5hOX42GBU39gMNxYSgTQoWpBK/0H6uR0wMPWE4W9uiYPvv07yykQ==; 20:KSkBdvhrul7B1Yn4R0l71YMxBD2LZoSnbdMvWCMMRIY9OoPLPNZGQ4/SuTzz3yim8cvCBigl9yYOXwSZNY/m7xsAdvf0dcJAumHfZD6T/8LA3bpjqtrbZDepvfV82KtXjEgEQgMw81R1eNJYdyL9AuHJVOT/oZ3A3ZaY8s/ZMIg= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 00:57:21.1726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR0601MB1885 Cc: Linux-Renesas , Linux-ALSA , Simon Subject: [alsa-devel] [PATCH 1/4] ASoC: simple-card: tidyup return method from probe() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto Current return method from probe() is very confusable. This patch tidyup it to normal return method Reported-by: Dan Carpenter Signed-off-by: Kuninori Morimoto --- sound/soc/generic/simple-card.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 4b7b135..6bcaaf9 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -474,8 +474,10 @@ static int asoc_simple_card_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, priv); ret = devm_snd_soc_register_card(dev, card); - if (ret >= 0) - return ret; + if (ret < 0) + goto err; + + return 0; err: asoc_simple_card_clean_reference(card);