From patchwork Wed Jun 9 05:27:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 12308985 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FB53C47095 for ; Wed, 9 Jun 2021 05:28:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC22E611BD for ; Wed, 9 Jun 2021 05:28:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC22E611BD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9D92D16C3; Wed, 9 Jun 2021 07:27:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9D92D16C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623216522; bh=EaHG+9z//75KBjsOzvr4mrwE1V4qV7XTSMHsQ0NryJg=; h=Date:From:Subject:To:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BKgOeSRZ4SQ0BFXLTOM/PSS/cTuGvttdCxVXi6hOksvAuoveK5aPvbDePC7YOtLjl RCSXkfp/5XqaA2x1M7P73BuDa9XWcCwEe4DNGsMNVhYhnQ/pEHPGJ3lwu3dYdqvC/6 579S7PKY/86Ml8YBXvJoGzB9dZ9osoM/KiY78piI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3847FF800F4; Wed, 9 Jun 2021 07:27:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6AAA4F8026C; Wed, 9 Jun 2021 07:27:50 +0200 (CEST) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id F1D7EF800F4 for ; Wed, 9 Jun 2021 07:27:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F1D7EF800F4 Date: 09 Jun 2021 14:27:33 +0900 X-IronPort-AV: E=Sophos;i="5.83,260,1616425200"; d="scan'208";a="83680465" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 09 Jun 2021 14:27:33 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 84BA1418D0D9; Wed, 9 Jun 2021 14:27:33 +0900 (JST) Message-ID: <87y2bjboai.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH v2 9/8] ASoC: soc-core: add comment of return value for snd_soc_daifmt_parse_clock_provider_raw() User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") To: Liam Girdwood , Mark Brown In-Reply-To: <87czsvdc4o.wl-kuninori.morimoto.gx@renesas.com> References: <87czsvdc4o.wl-kuninori.morimoto.gx@renesas.com> Cc: Alexandre Belloni , Timur Tabi , Xiubo Li , Martin Blumenstingl , Shengjiu Wang , Sameer Pujar , Neil Armstrong , Nicolas Ferre , Nicolin Chen , Ludovic Desroches , Kevin Hilman , Codrin Ciubotariu , alsa-devel@alsa-project.org, Fabio Estevam , Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Kuninori Morimoto return value from snd_soc_daifmt_parse_clock_provider_raw() will be used at snd_soc_daifmt_clock_provider_from_bitmap(). But it is very difficult to know that without any comments. This patch adds it. Signed-off-by: Kuninori Morimoto --- Hi Mark snd_soc_daifmt_clock_provider_from_bitmap() was used from snd_soc_of_parse_daifmt() too. [8/8] patch removes it, and this patch was postponed until it. But I forgot to include this. Thus this patch has strange numbering [9/8]. sound/soc/soc-core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 638dc6beecdd..0fa4966eddfc 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -3021,6 +3021,11 @@ EXPORT_SYMBOL_GPL(snd_soc_daifmt_clock_provider_fliped); unsigned int snd_soc_daifmt_clock_provider_from_bitmap(unsigned int bit_frame) { + /* + * bit_frame is return value from + * snd_soc_daifmt_parse_clock_provider_raw() + */ + /* Codec base */ switch (bit_frame) { case 0x11: @@ -3149,6 +3154,11 @@ unsigned int snd_soc_daifmt_parse_clock_provider_raw(struct device_node *np, if (frame && framemaster) *framemaster = of_parse_phandle(np, prop, 0); + /* + * return bitmap. + * It will be parameter of + * snd_soc_daifmt_clock_provider_from_bitmap() + */ return (bit << 4) + frame; } EXPORT_SYMBOL_GPL(snd_soc_daifmt_parse_clock_provider_raw);