diff mbox

ASoC: ak4642: Replace mdelay function to msleep

Message ID 87ziizpsxr.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kuninori Morimoto Jan. 10, 2017, 2:13 a.m. UTC 
From: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>

Replace mdelay to msleep to avoid busy loop on ak4642_lout_event().
Otherwise, sometimes playback doesn't work correctly when pulseaudio
was used.

Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/codecs/ak4642.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Jan. 10, 2017, 12:24 p.m. UTC | #1 
On Tue, Jan 10, 2017 at 02:13:04AM +0000, Kuninori Morimoto wrote:

>  	case SND_SOC_DAPM_POST_PMU:	/* after widget power up */
>  		/* Power save mode OFF */
> -		mdelay(popup_wait);
> +		msleep(popup_wait);
>  		snd_soc_update_bits(codec, SG_SL2, LOPS, 0);
>  		break;

This doesn't apply against current code, the driver appears to have a
fixed delay here not a variable one?
diff mbox

Patch

diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c
index 40500cd..0205ae1 100644
--- a/sound/soc/codecs/ak4642.c
+++ b/sound/soc/codecs/ak4642.c
@@ -186,7 +186,7 @@  static int ak4642_lout_event(struct snd_soc_dapm_widget *w,
 		break;
 	case SND_SOC_DAPM_POST_PMU:	/* after widget power up */
 		/* Power save mode OFF */
-		mdelay(popup_wait);
+		msleep(popup_wait);
 		snd_soc_update_bits(codec, SG_SL2, LOPS, 0);
 		break;
 	case SND_SOC_DAPM_PRE_PMD:	/* before widget power down */