| Message ID | 8bad41b7ddbc8e061f682ecdf00a50e1@aosc.io (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: amd: yc: fix internal mic on Xiaomi Book Pro 14 2022 | expand |
On 10/31/2024 23:35, Mingcong Bai wrote: > Xiaomi Book Pro 14 2022 (MIA2210-AD) requires a quirk entry for its > internal microphone to be enabled. > > This is likely due to similar reasons as seen previously on Redmi Book > 14/15 Pro 2022 models (since they likely came with similar firmware): > > - dcff8b7ca92d724bdaf474a3fa37a7748377813a (ASoC: amd: yc: Add Xiaomi > Redmi Book Pro 15 2022 into DMI table) > - c1dd6bf6199752890d8c59d895dd45094da51d1f (ASoC: amd: yc: Add Xiaomi > Redmi Book Pro 14 2022 into DMI table) > > A quirk would likely be needed for Xiaomi Book Pro 15 2022 models, too. > However, I do not have such device on hand so I will leave it for now. > > Signed-off-by: Mingcong Bai <jeffbai@aosc.io> Yes makes sense this is a Rembrandt laptop. Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > --- > sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c > index 438865d5e376..dc476bfb6da4 100644 > --- a/sound/soc/amd/yc/acp6x-mach.c > +++ b/sound/soc/amd/yc/acp6x-mach.c > @@ -395,6 +395,13 @@ static const struct dmi_system_id > yc_acp_quirk_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "Redmi Book Pro 15 2022"), > } > }, > + { > + .driver_data = &acp6x_card, > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "TIMI"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Xiaomi Book Pro 14 2022"), > + } > + }, > { > .driver_data = &acp6x_card, > .matches = {
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 438865d5e376..dc476bfb6da4 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -395,6 +395,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Redmi Book Pro 15 2022"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "TIMI"), + DMI_MATCH(DMI_PRODUCT_NAME, "Xiaomi Book Pro 14 2022"), + } + }, { .driver_data = &acp6x_card,
Xiaomi Book Pro 14 2022 (MIA2210-AD) requires a quirk entry for its internal microphone to be enabled. This is likely due to similar reasons as seen previously on Redmi Book 14/15 Pro 2022 models (since they likely came with similar firmware): - dcff8b7ca92d724bdaf474a3fa37a7748377813a (ASoC: amd: yc: Add Xiaomi Redmi Book Pro 15 2022 into DMI table) - c1dd6bf6199752890d8c59d895dd45094da51d1f (ASoC: amd: yc: Add Xiaomi Redmi Book Pro 14 2022 into DMI table) A quirk would likely be needed for Xiaomi Book Pro 15 2022 models, too. However, I do not have such device on hand so I will leave it for now. Signed-off-by: Mingcong Bai <jeffbai@aosc.io> --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) .matches = {