From patchwork Fri Aug 11 18:00:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9896395 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DCD17600CB for ; Fri, 11 Aug 2017 18:01:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB1AF28C98 for ; Fri, 11 Aug 2017 18:01:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C011428C91; Fri, 11 Aug 2017 18:01:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C3EF28C90 for ; Fri, 11 Aug 2017 18:00:57 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 3109A266C9A; Fri, 11 Aug 2017 20:00:42 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5D952266CC2; Fri, 11 Aug 2017 20:00:41 +0200 (CEST) Received: from mout.web.de (mout.web.de [212.227.15.3]) by alsa0.perex.cz (Postfix) with ESMTP id D01A0266C85 for ; Fri, 11 Aug 2017 20:00:39 +0200 (CEST) Received: from [192.168.1.2] ([77.181.164.13]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M3PN2-1dOQGe086i-00qxEC; Fri, 11 Aug 2017 20:00:32 +0200 To: alsa-devel@alsa-project.org, Daniel Mack , Jaroslav Kysela , Takashi Iwai From: SF Markus Elfring Message-ID: <8cb2a553-e247-f432-48ef-1a7438416366@users.sourceforge.net> Date: Fri, 11 Aug 2017 20:00:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Language: en-GB X-Provags-ID: V03:K0:x4Gw8rLcsJEIEPXSDE+nkixZoJwpy0JhEnDynhjgXlSD4k8Hg/a v8ksXEEbT6Mmhc5+52Ar3PakCG6vFmrBFGUkZ2vvHfnOw16qX5cyOEydeDG6ev3z7fGcDSf Ejd/tZOQJoJm0zObM69YX8rpbCVCjGoZB9TyhJxASjLQfeUCFM+sEXgyV/oX1f9yolwge2u 9oEp3V7C1nvel6fFA8CtA== X-UI-Out-Filterresults: notjunk:1; V01:K0:MpGA2XVgIRQ=:Lp4mSPbxhqf9j/LW0FTXE1 TRy6YhiQFc9epcd32RzPae6zRtnmni4Ujiuw4VbSIJlRWpO3FSUo5PPz54OOAv3I6WU2RqjdF MmSKeQD/+QSameVWlGdo6GerMxyMr8JWgAu0+Spv6FG/4QRUafgSQlpCGEV05dJnV3jdQ4O5N 7nB8/OE26KrhJP83xclIXD0w2mUw4fHZsXDx346qt2s2r3UXoMHdGnGjjQb4TwQngZ6aWlrfC tvIBvSHAUoGnqAvjfqTveN5/obR6gqU0KTlek+71RJlMgADRlEXqVHIRmv5fLQBvJuazSa2Tj 3Sg5j2xc38iOh9JJb0viMwFJ0yXhYlRRaejTr1cEa0gwtU3/wilq6+Vge+HhpHUtafBLT5czp zQIBJL4WUpdYZRUFYTuGZ152SA2WlLXCPAr8zop4M5Tz3/LIraEp53DsWciY7SFiKucZ+OzFu ZoW96Gcqjuk14TL0AfY7y4eq+qc6B5vw8aTkYjNnvaCeLksJ07wBF3LVKDKT6MbE8suI1SHb2 ezLgfsTbjRAWYW76POtBGTc6Dxu2OpH/EmmzqOUFI8Y9IL4evIw2ahQj7L19CgqaeY6u6vxxN /r5Et+mVx64FS3nhm1XMJ28i4TN51ku4mthb4tGmxTnRorAc6NlDirK9VSRitErECPXPWgXGa w93ZYT6+/r8TW07Ht6ZtAVV5M2pClsYXGQpfV2H8bzrJnSJHDnilHHb0sUvwTpF+sUXWsD1L9 WaPM1fMn4daETqt1iUIYBuL41LYYBvVpXKMBYlOYPbndIM5eHKQTx5uSzRjUz2qIJI0xhZX+X pT9Cu6GvgyO53JFPqq6W/jiY1wttWt1kCm86xJ3XGeTBIW0lTI= Cc: kernel-janitors@vger.kernel.org, LKML Subject: [alsa-devel] [PATCH] ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Fri, 11 Aug 2017 19:39:06 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Daniel Mack --- sound/usb/caiaq/audio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c index 8f66ba730d69..1f306155e76a 100644 --- a/sound/usb/caiaq/audio.c +++ b/sound/usb/caiaq/audio.c @@ -731,7 +731,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) urbs = kmalloc(N_URBS * sizeof(*urbs), GFP_KERNEL); if (!urbs) { - dev_err(dev, "unable to kmalloc() urbs, OOM!?\n"); *ret = -ENOMEM; return NULL; } @@ -746,7 +745,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) urbs[i]->transfer_buffer = kmalloc(FRAMES_PER_URB * BYTES_PER_FRAME, GFP_KERNEL); if (!urbs[i]->transfer_buffer) { - dev_err(dev, "unable to kmalloc() transfer buffer, OOM!?\n"); *ret = -ENOMEM; return urbs; }