From patchwork Sat Sep 26 22:04:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 7272191 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 714F0BEEC1 for ; Sat, 26 Sep 2015 22:05:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A0E45207E1 for ; Sat, 26 Sep 2015 22:05:09 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 798AC207DF for ; Sat, 26 Sep 2015 22:05:08 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 47F0B260789; Sun, 27 Sep 2015 00:05:02 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 126712606FE; Sun, 27 Sep 2015 00:04:55 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 299A1260701; Sun, 27 Sep 2015 00:04:53 +0200 (CEST) Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by alsa0.perex.cz (Postfix) with ESMTP id EF8682606FD for ; Sun, 27 Sep 2015 00:04:45 +0200 (CEST) Received: by pacex6 with SMTP id ex6so137743268pac.0 for ; Sat, 26 Sep 2015 15:04:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/sTlcjx3ySMkTaTD76qmlRxei1MjlYLKzO3orLUeRVI=; b=iFfllIOkLzmECBMsrePBwzyqa6N9hnwDqu7yCQzpia+r9Rkdp/uf6ESdsEVni0jbBQ CCn/GBc2grFjy4aEiT6lGohmV6fAXjPNY+NNPsqlQFPEGVMiZJIiWhnCgzmeBrhMmpdG ngiuLZzpWZubT3Eam3aMUALOgAKiBvEa3aFKJbkETO9ykE27AuzicfbODX+FCPMkm/J/ yx8G5p7fwF2ExSUoJXwlEyZY36xvGblfUzuJnN9Vri0UQBjnE47PqLuCsRGJFbLY29sl msiwV6So3BS7Np429wTHS3nMM96RQCKOUsVD55XTyVnMyrrHKzs9x2s7vQtwba8ieWCE jTqA== X-Gm-Message-State: ALoCoQkULwWhrFEaxB34qUcsAruvsgmPPITN58LV3BgCfHcF/KMk1m0IBizdYe5jtNnLJ9ivbpYk X-Received: by 10.68.191.200 with SMTP id ha8mr16768041pbc.72.1443305081197; Sat, 26 Sep 2015 15:04:41 -0700 (PDT) Received: from localhost (c-67-169-81-235.hsd1.ca.comcast.net. [67.169.81.235]) by smtp.gmail.com with ESMTPSA id qy5sm10933604pbb.16.2015.09.26.15.04.40 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 26 Sep 2015 15:04:40 -0700 (PDT) From: Viresh Kumar To: Greg Kroah-Hartman Date: Sat, 26 Sep 2015 15:04:06 -0700 Message-Id: <8d3d3428c3a36f821e4c3d8563d094ca4b4763fd.1443304934.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.4.0 Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org, linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org, Viresh Kumar , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, QCA ath9k Development , linux-kernel@vger.kernel.org, Intel Linux Wireless , linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org Subject: [alsa-devel] [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big endian 64-bit systems. There are no such platforms yet, but the code needs to be robust for such a case. Fix that by changing type of 'global_lock' to u32. Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki --- BCC'd a lot of people (rather than cc'ing them) to make sure - the series reaches them - mailing lists do not block the patchset due to long cc list - and we don't spam the BCC'd people for every reply V4->V5: - Switch back to the original solution of making global_lock u32. --- drivers/acpi/ec_sys.c | 2 +- drivers/acpi/internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c index b4c216bab22b..bea8e425a8de 100644 --- a/drivers/acpi/ec_sys.c +++ b/drivers/acpi/ec_sys.c @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe)) goto error; if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, - (u32 *)&first_ec->global_lock)) + &first_ec->global_lock)) goto error; if (write_support) diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h index 9e426210c2a8..9db196de003c 100644 --- a/drivers/acpi/internal.h +++ b/drivers/acpi/internal.h @@ -138,7 +138,7 @@ struct acpi_ec { unsigned long gpe; unsigned long command_addr; unsigned long data_addr; - unsigned long global_lock; + u32 global_lock; unsigned long flags; unsigned long reference_count; struct mutex mutex;