From patchwork Wed Dec 7 20:31:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 9465383 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 90A6360236 for ; Wed, 7 Dec 2016 22:21:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 758E728556 for ; Wed, 7 Dec 2016 22:21:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 68DDF28589; Wed, 7 Dec 2016 22:21:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76C0C28556 for ; Wed, 7 Dec 2016 22:21:36 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9ACDB267379; Wed, 7 Dec 2016 23:21:35 +0100 (CET) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id BBBE2266801; Wed, 7 Dec 2016 23:19:16 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id CE4392669F6; Wed, 7 Dec 2016 21:31:04 +0100 (CET) Received: from mailsec102.isp.belgacom.be (mailsec102.isp.belgacom.be [195.238.20.98]) by alsa0.perex.cz (Postfix) with ESMTP id 33DE7266801 for ; Wed, 7 Dec 2016 21:31:02 +0100 (CET) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AUAQAlcUhY/9MU7sNeGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBgzkBAQEBAR+BYI1JlxCScIIPggeGIgKBez8UAQIBAQEBAQEBYii?= =?us-ascii?q?EaAEBAQMBI1YFCwUEAg4KAgIYDgICVwYTEYhWDIpknUeCKYRrhnuBC4UzhFuES?= =?us-ascii?q?IMEgl0FhxeTUJMOjk2HY4YihA4fN4EZhVY9NIkgAQEB?= X-IPAS-Result: =?us-ascii?q?A2AUAQAlcUhY/9MU7sNeGQEBAQEBAQEBAQEBBwEBAQEBgzk?= =?us-ascii?q?BAQEBAR+BYI1JlxCScIIPggeGIgKBez8UAQIBAQEBAQEBYiiEaAEBAQMBI1YFC?= =?us-ascii?q?wUEAg4KAgIYDgICVwYTEYhWDIpknUeCKYRrhnuBC4UzhFuESIMEgl0FhxeTUJM?= =?us-ascii?q?Ojk2HY4YihA4fN4EZhVY9NIkgAQEB?= Received: from mailrmu003.isp.belgacom.be ([195.238.20.211]) by privrelay.isp.belgacom.be with ESMTP; 07 Dec 2016 21:31:02 +0100 Date: Wed, 7 Dec 2016 21:31:02 +0100 (CET) From: Fabian Frederick To: Krzysztof Kozlowski Message-ID: <948424390.581380.1481142662205.open-xchange@webmail.nmp.proximus.be> In-Reply-To: <20161207175502.GA13187@kozik-lap> References: <1481096342-19104-1-git-send-email-fabf@skynet.be> <20161207175502.GA13187@kozik-lap> MIME-Version: 1.0 X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.2.2-Rev27 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki Subject: Re: [alsa-devel] [PATCH 1/1 linux-next] ASoC: samsung: include gpio consumer.h X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Fabian Frederick List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP > On 07 December 2016 at 18:55 Krzysztof Kozlowski wrote: > > > On Wed, Dec 07, 2016 at 08:39:02AM +0100, Fabian Frederick wrote: > > Fix the following build errors > > I couldn't reproduce it on default config. Can you mention the necessary > environment/defconfig/arch etc.? > > Patch itself looks needed. However shouldn't the driver depend also on > GPIOLIB? > > Best regards, > Krzysztof Hi Krzysztof,         It's based on a randconfig with compile_test without gpiolib. I reproduced it with make defconfig followed by selecting x86_32 SPI SND_SOC_SAMSUNG MFD_ARIZONA_I2C MFD_ARIZONA SND_SOC COMPILE_TEST X86_INTEL_QUARK COMMON_CLK SND_SOC_SAMSUNG SND_SOC_SAMSUNG_TM2_WM5110 Here's another patch solving the same problem with complete explanation: Commit 638f958baeaf ("extcon: Allow compile test of GPIO consumers if !GPIOLIB") as you're suggesting, we could add depend on GPIOLIB. extcon has the following: depends on GPIOLIB || COMPILE_TEST smartq_wm8987.c also has gpio_consumer.h for SND_SOC_SMARTQ which would give the following update on samsung/Kconfig besides initial patch: Regards, Fabian > > > sound/soc/samsung/tm2_wm5110.c:220:3: error: implicit declaration > > of function 'gpiod_set_value_cansleep' > > [-Werror=implicit-function-declaration] > > sound/soc/samsung/tm2_wm5110.c:438:24: error: implicit declaration > > of function 'devm_gpiod_get' [-Werror=implicit-function-declaration] > > > > Signed-off-by: Fabian Frederick > > --- > >  sound/soc/samsung/tm2_wm5110.c | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c > > index 5cdf7d1..24cc9d6 100644 > > --- a/sound/soc/samsung/tm2_wm5110.c > > +++ b/sound/soc/samsung/tm2_wm5110.c > > @@ -12,6 +12,7 @@ > >  > >  #include > >  #include > > +#include > >  #include > >  #include > >  #include > > -- > > 2.7.4 > > diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig index 7c42315..f1f1d79 100644 --- a/sound/soc/samsung/Kconfig +++ b/sound/soc/samsung/Kconfig @@ -111,6 +111,7 @@ config SND_SOC_SAMSUNG_RX1950_UDA1380  config SND_SOC_SMARTQ         tristate "SoC I2S Audio support for SmartQ board"         depends on MACH_SMARTQ || COMPILE_TEST +       depends on GPIOLIB || COMPILE_TEST         depends on I2C         select SND_SAMSUNG_I2S         select SND_SOC_WM8750 @@ -193,6 +194,7 @@ config SND_SOC_ARNDALE_RT5631_ALC5631  config SND_SOC_SAMSUNG_TM2_WM5110         tristate "SoC I2S Audio support for WM5110 on TM2 board"         depends on SND_SOC_SAMSUNG && MFD_ARIZONA && I2C && SPI_MASTER +       depends on GPIOLIB || COMPILE_TEST         select SND_SOC_MAX98504         select SND_SOC_WM5110         select SND_SAMSUNG_I2S