From patchwork Fri Aug 11 10:46:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9895439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 865F1602DA for ; Fri, 11 Aug 2017 10:48:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 766BD28BF2 for ; Fri, 11 Aug 2017 10:48:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B45928C00; Fri, 11 Aug 2017 10:48:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2327C28C14 for ; Fri, 11 Aug 2017 10:47:59 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 8B8E9266C78; Fri, 11 Aug 2017 12:47:05 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2E46E266D22; Fri, 11 Aug 2017 12:47:04 +0200 (CEST) Received: from mout.web.de (mout.web.de [212.227.15.14]) by alsa0.perex.cz (Postfix) with ESMTP id 4927C26648D for ; Fri, 11 Aug 2017 12:47:01 +0200 (CEST) Received: from [192.168.1.2] ([77.181.164.13]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lb289-1dD8Mj3Ett-00kja0; Fri, 11 Aug 2017 12:46:56 +0200 To: alsa-devel@alsa-project.org, Andy Shevchenko , Dmitry Torokhov , Jaroslav Kysela , Liam Girdwood , Mark Brown From: SF Markus Elfring Message-ID: <95614c7b-9856-94f8-4550-a87048cfe283@users.sourceforge.net> Date: Fri, 11 Aug 2017 12:46:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Language: en-GB X-Provags-ID: V03:K0:5wTc8U/ZRr5TpRDoKoPJHE4gy8u+Z0muC5Sk0GBB9toCer7I8nX lQgO4PNWFgYKHmF+4NZ+j/CUocYGS7sQYmQLxRyUN3EPDncgt4JYvPZvuae4PcZz4t6Pa5e nXqmLpLIi2OUL6mLJ4D8j5dmpNvVC+3J6rkiZpQF+ofjnpYFEF8NBaH7S/5Zo1OI4drCcGU 7qxz/loF78V9uyNrvTV/g== X-UI-Out-Filterresults: notjunk:1; V01:K0:hHFreotWVDI=:dG4WhPjCkl8W1MLd1OSOCz 1QYAhZhazfTc6ZzoJhWmdDVnuEf+mU2sM0S2jH8j3bobg79O5nvtWe9QaYHW7Qjta8vtyPvl3 G+P3dQKlNEBetPU8pfhqRGQ0jb8pDVraeE6Av1pZDziB03Hbws4Bd8tW+9i2nFe87J/Ua8eFS Z6/mJG3s190gBjlRIH7On+ixmyb3LirRkp+m1Znx6swYzAreTWX2raoRgD7iXFH8QG2Fsbtj6 FDCwuvyYV+SejkQRIfkZQl3aSrUN4Vy0Bgz8Jt4TG2WBxB1KrUrzZLsjkT99WgccpfM5dzJAH WHtJMu3zn1ocZHm7roqQ5wBc7VNcyBNx51Asm5s3mwNiDBxGl5VGABSXoIDY36US1DGtKzvtP wqSA8YuOFZCYQnF5B3lYWXm45FLSFF7wiDrycQ3K1AToivuMa4l9uhdQAi77mw19QEN8WLmOf pP4SwnuryxAUdgZQYqOvGH+udzVx90tAt2XiSssC8ekYWgPiGMBNhKY/eGpIXZShgxG/ffBIl ui1ToqDEQPHQux80oKTN6O5g5Oo0I/YoSPO8s9T6cL5LOGrlrlNEqRm0GJIvMBP7rJIy+og1W sH3gvfQ6CM0MZV7NdDLo5lVfVJ0w156yCPxhUa0/sbgN6VYA5zuN7iw/5dZ44LYKOVWGScyc0 hZiJBr8nBnXjZ2MsTimcfH3aAbbWZfoIDMxczavAAk3d78Thk+jlmGSwqx24CuP+XZUTPu+XI R+qXAuRfNeHYdu+pQh5j/v00zApfO9G6XooO+i0MAEWeyyhK8ZG/a7NBgmkUwwHa39qAkrSKa USQ86aB0UrRRcQId8g/7At6YrQqIJ7oSL3G/3FxlJIGckCjC/s= Cc: kernel-janitors@vger.kernel.org, LKML Subject: [alsa-devel] [PATCH] ASoC: Baytrail SST MAX98090: Delete an error message for a failed memory allocation in byt_max98090_probe() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Fri, 11 Aug 2017 12:42:40 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- sound/soc/intel/boards/byt-max98090.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/intel/boards/byt-max98090.c b/sound/soc/intel/boards/byt-max98090.c index 047be7fa0ce9..fa68bb32adef 100644 --- a/sound/soc/intel/boards/byt-max98090.c +++ b/sound/soc/intel/boards/byt-max98090.c @@ -152,10 +152,8 @@ static int byt_max98090_probe(struct platform_device *pdev) int ret_val; priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_ATOMIC); - if (!priv) { - dev_err(&pdev->dev, "allocation failed\n"); + if (!priv) return -ENOMEM; - } ret_val = devm_acpi_dev_add_driver_gpios(dev->parent, acpi_byt_max98090_gpios); if (ret_val)