| Message ID | 9e2493401df1f2f0419fa175b4fc9a84eb971e28.1483531270.git.neko@nya.ai (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 03200140ee83b3655152bc0c144378732fec8af1 |
| Headers | show |
On Wed, Jan 04, 2017 at 03:22:12PM +0300, Alexandrov Stansilav wrote: This looks okay, but title is same for both of the patches. It would be better to describe the change you are doing and not the outcome. so a better title could be: ASoC: rt5640: Add "10EC3276" ACPI ID and in log say: HP Pavilion x2 10-p000 comes with rt5640 with ACPI ID "10EC3276" so add that. > Signed-off-by: Alexandrov Stansilav <neko@nya.ai> > --- > sound/soc/codecs/rt5640.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c > index e29a6de..b857a71 100644 > --- a/sound/soc/codecs/rt5640.c > +++ b/sound/soc/codecs/rt5640.c > @@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match); > #ifdef CONFIG_ACPI > static const struct acpi_device_id rt5640_acpi_match[] = { > { "INT33CA", 0 }, > + { "10EC3276", 0 }, > { "10EC5640", 0 }, > { "10EC5642", 0 }, > { "INTCCFFD", 0 }, > -- > 2.10.2 >
> Vinod Koul писал 2017-01-05 06:49: > > This looks okay, but title is same for both of the patches. It would be > better to describe the change you are doing and not the outcome. > > so a better title could be: > > ASoC: rt5640: Add "10EC3276" ACPI ID > > and in log say: > > HP Pavilion x2 10-p000 comes with rt5640 with ACPI ID "10EC3276" so add > that. Thanks for comments. And i'm sorry for this inconvenience -_- I will send new patchset with corrections.
diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c index e29a6de..b857a71 100644 --- a/sound/soc/codecs/rt5640.c +++ b/sound/soc/codecs/rt5640.c @@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match); #ifdef CONFIG_ACPI static const struct acpi_device_id rt5640_acpi_match[] = { { "INT33CA", 0 }, + { "10EC3276", 0 }, { "10EC5640", 0 }, { "10EC5642", 0 }, { "INTCCFFD", 0 },
Signed-off-by: Alexandrov Stansilav <neko@nya.ai> --- sound/soc/codecs/rt5640.c | 1 + 1 file changed, 1 insertion(+)