From patchwork Thu Nov 2 13:12:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10038727 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F24A5603B5 for ; Thu, 2 Nov 2017 13:12:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E355B28FA0 for ; Thu, 2 Nov 2017 13:12:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D640328FA6; Thu, 2 Nov 2017 13:12:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 133FE28FA0 for ; Thu, 2 Nov 2017 13:12:18 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 8C61D267492; Thu, 2 Nov 2017 14:12:17 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 905A726749A; Thu, 2 Nov 2017 14:12:15 +0100 (CET) Received: from mail-ot0-f196.google.com (mail-ot0-f196.google.com [74.125.82.196]) by alsa0.perex.cz (Postfix) with ESMTP id 3214E266DEA for ; Thu, 2 Nov 2017 14:12:13 +0100 (CET) Received: by mail-ot0-f196.google.com with SMTP id i19so1421249ote.13 for ; Thu, 02 Nov 2017 06:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=JiYTqbSTR63Uo0XMTY77/lj4PNId3D4Xxo0BKGt91oA=; b=k3NuFvsqHqAYrgtYLGfK5cvWCEwtFKYzhtRbQXPCLds6yjHgrjbp1SxRak1pfSo6aU MkeQ1IkJd+YgS7JMALDiNm6M/E7EHBgQdLlpZhLipqGrjVp6DC86pBYdEcJivFINF6/7 FOblYME7pqFbirhkUSK7Bns9U4OWnNIEvUN7aVhMhVQ4qb64VhwWVwcer8Pmd4xLZW/U L43nynaP2rk9RO8ArCgbqMoIek80jiM76cOk3f3ZZT1Ye3nPHd6DQKOyFnh33BUpjWEm 9oWOcNw2EMKz0tzMUFrFVOJ7sJg8Ba3ggMo2X3JL9CWZG4h7/RciJMSojVsPBh9zXAWt Blfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=JiYTqbSTR63Uo0XMTY77/lj4PNId3D4Xxo0BKGt91oA=; b=kVmJo3h7tKvvFDSqOHQrmQFCnoVnH8h5S7MW09GPdyc+kXBda6A/600lRHBsBaQxQI SQcMSZe1IRKdM74/17r17mk8LDiBkW8hq8dktWG+OBdpvsEzYZU23tT7NSS8coMTS1XV /mJhZxPyD61odl885sYWEt7NJ6rbgo/pFinaCcql9AWSGDD5HbR1riTsfh+coYFxI0A7 2Hp+xuSsN/RYhi/CEmOhI7NHr2wxr5h/C5uNRxnwqpQwTg3o+DaHdRtuxiC4WT7btj2L UXhAXLdCUs4InJuBZDV3GgtNtztc7ZE6NK2u4MtujRO0QAWiDCAnq2MQGT9OezM50Qdq 9W6A== X-Gm-Message-State: AJaThX4kn98taJK5NnS71qLv8oZ2A6PJp2vfZpsNxRptvTQVNuxBGHsK fvHlXbXYgszor6TwaMah0PjKVl/Lv3FSAOLKQU4= X-Google-Smtp-Source: ABhQp+TjXKRkbfTRRirXxDnJrBRrzZ1UwuKsL0ABTsqGWbPrkMIJkOIxubdasTzf7b1x6dwzv1UAmx2OrI+mgxI9gy8= X-Received: by 10.157.39.120 with SMTP id r111mr2183201ota.402.1509628332035; Thu, 02 Nov 2017 06:12:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.28.152 with HTTP; Thu, 2 Nov 2017 06:12:11 -0700 (PDT) In-Reply-To: References: <20171102110737.2813128-1-arnd@arndb.de> <48ffc83d-6ab0-3388-fade-9e02dc4459cf@linux.intel.com> From: Arnd Bergmann Date: Thu, 2 Nov 2017 14:12:11 +0100 X-Google-Sender-Auth: lJ976hKoGwJkUoYiWXWDXUFunCU Message-ID: To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, Vinod Koul , Linux Kernel Mailing List , Takashi Iwai , Liam Girdwood , Harsha Priya N , Mark Brown , Naveen M , Andy Shevchenko Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: fix Kconfig dependencies X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Nov 2, 2017 at 2:04 PM, Arnd Bergmann wrote: > On Thu, Nov 2, 2017 at 1:43 PM, Pierre-Louis Bossart > wrote: >> On 11/2/17 6:07 AM, Arnd Bergmann wrote: >>> >>> I ran into multiple problems during randconfig builds of the >>> recently changed Kconfig logic for Intel ASoC drivers: >> >> >> we did quite a bit of testing on this change, looks like we missed a number >> of cases. Gah. >> >>> >>> - Building without DMADEVICES doesn't work in general >> >> >> the Intel audio hardware has its own DMA in general, be it based on >> DesignWare controlled by audio firmware or HDaudio, not sure if/why this >> dependency is needed across the board? > > Probably my mistake. I'll try again without the dependency and see > what problems I run into then and what the correct fix is. I immediately ran into this Kconfig warning, so this is clearly for the two users of SND_SOC_INTEL_SST_FIRMWARE: warning: (SATA_DWC_OLD_DMA && SERIAL_8250_LPSS && SND_SOC_INTEL_SST_FIRMWARE) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES) I'm testing with this fixup now: diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index e18118209b75..89126fa3f846 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -20,7 +20,6 @@ config SND_SOC_INTEL_SST config SND_SOC_INTEL_SST_FIRMWARE tristate - select DW_DMAC_CORE config SND_SOC_INTEL_SST_ACPI tristate @@ -32,19 +31,20 @@ config SND_SOC_ACPI_INTEL_MATCH config SND_SOC_INTEL_SST_TOPLEVEL tristate "Intel ASoC SST drivers" depends on X86 || COMPILE_TEST - depends on DMADEVICES select SND_SOC_INTEL_MACH select SND_SOC_INTEL_COMMON config SND_SOC_INTEL_HASWELL tristate "Intel ASoC SST driver for Haswell/Broadwell" depends on SND_SOC_INTEL_SST_TOPLEVEL && SND_DMA_SGBUF + depends on DMADEVICES select SND_SOC_INTEL_SST select SND_SOC_INTEL_SST_FIRMWARE config SND_SOC_INTEL_BAYTRAIL tristate "Intel ASoC SST driver for Baytrail (legacy)" depends on SND_SOC_INTEL_SST_TOPLEVEL + depends on DMADEVICES select SND_SOC_INTEL_SST select SND_SOC_INTEL_SST_FIRMWARE diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig index 449bc8baaa60..5063f15b4ca4 100644 --- a/sound/soc/intel/boards/Kconfig +++ b/sound/soc/intel/boards/Kconfig @@ -19,7 +19,6 @@ config SND_SOC_INTEL_HASWELL_MACH tristate "ASoC Audio DSP support for Intel Haswell Lynxpoint" depends on SND_SOC_INTEL_MACH depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM - depends on DMADEVICES depends on SND_SOC_INTEL_HASWELL select SND_SOC_RT5640 help @@ -32,7 +31,6 @@ config SND_SOC_INTEL_BDW_RT5677_MACH tristate "ASoC Audio driver for Intel Broadwell with RT5677 codec" depends on SND_SOC_INTEL_MACH depends on X86_INTEL_LPSS && GPIOLIB && I2C - depends on DMADEVICES depends on SND_SOC_INTEL_HASWELL select SND_SOC_RT5677 help @@ -43,7 +41,6 @@ config SND_SOC_INTEL_BROADWELL_MACH tristate "ASoC Audio DSP support for Intel Broadwell Wildcatpoint" depends on SND_SOC_INTEL_MACH depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM - depends on DMADEVICES depends on SND_SOC_INTEL_HASWELL select SND_SOC_RT286 help @@ -56,7 +53,6 @@ config SND_SOC_INTEL_BYT_MAX98090_MACH tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec" depends on SND_SOC_INTEL_MACH depends on X86_INTEL_LPSS && I2C - depends on DMADEVICES depends on SND_SST_IPC_ACPI = n depends on SND_SOC_INTEL_BAYTRAIL select SND_SOC_MAX98090 @@ -68,7 +64,6 @@ config SND_SOC_INTEL_BYT_RT5640_MACH tristate "ASoC Audio driver for Intel Baytrail with RT5640 codec" depends on SND_SOC_INTEL_MACH depends on X86_INTEL_LPSS && I2C - depends on DMADEVICES depends on SND_SST_IPC_ACPI = n depends on SND_SOC_INTEL_BAYTRAIL select SND_SOC_RT5640