[v2] ASoC: amd: yc: Fix non-functional mic on ASUS M7600RE

Commit Message

M Cooley March 8, 2024, 10:35 p.m. UTC

On Fri, Mar 8, 2024 at 4:37 PM Mark Brown <[e-mail]> wrote:
>
> It's a patch whatever the reason for it - basically your email looks
> like it got almost everything right (assuming git am likes it), you just
> need to delete the process question above from the changelog and add a
> Signed-off-by as covered in submitting-patches.rst.  As that covers
> there's legal stuff with the signoff which means I shouldn't take a
> patch without it.

The ASUS M7600RE (Vivobook Pro 16X OLED) needs a quirks-table entry for the
internal microphone to function properly.

Signed-off-by: Mitch Cooley <[e-mail]>
---
--

Comments

Mark Brown March 11, 2024, 3:40 p.m. UTC | #1

On Fri, Mar 08, 2024 at 05:35:40PM -0500, M Cooley wrote:
> On Fri, Mar 8, 2024 at 4:37 PM Mark Brown <[e-mail]> wrote:
> >
> > It's a patch whatever the reason for it - basically your email looks
> > like it got almost everything right (assuming git am likes it), you just
> > need to delete the process question above from the changelog and add a
> > Signed-off-by as covered in submitting-patches.rst.  As that covers
> > there's legal stuff with the signoff which means I shouldn't take a
> > patch without it.

You shouldn't include this quote here, just send the patch independently
as a new thread.

>                 }
>         },
> + {
> +         .driver_data = &acp6x_card,
> +         .matches = {
> +                 DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> +                 DMI_MATCH(DMI_PRODUCT_NAME, "M7600RE"),
> +         }
> + },
>         {

This is mangled and won't apply, there's a level of identation missing
and it seems like tabs have been translated into spaces.

Mark Brown March 11, 2024, 4:50 p.m. UTC | #2

On Fri, 08 Mar 2024 17:35:40 -0500, M Cooley wrote:
> On Fri, Mar 8, 2024 at 4:37 PM Mark Brown <[e-mail]> wrote:
> >
> > It's a patch whatever the reason for it - basically your email looks
> > like it got almost everything right (assuming git am likes it), you just
> > need to delete the process question above from the changelog and add a
> > Signed-off-by as covered in submitting-patches.rst.  As that covers
> > there's legal stuff with the signoff which means I shouldn't take a
> > patch without it.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: yc: Fix non-functional mic on ASUS M7600RE
      commit: db185362fca554b201e2c62beb15a02bb39a064b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Patch

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index abb9589b8477..af90da8646ba 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -311,6 +311,13 @@  static const struct dmi_system_id yc_acp_quirk_table[] = {
                        DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"),
                }
        },
+ {
+         .driver_data = &acp6x_card,
+         .matches = {
+                 DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+                 DMI_MATCH(DMI_PRODUCT_NAME, "M7600RE"),
+         }
+ },
        {
                .driver_data = &acp6x_card,
                .matches = {