diff mbox

ALSA: line6: Use correct endpoint type for midi output

Message ID CAN0YATNkVQM_4NgLCWiVGmH9y0jiRrBEx+n8H7hWDFPXqxe_ow@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabián Inostroza April 12, 2018, 3:37 a.m. UTC
Hi,

Sending MIDI messages to a PODxt through the USB connection shows
"usb_submit_urb failed" in dmesg and the message is not received by
the POD.

The error is caused because in the funcion send_midi_async() in midi.c
there is a call to usb_sndbulkpipe() for endpoint 3 OUT, but the PODxt
USB descriptor shows that this endpoint it's an interrupt endpoint.

Patch tested with PODxt only.

Signed-off-by: Fabián Inostroza <fabianinostroza@udec.cl>
---
 sound/usb/line6/midi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

              line6->interval);

Comments

Takashi Iwai April 12, 2018, 6:42 a.m. UTC | #1
On Thu, 12 Apr 2018 05:37:35 +0200,
Fabián Inostroza wrote:
> 
> Hi,
> 
> Sending MIDI messages to a PODxt through the USB connection shows
> "usb_submit_urb failed" in dmesg and the message is not received by
> the POD.
> 
> The error is caused because in the funcion send_midi_async() in midi.c
> there is a call to usb_sndbulkpipe() for endpoint 3 OUT, but the PODxt
> USB descriptor shows that this endpoint it's an interrupt endpoint.
> 
> Patch tested with PODxt only.
> 
> Signed-off-by: Fabián Inostroza <fabianinostroza@udec.cl>

Applied now.  Thanks!


Takashi
diff mbox

Patch

diff --git a/sound/usb/line6/midi.c b/sound/usb/line6/midi.c
index 6d7cde56..e2cf55c5 100644
--- a/sound/usb/line6/midi.c
+++ b/sound/usb/line6/midi.c
@@ -125,7 +125,7 @@  static int send_midi_async(struct usb_line6
*line6, unsigned char *data,
     }

     usb_fill_int_urb(urb, line6->usbdev,
-             usb_sndbulkpipe(line6->usbdev,
+             usb_sndintpipe(line6->usbdev,
                      line6->properties->ep_ctrl_w),
              transfer_buffer, length, midi_sent, line6,