From patchwork Thu Apr 12 03:37:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Fabi=C3=A1n_Inostroza?= X-Patchwork-Id: 10337783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9C4D2603B5 for ; Thu, 12 Apr 2018 03:37:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8BEFF27F92 for ; Thu, 12 Apr 2018 03:37:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 80DB028047; Thu, 12 Apr 2018 03:37:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60CB727FE4 for ; Thu, 12 Apr 2018 03:37:46 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 15D5E267356; Thu, 12 Apr 2018 05:37:44 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 750B526735E; Thu, 12 Apr 2018 05:37:41 +0200 (CEST) Received: from mail-it0-f65.google.com (mail-it0-f65.google.com [209.85.214.65]) by alsa0.perex.cz (Postfix) with ESMTP id 5236726718D for ; Thu, 12 Apr 2018 05:37:37 +0200 (CEST) Received: by mail-it0-f65.google.com with SMTP id m134-v6so5553861itb.3 for ; Wed, 11 Apr 2018 20:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=ljN6dS5a4SaR4BUpcm357ee4F5IZCHgkWSRty/Vin5Q=; b=ersBgHYWXN2woJytUD+qapwC/7gvsK0sNmIOQq6G5ve+rRIpBsljMkTUe0j1MJ+oTW hoF2QplQIBmxyzkujG5DFJH0OArgK5WWSaRD74nsxlN5hu4AZxOcsgA6o/PeD8yQYyy8 3nJh5r5CRmSmtZ26ZDdUJ5WryESHtPAetaBYwrW6NSZziv9vBe0KvbfrYBlp1qARboeS epp+kqgaGNC6ObBg3TaWFvMqDiivbajk5iNkx1KUKR4iQ68bfVju12j/ytxnLN/yguHW p1ZCy5+aO+CUdabjH18QjsCQmeGUGIcWQO48yRrD6Wg3brUB4Bua0rUYly5iUiQ8ht3J s/Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=ljN6dS5a4SaR4BUpcm357ee4F5IZCHgkWSRty/Vin5Q=; b=LQW27L+QiD8eosvpTqE9UhzOY9hTsMKiDed2kXnSjFQOyBWLeZw4oC7PiiL8BfZmHK 4dfuP1TU5e56lr183UM1928OnUaVy2TQnFWfkyy1w7/UgNLiQ+OKmofx+OMt+ey+I742 mXbeYQ+7PCMuBkd4db9QSjAufPVIWwsI9wOwWNhZItAsKlasbIIFcZJE/yYe3u62A0XA xpdvI6GzT9xST3qWpa5Tutjgkq1Q8wJYziDJiSOKsIpiH4Cj9EzyWuD39OgoZuubeplx 0hkrtbLiVSLyQG9DAtnFw/HCiwxt/8Fy+t2hrJ/Om3S5xS+GJSErigdTTUps2AZqIZPl Oo2Q== X-Gm-Message-State: ALQs6tBK7s24reeqUHBsT5iCgzS/+XEYzMSYozPwhgQhPMY89uPuTRc/ 0vdalpnbP+77LugbwT8IpTXnlGmcHN+Q+p3ktolIX3dx X-Google-Smtp-Source: AIpwx48a9Slry0LrUO8TdbfOBT7e4qDNIMk3c6AAOZIfDrGlml4vF3NzEB9sChATf/cjTCuQXgh8gg8gwtMEBEUQxY8= X-Received: by 2002:a24:6c0f:: with SMTP id w15-v6mr6380488itb.29.1523504256236; Wed, 11 Apr 2018 20:37:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.64.214 with HTTP; Wed, 11 Apr 2018 20:37:35 -0700 (PDT) From: =?UTF-8?Q?Fabi=C3=A1n_Inostroza?= Date: Thu, 12 Apr 2018 00:37:35 -0300 Message-ID: To: alsa-devel@alsa-project.org Subject: [alsa-devel] [PATCH] ALSA: line6: Use correct endpoint type for midi output X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Sending MIDI messages to a PODxt through the USB connection shows "usb_submit_urb failed" in dmesg and the message is not received by the POD. The error is caused because in the funcion send_midi_async() in midi.c there is a call to usb_sndbulkpipe() for endpoint 3 OUT, but the PODxt USB descriptor shows that this endpoint it's an interrupt endpoint. Patch tested with PODxt only. Signed-off-by: Fabián Inostroza --- sound/usb/line6/midi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) line6->interval); diff --git a/sound/usb/line6/midi.c b/sound/usb/line6/midi.c index 6d7cde56..e2cf55c5 100644 --- a/sound/usb/line6/midi.c +++ b/sound/usb/line6/midi.c @@ -125,7 +125,7 @@ static int send_midi_async(struct usb_line6 *line6, unsigned char *data, } usb_fill_int_urb(urb, line6->usbdev, - usb_sndbulkpipe(line6->usbdev, + usb_sndintpipe(line6->usbdev, line6->properties->ep_ctrl_w), transfer_buffer, length, midi_sent, line6,