diff mbox

ASoC: fsl: fix dependencies for wm8962

Message ID CAOMZO5B3LztUdafDCo8bzLwbmeBB3N-rpQLxXMvb0pXgtGVugA@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam Sept. 30, 2014, 5:38 p.m. UTC 
On Tue, Sep 30, 2014 at 1:45 PM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Sep 30, 2014 at 01:43:41PM +0200, Arnd Bergmann wrote:
>> The wm8962 driver uses the input subsystem, but is selected by
>> SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled,
>> resulting in this link error:
>
> That select shouldn't be there in the first place, I asked Nicolin to
> fix this when I applied the driver but he's not got round to it yet.

Would the below change be a proper fix?

Comments

Nicolin Chen Sept. 30, 2014, 7:43 p.m. UTC | #1 
On Tue, Sep 30, 2014 at 02:38:49PM -0300, Fabio Estevam wrote:
> On Tue, Sep 30, 2014 at 1:45 PM, Mark Brown <broonie@kernel.org> wrote:
> > That select shouldn't be there in the first place, I asked Nicolin to
> > fix this when I applied the driver but he's not got round to it yet.
> 
> Would the below change be a proper fix?
> 
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index 6164e78..081e406 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig

> -       select SND_SOC_CS42XX8_I2C
> -       select SND_SOC_SGTL5000
> -       select SND_SOC_WM8962

Okay..if Mark means this...I think it makes sense to me now.

But in this case, we shall add them into imx_v6_v7_defconfig instead.

Thank you
Nicolin
Fabio Estevam Sept. 30, 2014, 7:48 p.m. UTC | #2 
On Tue, Sep 30, 2014 at 4:43 PM, Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> On Tue, Sep 30, 2014 at 02:38:49PM -0300, Fabio Estevam wrote:
>> On Tue, Sep 30, 2014 at 1:45 PM, Mark Brown <broonie@kernel.org> wrote:
>> > That select shouldn't be there in the first place, I asked Nicolin to
>> > fix this when I applied the driver but he's not got round to it yet.
>>
>> Would the below change be a proper fix?
>>
>> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
>> index 6164e78..081e406 100644
>> --- a/sound/soc/fsl/Kconfig
>> +++ b/sound/soc/fsl/Kconfig
>
>> -       select SND_SOC_CS42XX8_I2C
>> -       select SND_SOC_SGTL5000
>> -       select SND_SOC_WM8962
>
> Okay..if Mark means this...I think it makes sense to me now.
>
> But in this case, we shall add them into imx_v6_v7_defconfig instead.

We already have
CONFIG_SND_SOC_IMX_WM8962=y
CONFIG_SND_SOC_IMX_SGTL5000=y

in imx_v6_v7_defconfig.
Nicolin Chen Sept. 30, 2014, 8:37 p.m. UTC | #3 
On Tue, Sep 30, 2014 at 04:48:01PM -0300, Fabio Estevam wrote:
> >> -       select SND_SOC_CS42XX8_I2C
> >> -       select SND_SOC_SGTL5000
> >> -       select SND_SOC_WM8962
> >
> > Okay..if Mark means this...I think it makes sense to me now.
> >
> > But in this case, we shall add them into imx_v6_v7_defconfig instead.
> 
> We already have
> CONFIG_SND_SOC_IMX_WM8962=y
> CONFIG_SND_SOC_IMX_SGTL5000=y
> 
> in imx_v6_v7_defconfig.

Yea, and these are two things I plan to drop...

So when enabling the FSL_ASOC_CARD, I also needs to put those three
into it as well.
diff mbox

Patch

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 6164e78..081e406 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -288,9 +288,6 @@  config SND_SOC_FSL_ASOC_CARD
        select SND_SOC_FSL_ESAI
        select SND_SOC_FSL_SAI
        select SND_SOC_FSL_SSI
-       select SND_SOC_CS42XX8_I2C
-       select SND_SOC_SGTL5000
-       select SND_SOC_WM8962
        help
         ALSA SoC Audio support with ASRC feature for Freescale SoCs that have
         ESAI/SAI/SSI and connect with external CODECs such as WM8962, CS42888