From patchwork Mon Jun 2 14:13:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 4282551 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C7670BEEA7 for ; Mon, 2 Jun 2014 14:14:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 02478203E5 for ; Mon, 2 Jun 2014 14:14:03 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 018FB20170 for ; Mon, 2 Jun 2014 14:14:02 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id C693D26553B; Mon, 2 Jun 2014 16:13:55 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id C7618265472; Mon, 2 Jun 2014 16:13:44 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4AE43265519; Mon, 2 Jun 2014 16:13:44 +0200 (CEST) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by alsa0.perex.cz (Postfix) with ESMTP id E94BA2652E7 for ; Mon, 2 Jun 2014 16:13:35 +0200 (CEST) Received: by mail-vc0-f182.google.com with SMTP id id10so5164705vcb.13 for ; Mon, 02 Jun 2014 07:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=vGBSrhTTm2ENWzQit2TAB2UfxvzPNW/E468+WwAeOs8=; b=CX8OYtbRNPwgXd8PicmZQYgCnRpSeYkh9GElDsob7+0DRSwWgmyRnOwydtSZF+a/1l yzgw+KZ8cX96HKyoJ/KRD/isMNRJ/3FV8LdyVWky/gZubmNBK0RNglmGn5MiL0Ek6OjY CHdYa9ktrbWbLa9+j/YmsDOr7C0ehuwgogOOzBukjdbJm6qCslAYPSrCb3jW+0wv0Xnd JdJXjLp9/hwilr61eEJ50ufabXXAL+fqhJ0APG7Yahmdyx6dA4sGhTv23XKhlz6bfLlI S2IsdILJmW3rhYczw9Q7J9w+kzqA3dXLUxfl0Vx21yW+V+CvlupdisgRGCf1QP4iGOgS gRqg== MIME-Version: 1.0 X-Received: by 10.52.147.9 with SMTP id tg9mr579746vdb.76.1401718414122; Mon, 02 Jun 2014 07:13:34 -0700 (PDT) Received: by 10.58.19.102 with HTTP; Mon, 2 Jun 2014 07:13:34 -0700 (PDT) In-Reply-To: <538C85C3.5020808@metafoo.de> References: <538C840A.2000307@linux.intel.com> <538C85C3.5020808@metafoo.de> Date: Mon, 2 Jun 2014 11:13:34 -0300 Message-ID: From: Fabio Estevam To: Lars-Peter Clausen Cc: "alsa-devel@alsa-project.org" , Mark Brown , Jarkko Nikula Subject: Re: [alsa-devel] Failed to set cache compression type X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jun 2, 2014 at 11:10 AM, Lars-Peter Clausen wrote: > I think snd_soc_cache_init() should return 0 rather than -EINVAL if reg_size > is 0. Yes, this fixes the issue: Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel --- a/sound/soc/soc-cache.c +++ b/sound/soc/soc-cache.c @@ -73,7 +73,7 @@ int snd_soc_cache_init(struct snd_soc_codec *codec) reg_size = codec_drv->reg_cache_size * codec_drv->reg_word_size; if (!reg_size) - return -EINVAL; + return 0; mutex_init(&codec->cache_rw_mutex); _______________________________________________