| Message ID | SL2P216MB23377A60BEC4396ADFA78A6A8C512@SL2P216MB2337.KORP216.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add a driver for the Iron Device SMA1307 Amp | expand |
On Mon, Nov 04, 2024 at 07:33:47AM +0000, Ki-Seok Jo wrote: > I don't see the rest of the series (I fetch from lore). That means your threading is broken. > This adds the schema binding for the Iron Device SMA1307 Amp > > Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> > --- v3, but where is the revision history? > .../bindings/sound/irondevice,sma1307.yaml | 54 ++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml > new file mode 100644 > index 000000000..0bb4ee664 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 "%YAML 1.2" goes on the 2nd line. > +--- > +$id: http://devicetree.org/schemas/sound/irondevice,sma1307.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Iron Device SMA1307 Audio Amplifier > + > +maintainers: > + - Kiseok Jo <kiseok.jo@irondevice.com> > + > +description: > + SMA1307 boosted digital speaker amplifier > + with feedback-loop. Wrap lines at 80 char. > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + enum: > + - irondevice,sma1307a > + - irondevice,sma1307aq > + description: > + If a 'q' is added, it indicated the product is AEC-Q100 > + qualified for automotive applications. SMA1307A supports > + both WLCSP and QFN packages. However, SMA1307AQ only > + supports the QFN package. Is this difference visible to software? The package is not, so that part is irrelevant. > + > + reg: > + maxItems: 1 > + > + '#sound-dai-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - '#sound-dai-cells' > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + amplifier@1e { > + compatible = "irondevice,sma1307a"; > + reg = <0x1e>; > + #sound-dai-cells = <1>; > + }; > + }; > > -- > 2.39.2 >
On Mon, Nov 04, 2024 at 10:17:51AM -0600, Rob Herring wrote: > On Mon, Nov 04, 2024 at 07:33:47AM +0000, Ki-Seok Jo wrote: > > + enum: > > + - irondevice,sma1307a > > + - irondevice,sma1307aq > > + description: > > + If a 'q' is added, it indicated the product is AEC-Q100 > > + qualified for automotive applications. SMA1307A supports > > + both WLCSP and QFN packages. However, SMA1307AQ only > > + supports the QFN package. > Is this difference visible to software? The package is not, so that part > is irrelevant. It seems reasonable to allow it as a compatible if it's sold as a separate part, even if we don't need to care.
> > On Mon, Nov 04, 2024 at 07:33:47AM +0000, Ki-Seok Jo wrote: > > > > I don't see the rest of the series (I fetch from lore). That means your > threading is broken. Okay, I see. It appears that using the b4 tool this time may have caused some issues, resulting in the removal of previous content. I would appreciate any suggestions you might have for reconnecting the series. Thank you! > > > This adds the schema binding for the Iron Device SMA1307 Amp > > > > Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> > > --- > > v3, but where is the revision history? Yes, that sounds good. Thank you! There are changes before v2, but there are no changes in this section when transitioning to v3, so I didn't include anything. Would it be better to add the previous changes and indicate that there are no changes when moving to v3? Thank you for your help! I'll reflect on the points you've mentioned and update it to v4. If I download the source again, make the necessary modifications, and then just change the version to v4 before sending it, could that cause the threading to break again?
diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml new file mode 100644 index 000000000..0bb4ee664 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/irondevice,sma1307.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Iron Device SMA1307 Audio Amplifier + +maintainers: + - Kiseok Jo <kiseok.jo@irondevice.com> + +description: + SMA1307 boosted digital speaker amplifier + with feedback-loop. + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + enum: + - irondevice,sma1307a + - irondevice,sma1307aq + description: + If a 'q' is added, it indicated the product is AEC-Q100 + qualified for automotive applications. SMA1307A supports + both WLCSP and QFN packages. However, SMA1307AQ only + supports the QFN package. + + reg: + maxItems: 1 + + '#sound-dai-cells': + const: 1 + +required: + - compatible + - reg + - '#sound-dai-cells' + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + amplifier@1e { + compatible = "irondevice,sma1307a"; + reg = <0x1e>; + #sound-dai-cells = <1>; + }; + };
This adds the schema binding for the Iron Device SMA1307 Amp Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> --- .../bindings/sound/irondevice,sma1307.yaml | 54 ++++++++++++++++++++++ 1 file changed, 54 insertions(+) -- 2.39.2