| Message ID | YqmWIK8sTj578OJP@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 427eb3e1ed530792231bc5bbee6dec99fc57aeb7 |
| Headers | show |
| Series | ASoC: SOF: mediatek: Fix error code in probe | expand |
Hi Dan, On Wed, 2022-06-15 at 11:19 +0300, Dan Carpenter wrote: > This should return PTR_ERR() instead of IS_ERR(). > > Fixes: e0100bfd383c ("ASoC: SOF: mediatek: Add mt8186 ipc support") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > sound/soc/sof/mediatek/mt8186/mt8186.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c > index 3333a0634e29..e006532caf2f 100644 > --- a/sound/soc/sof/mediatek/mt8186/mt8186.c > +++ b/sound/soc/sof/mediatek/mt8186/mt8186.c > @@ -392,7 +392,7 @@ static int mt8186_dsp_probe(struct snd_sof_dev *sdev) > PLATFORM_DEVID_NONE, > pdev, sizeof(*pdev)); > if (IS_ERR(priv->ipc_dev)) { > - ret = IS_ERR(priv->ipc_dev); > + ret = PTR_ERR(priv->ipc_dev); > dev_err(sdev->dev, "failed to create mtk-adsp-ipc device\n"); > goto err_adsp_off; > } Thank you for finding this bug. Best regards, TingHan
On 6/15/22 03:19, Dan Carpenter wrote: > This should return PTR_ERR() instead of IS_ERR(). > > Fixes: e0100bfd383c ("ASoC: SOF: mediatek: Add mt8186 ipc support") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Nice catch, thanks! Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > sound/soc/sof/mediatek/mt8186/mt8186.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c > index 3333a0634e29..e006532caf2f 100644 > --- a/sound/soc/sof/mediatek/mt8186/mt8186.c > +++ b/sound/soc/sof/mediatek/mt8186/mt8186.c > @@ -392,7 +392,7 @@ static int mt8186_dsp_probe(struct snd_sof_dev *sdev) > PLATFORM_DEVID_NONE, > pdev, sizeof(*pdev)); > if (IS_ERR(priv->ipc_dev)) { > - ret = IS_ERR(priv->ipc_dev); > + ret = PTR_ERR(priv->ipc_dev); > dev_err(sdev->dev, "failed to create mtk-adsp-ipc device\n"); > goto err_adsp_off; > }
On 15/06/2022 11:19, Dan Carpenter wrote: > This should return PTR_ERR() instead of IS_ERR(). Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> > Fixes: e0100bfd383c ("ASoC: SOF: mediatek: Add mt8186 ipc support") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > sound/soc/sof/mediatek/mt8186/mt8186.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c > index 3333a0634e29..e006532caf2f 100644 > --- a/sound/soc/sof/mediatek/mt8186/mt8186.c > +++ b/sound/soc/sof/mediatek/mt8186/mt8186.c > @@ -392,7 +392,7 @@ static int mt8186_dsp_probe(struct snd_sof_dev *sdev) > PLATFORM_DEVID_NONE, > pdev, sizeof(*pdev)); > if (IS_ERR(priv->ipc_dev)) { > - ret = IS_ERR(priv->ipc_dev); > + ret = PTR_ERR(priv->ipc_dev); > dev_err(sdev->dev, "failed to create mtk-adsp-ipc device\n"); > goto err_adsp_off; > }
On Wed, 15 Jun 2022 11:19:44 +0300, Dan Carpenter wrote: > This should return PTR_ERR() instead of IS_ERR(). > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: mediatek: Fix error code in probe commit: 62257638170eee07926c9df5a4c9059ec69a3734 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c index 3333a0634e29..e006532caf2f 100644 --- a/sound/soc/sof/mediatek/mt8186/mt8186.c +++ b/sound/soc/sof/mediatek/mt8186/mt8186.c @@ -392,7 +392,7 @@ static int mt8186_dsp_probe(struct snd_sof_dev *sdev) PLATFORM_DEVID_NONE, pdev, sizeof(*pdev)); if (IS_ERR(priv->ipc_dev)) { - ret = IS_ERR(priv->ipc_dev); + ret = PTR_ERR(priv->ipc_dev); dev_err(sdev->dev, "failed to create mtk-adsp-ipc device\n"); goto err_adsp_off; }
This should return PTR_ERR() instead of IS_ERR(). Fixes: e0100bfd383c ("ASoC: SOF: mediatek: Add mt8186 ipc support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- sound/soc/sof/mediatek/mt8186/mt8186.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)