| Message ID | Ys2IRPHWGIwuVs21@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 73acfba792b06156b7c805162fcd89fdb71646f9 |
| Headers | show |
| Series | ASoC: amd: Fix error pointer dereference | expand |
On Tue, 12 Jul 2022 17:42:12 +0300, Dan Carpenter wrote: > The "gpio_pa" pointer is an error pointer, there is no need to try > put it. Calling gpiod_put() on it will lead to an error pointer > dereference. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: amd: Fix error pointer dereference commit: 73acfba792b06156b7c805162fcd89fdb71646f9 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/amd/acp-es8336.c b/sound/soc/amd/acp-es8336.c index d501618b78f6..2fe8df86053a 100644 --- a/sound/soc/amd/acp-es8336.c +++ b/sound/soc/amd/acp-es8336.c @@ -212,7 +212,6 @@ static int st_es8336_late_probe(struct snd_soc_card *card) if (IS_ERR(gpio_pa)) { ret = dev_err_probe(card->dev, PTR_ERR(gpio_pa), "could not get pa-enable GPIO\n"); - gpiod_put(gpio_pa); put_device(codec_dev); return ret; }
The "gpio_pa" pointer is an error pointer, there is no need to try put it. Calling gpiod_put() on it will lead to an error pointer dereference. Fixes: 02527c3f2300 ("ASoC: amd: add Machine driver for Jadeite platform") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- sound/soc/amd/acp-es8336.c | 1 - 1 file changed, 1 deletion(-)