| Message ID | Yv8ePUuBfzaRu6xV@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a74ec0bf5b67eae87317646571116ce4b4166d95 |
| Headers | show |
| Series | ASoC: amd: acp: remove unnecessary NULL checks | expand |
On Fri, 19 Aug 2022 08:23:09 +0300, Dan Carpenter wrote: > The list iterator can never be NULL. Delete the bogus NULL checks. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: amd: acp: remove unnecessary NULL checks commit: a74ec0bf5b67eae87317646571116ce4b4166d95 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c index beee53aedeaf..85a81add4ef9 100644 --- a/sound/soc/amd/acp/acp-platform.c +++ b/sound/soc/amd/acp/acp-platform.c @@ -106,14 +106,14 @@ static irqreturn_t i2s_irq_handler(int irq, void *data) spin_lock(&adata->acp_lock); list_for_each_entry(stream, &adata->stream_list, list) { - if (stream && (ext_intr_stat & stream->irq_bit)) { + if (ext_intr_stat & stream->irq_bit) { writel(stream->irq_bit, ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used)); snd_pcm_period_elapsed(stream->substream); i2s_flag = 1; } if (adata->rsrc->no_of_ctrls == 2) { - if (stream && (ext_intr_stat1 & stream->irq_bit)) { + if (ext_intr_stat1 & stream->irq_bit) { writel(stream->irq_bit, ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1))); snd_pcm_period_elapsed(stream->substream);
The list iterator can never be NULL. Delete the bogus NULL checks. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- sound/soc/amd/acp/acp-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)