From patchwork Thu Jul 25 11:08:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylvain BERTRAND X-Patchwork-Id: 13748275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09399C3DA7F for ; Wed, 31 Jul 2024 08:47:08 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C89372319; Wed, 31 Jul 2024 10:46:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C89372319 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722415618; bh=J0UpM5Bj3eNkwzorIQa07O7OnSNlm4+XiTCMxbvKN5Y=; h=Date:From:To:Subject:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=o3E0mPFBseUHbOWnyU+b5w9aO7z7q8ijHKE4fXiW1Gu7gAkNCZC0QgKOZuTfQzPeZ vGJPk/Qxg8akiX+QG2ERPlCsVnBn49rEM9R4sZx2VJLNn0Cz3Mbc1NGAmr3USW3H9q M6Wm2AonA9lFysHe3pd8GOsJWxXJ3xVP/XbGjG98= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 71A4BF805AB; Wed, 31 Jul 2024 10:46:07 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 4A30CF802DB; Wed, 31 Jul 2024 10:46:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EB366F8026D; Thu, 25 Jul 2024 13:32:08 +0200 (CEST) Received: from legeek.net (unknown [IPv6:2a01:e0a:d77:fcd0:ba27:ebff:fe50:cb42]) by alsa1.perex.cz (Postfix) with ESMTP id 3B74CF8007E for ; Thu, 25 Jul 2024 13:32:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3B74CF8007E Date: Thu, 25 Jul 2024 11:08:20 +0000 From: Sylvain BERTRAND To: alsa-devel@alsa-project.org Subject: [PATCH][LINUX][ALSA][USB AUDIO CLASS 1] wrong channel ids for surround Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-MailFrom: sylvain.bertrand@legeek.net X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: CIU7WSMS4BMIOLYXI5GP4OOWPSGCUT4W X-Message-ID-Hash: CIU7WSMS4BMIOLYXI5GP4OOWPSGCUT4W X-Mailman-Approved-At: Wed, 31 Jul 2024 08:46:02 +0000 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, In the USB audio class 1 specifications, page 33 (3.7.2.3 Audio Channel Cluster Format): Surround is spatially defined as [rear], hence left surround should be SNDRV_CHMAP_RL and not SND_CHMAP_SL (Side). Same for right surround channel. Right? I am not a mailing list subscriber, CC me please. regards, --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -244,8 +244,8 @@ static struct snd_pcm_chmap_elem *convert_chmap(int channels, unsigned int bits, SNDRV_CHMAP_FR, /* right front */ SNDRV_CHMAP_FC, /* center front */ SNDRV_CHMAP_LFE, /* LFE */ - SNDRV_CHMAP_SL, /* left surround */ - SNDRV_CHMAP_SR, /* right surround */ + SNDRV_CHMAP_RL, /* left surround */ + SNDRV_CHMAP_RR, /* right surround */ SNDRV_CHMAP_FLC, /* left of center */ SNDRV_CHMAP_FRC, /* right of center */ SNDRV_CHMAP_RC, /* surround */