From patchwork Sat Aug 12 19:13:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9897465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2656860325 for ; Sat, 12 Aug 2017 19:14:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16DF4286F9 for ; Sat, 12 Aug 2017 19:14:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 08C4628782; Sat, 12 Aug 2017 19:14:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6F17286F9 for ; Sat, 12 Aug 2017 19:13:59 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id C30FD2670A8; Sat, 12 Aug 2017 21:13:58 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 216A82670E0; Sat, 12 Aug 2017 21:13:57 +0200 (CEST) Received: from mout.web.de (mout.web.de [217.72.192.78]) by alsa0.perex.cz (Postfix) with ESMTP id 676AD2670A8 for ; Sat, 12 Aug 2017 21:13:55 +0200 (CEST) Received: from [192.168.1.2] ([77.181.183.107]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MMn1H-1dgsRE1hd9-008Z8p; Sat, 12 Aug 2017 21:13:51 +0200 From: SF Markus Elfring To: alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Takashi Sakamoto References: <47947226-bd09-5d15-c0d2-a9f4a659e1b4@users.sourceforge.net> Message-ID: Date: Sat, 12 Aug 2017 21:13:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <47947226-bd09-5d15-c0d2-a9f4a659e1b4@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:FYc/9o9gpKXtoj9zXeEtwxB2XkHgKW1NR3emL0DiPq/OmIwwiic 8U8D+q+QUdTS9ler+OD0jLZkgkQ1H+H018ui0z7AtSM0/Nt9XT6D2DtP8A0APKuIvtuH+VC FMeSm8gnPZlJAcG7idIhGwOmZP3p6cMdzfc0tF9INOW+TcKxRZYEcpQceFTJFSqzp7o3vxf uJuty0TEmwXSToXQ6jEGQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:bpADMfWqyqc=:FGFlqPdH+BBUrzE2HSrHCq noqlbejz8xcJHL9wLOGS4sxnurkyoCvR+NbQ+LX8BP3fVLJ7n5/+e57jbpJJgAkxFAF+ZbCZ/ 1q8LN2TCC1NaLyHQ+c9DKOyRykqk8GOG7wWlzOJTG86e3QGcUFEd7E+BrCGKIfvBCmRRiE3KB prfC7i76aBzGkmrRwu85/O8yD0gcwFJ05l5sO2RH0DiWbcRYuzscLGDhfmESRJIQFomQYBoAS FysjdEpm5Mv/p5vEc8DxpFuaPLjn6N2sx0yLOu3tLprBZYdERwFnIoZax+fQSNZcCxaFnyKO5 04U8HEBKI2BVF3wfhzSgLLTZRxT2YSsD7Q+sAQD5/zoEduwozkKfim0oNXI1FSuelDmtooAOc aXrIWUhx5lBJ9IYP77VitckVL4rdqsxUvZptxbolCN9ldUnsgFYHF5ErUfSKLXu4euLRbE3dF /XPW+JBbaUG7qFMqyTOI8nOKnH6UkBklLpgQqiS2T4rLBdy5Ag7lJRytJMzNHnGPHVeZJlOCQ cGNjpxZymsPOe/eQVzOBXoEIpsw+8PPt5oE/3RninKlM6bc/Uj599X8v+YlFurhoPL2MtIrVv RPul+Ute1n8/vZVHGxsKiIFHAvcmvsNTlcAlhqBiHOpUjrk1HXO8jcl5s7OPpWZrbVQM4+TB9 qqod5wrLqdITYg3vFiLG84vgVSJLnX1Ae8rr79qMJdfMuIepS/+qQuwgIFIxv/byhyzUY8ovv bJW/9S/T2ESQ4Me+R5kY1/Q4+mJUmI6VDV8aIiP6Crm/zyjmGoPl5+/1RaPu+05e73cZjAPbr bbhagVRqJRBBJ34+hOIUZc5/dq3y0hNOpb4fTFjNH9FU/VO/N4= Cc: kernel-janitors@vger.kernel.org, LKML Subject: [alsa-devel] [PATCH 3/3] ALSA: mpu401: Adjust four checks for null pointers X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 12 Aug 2017 20:50:16 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- sound/drivers/mpu401/mpu401_uart.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/drivers/mpu401/mpu401_uart.c b/sound/drivers/mpu401/mpu401_uart.c index e8bdea193eab..b997222274bd 100644 --- a/sound/drivers/mpu401/mpu401_uart.c +++ b/sound/drivers/mpu401/mpu401_uart.c @@ -136,7 +136,7 @@ irqreturn_t snd_mpu401_uart_interrupt(int irq, void *dev_id) { struct snd_mpu401 *mpu = dev_id; - if (mpu == NULL) + if (!mpu) return IRQ_NONE; _snd_mpu401_uart_interrupt(mpu); return IRQ_HANDLED; @@ -157,7 +157,7 @@ irqreturn_t snd_mpu401_uart_interrupt_tx(int irq, void *dev_id) { struct snd_mpu401 *mpu = dev_id; - if (mpu == NULL) + if (!mpu) return IRQ_NONE; uart_interrupt_tx(mpu); return IRQ_HANDLED; @@ -544,7 +544,7 @@ int snd_mpu401_uart_new(struct snd_card *card, int device, out_enable, in_enable, &rmidi)) < 0) return err; mpu = kzalloc(sizeof(*mpu), GFP_KERNEL); - if (mpu == NULL) { + if (!mpu) { err = -ENOMEM; goto free_device; } @@ -558,7 +558,7 @@ int snd_mpu401_uart_new(struct snd_card *card, int device, if (! (info_flags & MPU401_INFO_INTEGRATED)) { int res_size = hardware == MPU401_HW_PC98II ? 4 : 2; mpu->res = request_region(port, res_size, "MPU401 UART"); - if (mpu->res == NULL) { + if (!mpu->res) { snd_printk(KERN_ERR "mpu401_uart: " "unable to grab port 0x%lx size %d\n", port, res_size);