From patchwork Wed May 16 04:42:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 10402523 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E4BD9602C2 for ; Wed, 16 May 2018 04:42:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D3BB62872D for ; Wed, 16 May 2018 04:42:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C86062873C; Wed, 16 May 2018 04:42:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 25EFB2872D for ; Wed, 16 May 2018 04:42:48 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 0169E26707F; Wed, 16 May 2018 06:42:45 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 56A1C267265; Wed, 16 May 2018 06:42:41 +0200 (CEST) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by alsa0.perex.cz (Postfix) with ESMTP id E725D266DF0 for ; Wed, 16 May 2018 06:42:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-ID:Cc:Subject:From:To:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NQhVP1lWuujF+8sseF6NYsJmf+bbzrDPp4yH/TugnYw=; b=Cjn15B5dmKvrfWtWG8CRZIINi yoRKzwzYactIxcwrIBS0879sxJqu6Q7pj+uTw/Z8KgSFVSC2jDIWH4v08xcceyQ7Aw8XoFVSm7Wpx vbhZu7WHaFAOxJva7kj5EadATEdK3iNeJrQmTsgW/fSdYEwszQcq5yEI03ljrkb2Wq1QWAyJQXp9A ffNPVxiysPnYjvesD37Kw6CL9IsoeaFx5QfztgQIW9Xcu0gbN0vWvt3DNzGPOUiiwY4xZPDXzKH0S rF9W9/cjHCOfZmy4e1gKuGsJHJB+BYby6BjYmICrW9uiKeEm2kG25onlixP4jZt8RVcvOjPvAGOAL YNaMGhasg==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIoGl-0004sc-0K; Wed, 16 May 2018 04:42:31 +0000 To: moderated for non-subscribers From: Randy Dunlap Message-ID: Date: Tue, 15 May 2018 21:42:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Language: en-US Cc: kbuild test robot , LKML , Liam Girdwood , Mark Brown , Andrew Morton , =?UTF-8?Q?Myl=c3=a8ne_Josserand?= Subject: [alsa-devel] [PATCH] ASoC: codecs: fix pcm1789.c build errors X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap Fix build errors in pcm1789.c. The source file needs to #include since it uses interfaces and macros that are provided by it. However, it does not need to #include , so drop it. Fixes these build errors: ../sound/soc/codecs/pcm1789.c: In function 'pcm1789_common_init': ../sound/soc/codecs/pcm1789.c:247:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration] pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); ../sound/soc/codecs/pcm1789.c:247:57: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function) pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); ../sound/soc/codecs/pcm1789.c:251:2: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration] gpiod_set_value_cansleep(pcm1789->reset, 0); Fixes: 4ae340d1be36 ("ASoC: codecs: Add support for PCM1789") Reported-by: kbuild test robot Signed-off-by: Randy Dunlap Cc: Mylène Josserand Cc: Liam Girdwood Cc: Mark Brown Cc: alsa-devel@alsa-project.org --- sound/soc/codecs/pcm1789.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) BTW, MODULE_AUTHOR() still uses @free-electrons.com. --- lnx-417-rc4.orig/sound/soc/codecs/pcm1789.c +++ lnx-417-rc4/sound/soc/codecs/pcm1789.c @@ -3,7 +3,7 @@ // Copyright (C) 2018 Bootlin // Mylène Josserand -#include +#include #include #include