From patchwork Fri Sep 25 16:41:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 7266521 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 773099F30C for ; Fri, 25 Sep 2015 16:42:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 954AE2093F for ; Fri, 25 Sep 2015 16:42:26 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 6C35E20936 for ; Fri, 25 Sep 2015 16:42:25 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4C2F626645E; Fri, 25 Sep 2015 18:42:24 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id EE94B260682; Fri, 25 Sep 2015 18:42:16 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 37FB82614A1; Fri, 25 Sep 2015 18:42:15 +0200 (CEST) Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by alsa0.perex.cz (Postfix) with ESMTP id D61EB26064C for ; Fri, 25 Sep 2015 18:42:07 +0200 (CEST) Received: by padhy16 with SMTP id hy16so110400442pad.1 for ; Fri, 25 Sep 2015 09:42:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Lip0XQpIhzfkEtjTNizVw4b9OMx/IlPdPwC9RW55Nf4=; b=goJmghuZZJjzO4NZQn29AfW51WIr0lvSOv1GfKI9jfA0b+WSUIAE1JYASDWyZUwtpr 6UsqthLV1Yt91a3exYd/97L/byoPG3DGGGpdbHA3x2TqWy6qLp9zsiLZZ6iI+zY3E3Pv t3ABvV0haJkhif9fqmD5lh3afKBDaRvUBCyKOfwFEY+dqbyFSCKImGFa2JH7Dl76SV3+ lx07fvLEsCrGsG8bWb4Oc3W4Yng3KeeiWhM1toZpOE1N7QKY4dx0Sx7SfSOe0gwmfcTr mtsFOlmtyirDxqT16AYdF1HrS3de2mLG4NRqTGH6BnUV0Jb5WGFz5aq2bos0cPT6vpXU Nflw== X-Gm-Message-State: ALoCoQlRlonn11WFaUr+ZGuUJu36oc10KxCBiEiM/GlKz5FoG+25yOgsHKD2FqmgIc9mJUQREUBa X-Received: by 10.69.1.67 with SMTP id be3mr8609738pbd.78.1443199326338; Fri, 25 Sep 2015 09:42:06 -0700 (PDT) Received: from localhost ([70.35.39.2]) by smtp.gmail.com with ESMTPSA id ll9sm4797436pbc.42.2015.09.25.09.42.05 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 25 Sep 2015 09:42:05 -0700 (PDT) From: Viresh Kumar To: Greg Kroah-Hartman Date: Fri, 25 Sep 2015 09:41:37 -0700 Message-Id: X-Mailer: git-send-email 2.4.0 Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org, linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org, Viresh Kumar , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, QCA ath9k Development , linux-kernel@vger.kernel.org, Intel Linux Wireless , linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org Subject: [alsa-devel] [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big endian 64 bit systems. There are no such platforms yet, but the code needs to be robust for such a case. Fix that by passing a local variable to debugfs_create_bool() and assigning its value to global_lock later. Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki --- V3->V4: - Create a local variable instead of changing type of global_lock (Rafael) - Drop the stable tag - BCC'd a lot of people (rather than cc'ing them) to make sure - the series reaches them - mailing lists do not block the patchset due to long cc list - and we don't spam the BCC'd people for every reply --- drivers/acpi/ec_sys.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c index b4c216bab22b..b44b91331a56 100644 --- a/drivers/acpi/ec_sys.c +++ b/drivers/acpi/ec_sys.c @@ -110,6 +110,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) struct dentry *dev_dir; char name[64]; umode_t mode = 0400; + u32 val; if (ec_device_count == 0) { acpi_ec_debugfs_dir = debugfs_create_dir("ec", NULL); @@ -127,10 +128,11 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe)) goto error; - if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, - (u32 *)&first_ec->global_lock)) + if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, &val)) goto error; + first_ec->global_lock = val; + if (write_support) mode = 0600; if (!debugfs_create_file("io", mode, dev_dir, ec, &acpi_ec_io_ops))