From patchwork Fri Aug 11 20:42:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9896513 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 891BC60351 for ; Fri, 11 Aug 2017 20:42:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A49E28CFE for ; Fri, 11 Aug 2017 20:42:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6EB0B28CD8; Fri, 11 Aug 2017 20:42:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA50C28CD8 for ; Fri, 11 Aug 2017 20:42:35 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 956CF2676CC; Fri, 11 Aug 2017 22:42:29 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id F2A542676D1; Fri, 11 Aug 2017 22:42:27 +0200 (CEST) Received: from mout.web.de (mout.web.de [212.227.15.14]) by alsa0.perex.cz (Postfix) with ESMTP id 6441E266D12 for ; Fri, 11 Aug 2017 22:42:26 +0200 (CEST) Received: from [192.168.1.2] ([77.181.164.13]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MKNl8-1dec480Q6g-001jut; Fri, 11 Aug 2017 22:42:22 +0200 From: SF Markus Elfring To: adi-buildroot-devel@lists.sourceforge.net, alsa-devel@alsa-project.org, Jaroslav Kysela , Liam Girdwood , Mark Brown , Scott Jiang , Takashi Iwai References: Message-ID: Date: Fri, 11 Aug 2017 22:42:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:NBPr3iYEyiZFtkVoutjvu/NrqYNKrTk04jHun/q+cIY7IWO/zjk fQ6Yk92vFR0OasY0yP2rbLQbPZYI9Qw79mA3/kXQ4QS675N/pz3YT103NYf3tKyssSbJhyx KFUWSqx7CG+THc5g8Yt5/ag8t4Ptw2Eya2sb7TIW5hH1MaU9TegVN68a4bSmHWB5Bgry+4/ k/oiwsizwLIgoAr8cKeqg== X-UI-Out-Filterresults: notjunk:1; V01:K0:mzu02/q6cMY=:64L04k84lRbPcyexkBdfmY cA4e2lrDKbJbdxdzwURn7CBSHsY+TqL1O1kRhg/aEjvU85FPwpErRbpIfSfggUT9YzyD0jFHG CS/cOLrVRRJzfWR5q2BwIiUsokurdTi14xggpojknhLvxbS+0/XWi/oYbBr2D9LjUG5OM19bf 8vudFNRrjEacDu1nuIUAyccYu479WQnpIE/bH6JPdD/k8r/KiTV/hisYcLlI4g4WFLyvneOR4 o4DN2ek9CalxAwO0eqmulsJQ5wtm/v44EgRn/SkByorLkCG9XuhVVOlol5K+GVaXkJH5NzF3v 1dPb9KkfWmhzVKwYSduB9BQrP/O4kNV44AbP63T6Yy9/+4P9vhmbOZjjsMUGOVAYf66mZ3h7c 5BbcJ1+T9Jzi7uBOuyXvUKcZ4DDObmJ0DEEzBPWLilSaBp1ptTIb8MUyWSlPGR7IX+CJXOAHU Ggm4bYvt6pbMx47apmmJFdjVuTbf0V/nAybP1sUGZALTyUTnmhcdNsbStTjFQydU2Yl5Shk12 C8jA/RkZxeZ+ttp2PeEZirgWjzDUEfN7+RM5QT3RGLlD/M0uG23ijy7Djux6ORFdtt7mq2E7l uyS9tYsJS6xXxyxGfGaZLM0lSQzV2kasWgvlmb/hnjbBvqWykH9iHPuIC68eDoSZ/Exdo2Bub /3bWBYj/451kLerKWH/teZY7YV/2vbBfOQeoxcCvwhxRhFL6nxjUy2MXmxFD4NkArEkQuLdck sYmAeY2DUOqav6nm3XeX0C1qh3OwgaV7s+cVXNcDfz5ZFesQ8t2CaU0+mgL8RcoLlYJ33ER0c HmM2slcHHX8Nck7CkrB+oFsALF8IIg1DMtMDTmW3akDBrWAg2E= Cc: kernel-janitors@vger.kernel.org, LKML Subject: [alsa-devel] [PATCH 2/3] ASoC: blackfin: Use common error handling code in sport_create() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Fri, 11 Aug 2017 22:02:47 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- sound/soc/blackfin/bf6xx-sport.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/soc/blackfin/bf6xx-sport.c b/sound/soc/blackfin/bf6xx-sport.c index 1bc3e0a47a57..fcddebf2558c 100644 --- a/sound/soc/blackfin/bf6xx-sport.c +++ b/sound/soc/blackfin/bf6xx-sport.c @@ -394,19 +394,18 @@ struct sport_device *sport_create(struct platform_device *pdev) sport->pdev = pdev; ret = sport_get_resource(sport); - if (ret) { - kfree(sport); - return NULL; - } + if (ret) + goto free_data; ret = sport_request_resource(sport); - if (ret) { - kfree(sport); - return NULL; - } + if (ret) + goto free_data; dev_dbg(dev, "SPORT create success\n"); return sport; +free_data: + kfree(sport); + return NULL; } EXPORT_SYMBOL(sport_create);