From patchwork Mon Dec 21 15:55:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 7897501 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5CE9D9F349 for ; Mon, 21 Dec 2015 19:05:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9FE46205D3 for ; Mon, 21 Dec 2015 19:05:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 1F63120527 for ; Mon, 21 Dec 2015 19:05:22 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id BB71E265B58; Mon, 21 Dec 2015 20:05:20 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 4075A2651DB; Mon, 21 Dec 2015 20:02:28 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id BEE06261737; Mon, 21 Dec 2015 16:56:19 +0100 (CET) Received: from m50-133.163.com (m50-133.163.com [123.125.50.133]) by alsa0.perex.cz (Postfix) with ESMTP id C8A0E261582 for ; Mon, 21 Dec 2015 16:56:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=U0KOkvA+B14RWP7vKT Yo4brna9B2mZSzJVR66c7k3PY=; b=VPIcStt7rJInpjYYPCQVXUEbCCnGYaCDOK 1UsM7fGiCcCXe/RLeFsL34OcLVCCMoeYrwOKIip2dy1E/4HrOh3VDcGz0KuccB8z ao1SM7xGXM0+HGJ7xTpUDz5DyIcn0JCFsfTEM/aurZN1xT7Uom6qfYkTU+6DoUIA XI0RmsR44= Received: from localhost (unknown [116.77.150.152]) by smtp3 (Coremail) with SMTP id DdGowEDJWEj8IHhWvNZcAA--.178S3; Mon, 21 Dec 2015 23:55:45 +0800 (CST) From: Geliang Tang To: Jaroslav Kysela , Takashi Iwai , Ricard Wanderlof , =?UTF-8?q?Johan=20Rast=C3=A9n?= Date: Mon, 21 Dec 2015 23:55:39 +0800 Message-Id: X-Mailer: git-send-email 2.5.0 X-CM-TRANSID: DdGowEDJWEj8IHhWvNZcAA--.178S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7JF47ArW7JrWxCFyDAFWrZrb_yoWftrc_Aa ySgrn7WFWjya4Skr1Y93s7tF95Zw1j9rsY9Fnay34rJr9rK345AFW7X3s3CryxWr1rKrZ8 GwnrZrWrKw18KjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjco2UUUUUU== X-Originating-IP: [116.77.150.152] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiowLXmVUL3gGYTwAAs5 X-Mailman-Approved-At: Mon, 21 Dec 2015 20:02:25 +0100 Cc: Geliang Tang , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH] ALSA: usb-audio: use list_for_each_entry_continue_reverse X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP For better readability, use list_for_each_entry_continue_reverse() in have_dup_chmap(). Signed-off-by: Geliang Tang --- sound/usb/stream.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/usb/stream.c b/sound/usb/stream.c index 8ee14f2..c4dc577 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -125,11 +125,9 @@ static int usb_chmap_ctl_info(struct snd_kcontrol *kcontrol, static bool have_dup_chmap(struct snd_usb_substream *subs, struct audioformat *fp) { - struct list_head *p; + struct audioformat *prev = fp; - for (p = fp->list.prev; p != &subs->fmt_list; p = p->prev) { - struct audioformat *prev; - prev = list_entry(p, struct audioformat, list); + list_for_each_entry_continue_reverse(prev, &subs->fmt_list, list) { if (prev->chmap && !memcmp(prev->chmap, fp->chmap, sizeof(*fp->chmap))) return true;