From patchwork Tue Sep 2 05:27:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 4823341 X-Patchwork-Delegate: tiwai@suse.de Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1E308C0338 for ; Tue, 2 Sep 2014 08:11:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 419902018B for ; Tue, 2 Sep 2014 08:11:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id E64642017D for ; Tue, 2 Sep 2014 08:11:34 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 04E122656D1; Tue, 2 Sep 2014 10:11:33 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 13DF52657C3; Tue, 2 Sep 2014 08:47:05 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 940672657C1; Tue, 2 Sep 2014 08:47:03 +0200 (CEST) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id B2705265816 for ; Tue, 2 Sep 2014 07:27:47 +0200 (CEST) Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 84E66AD2C; Tue, 2 Sep 2014 05:27:47 +0000 (UTC) Date: Tue, 02 Sep 2014 07:27:47 +0200 Message-ID: From: Takashi Iwai To: Dana Goyette In-Reply-To: <5405346E.1010502@gmail.com> References: <5405346E.1010502@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] ALC1150 broken on SuperMicro X10SAT X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP At Mon, 01 Sep 2014 20:07:26 -0700, Dana Goyette wrote: > > On 09/01/2014 06:17 AM, Takashi Iwai wrote: > > What about the patch below? It might be that only one of two changes > > is needed. > > > > > > thanks, > > > > Takashi > > > > --- > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index d446ac3137b3..1ba22fb527c2 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -328,6 +328,7 @@ static void alc_auto_init_amp(struct hda_codec *codec, int type) > > case 0x10ec0885: > > case 0x10ec0887: > > /*case 0x10ec0889:*/ /* this causes an SPDIF problem */ > > + case 0x10ec0900: > > alc889_coef_init(codec); > > break; > > case 0x10ec0888: > > @@ -2350,6 +2351,7 @@ static int patch_alc882(struct hda_codec *codec) > > switch (codec->vendor_id) { > > case 0x10ec0882: > > case 0x10ec0885: > > + case 0x10ec0900: > > break; > > default: > > /* ALC883 and variants */ > > > I've applied the patch, and that fixes it without having to specify a > model. Thanks! > > For reference, here's alsa-info after the patch: > > http://www.alsa-project.org/db/?f=d3a135bd31671e545067821bbd2cacc9d8f6fff8 Thanks for a quick test. FWIW, I applied the patch below to sound git tree now. Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: hda - Fix COEF setups for ALC1150 codec ALC1150 codec seems to need the COEF- and PLL-setups just like its compatible ALC882 codec. Some machines (e.g. SunMicro X10SAT) show the problem like too low output volumes unless the COEF setup is applied. Reported-and-tested-by: Dana Goyette Cc: Signed-off-by: Takashi Iwai --- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d446ac3137b3..1ba22fb527c2 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -328,6 +328,7 @@ static void alc_auto_init_amp(struct hda_codec *codec, int type) case 0x10ec0885: case 0x10ec0887: /*case 0x10ec0889:*/ /* this causes an SPDIF problem */ + case 0x10ec0900: alc889_coef_init(codec); break; case 0x10ec0888: @@ -2350,6 +2351,7 @@ static int patch_alc882(struct hda_codec *codec) switch (codec->vendor_id) { case 0x10ec0882: case 0x10ec0885: + case 0x10ec0900: break; default: /* ALC883 and variants */