From patchwork Wed Oct 8 10:16:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 5053031 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8A706C11AB for ; Wed, 8 Oct 2014 10:16:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9F6C82018E for ; Wed, 8 Oct 2014 10:16:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 401BA2012B for ; Wed, 8 Oct 2014 10:16:45 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 17738260855; Wed, 8 Oct 2014 12:16:44 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id DCD92260432; Wed, 8 Oct 2014 12:16:33 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9BF8A260438; Wed, 8 Oct 2014 12:16:32 +0200 (CEST) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id C2ABC260432 for ; Wed, 8 Oct 2014 12:16:25 +0200 (CEST) Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8DC09AB1D; Wed, 8 Oct 2014 10:16:25 +0000 (UTC) Date: Wed, 08 Oct 2014 12:16:25 +0200 Message-ID: From: Takashi Iwai To: Sascha Wilde In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] HDA: Missing Dock LineIn/Out with Lenovo L440 on Pro Dock X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP At Wed, 08 Oct 2014 11:40:35 +0200, Sascha Wilde wrote: > > Sascha Wilde writes: > > using a Lenovo L440 Laptop on a Lenovo Pro Dock the combined line-in/out > > jack at the docking station can not be used for output (input untested). > [...] > > I guess quirks for the pins leading to the external dock jack are > > missing. > > It seems the missing quirk is the same as for the T440: > http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id=1c37c22332a2d2c1b4ab32177a4f847c7fe06e38 > > Applying the pin config at module load time fixes the problem for me. > > This hotfix as suggested by Jim Minter in: > https://bugzilla.redhat.com/show_bug.cgi?id=1101386#c11 > is > > # cat >/lib/firmware/tpt440dock-patch.fw < [codec] > 0x10ec0292 0x17aa501e 0 > > [pincfg] > 0x16 0x21211010 > 0x19 0x21a11010 > EOF > > # cat >/etc/modprobe.d/hda-intel.conf < options snd-hda-intel > patch=tpt440dock-patch.fw,tpt440dock-patch.fw,tpt440dock-patch.fw > EOF > > # rmmod snd_hda_intel > # modprobe snd_hda_intel > > So, alsa devs, could you please enable ALC292_FIXUP_TPT440_DOCK for > ThinkPad L440 (codec 0x17aa, 0x501e)? Sure, could you check the patch below? Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: hda - Add dock port support to Thinkpad L440 (71aa:501e) Yet another Thinkpad model that has a dock port. Reported-by: Sascha Wilde Signed-off-by: Takashi Iwai --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 2cc2568af016..bc86c36b4bfa 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4805,6 +4805,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x3978, "IdeaPad Y410P", ALC269_FIXUP_NO_SHUTUP), SND_PCI_QUIRK(0x17aa, 0x5013, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x501a, "Thinkpad", ALC283_FIXUP_INT_MIC), + SND_PCI_QUIRK(0x17aa, 0x501e, "Thinkpad L440", ALC292_FIXUP_TPT440_DOCK), SND_PCI_QUIRK(0x17aa, 0x5026, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),