| Message ID | s5hy3u32lhi.wl-tiwai@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 11, 2017 at 1:21 PM, Takashi Iwai <tiwai@suse.de> wrote: > > Since no one cried against it so far, I'll try to smuggle the > following patch into 4.12. Can we instead just disable it with a one-liner that just makes SOUND_PRIME have a depends on n in it, so that you can't select it. Commenting out stuff in the Kconfig fine is not how we normally do these things.. Linus
On 05/11/17 13:28, Linus Torvalds wrote: > On Thu, May 11, 2017 at 1:21 PM, Takashi Iwai <tiwai@suse.de> wrote: >> >> Since no one cried against it so far, I'll try to smuggle the >> following patch into 4.12. > > Can we instead just disable it with a one-liner that just makes > SOUND_PRIME have a > > depends on n > > in it, so that you can't select it. > > Commenting out stuff in the Kconfig fine is not how we normally do > these things.. Yeah, I was thinking of depends on BROKEN but depends on n should be OK also.
On Thu, 11 May 2017 22:28:49 +0200, Linus Torvalds wrote: > > On Thu, May 11, 2017 at 1:21 PM, Takashi Iwai <tiwai@suse.de> wrote: > > > > Since no one cried against it so far, I'll try to smuggle the > > following patch into 4.12. > > Can we instead just disable it with a one-liner that just makes > SOUND_PRIME have a > > depends on n > > in it, so that you can't select it. > > Commenting out stuff in the Kconfig fine is not how we normally do > these things.. I rather wanted to show clearly that we're disabling it by that, but I don't mind either way. Will respin soon. thanks, Takashi
Hi Iwai-san, On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote: > From: Takashi Iwai <tiwai@suse.de> > Subject: [PATCH] sound: Disable the build of OSS drivers > > OSS drivers are left as badly unmaintained, and now we're facing a > problem to clean up the hackish set_fs() usage in their codes. Since > most of drivers have been covered by ALSA, and the others are dead old > and inactive, let's leave them RIP. > > This patch is the first step: disable the build of OSS drivers. > We'll eventually drop the whole codes and clean up later. > > Signed-off-by: Takashi Iwai <tiwai@suse.de> > --- > sound/Kconfig | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) > > diff --git a/sound/Kconfig b/sound/Kconfig > index ee2e69a9ecd1..41eda578d08e 100644 > --- a/sound/Kconfig > +++ b/sound/Kconfig > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM > > If unsure, say Y. > > -source "sound/oss/dmasound/Kconfig" > +### TO-BE-REMOVED > +# source "sound/oss/dmasound/Kconfig" Please note the dmasound drivers do not have ALSA equivalents. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, 12 May 2017 09:03:07 +0200, Geert Uytterhoeven wrote: > > Hi Iwai-san, > > On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote: > > From: Takashi Iwai <tiwai@suse.de> > > Subject: [PATCH] sound: Disable the build of OSS drivers > > > > OSS drivers are left as badly unmaintained, and now we're facing a > > problem to clean up the hackish set_fs() usage in their codes. Since > > most of drivers have been covered by ALSA, and the others are dead old > > and inactive, let's leave them RIP. > > > > This patch is the first step: disable the build of OSS drivers. > > We'll eventually drop the whole codes and clean up later. > > > > Signed-off-by: Takashi Iwai <tiwai@suse.de> > > --- > > sound/Kconfig | 26 ++++++++++++++------------ > > 1 file changed, 14 insertions(+), 12 deletions(-) > > > > diff --git a/sound/Kconfig b/sound/Kconfig > > index ee2e69a9ecd1..41eda578d08e 100644 > > --- a/sound/Kconfig > > +++ b/sound/Kconfig > > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM > > > > If unsure, say Y. > > > > -source "sound/oss/dmasound/Kconfig" > > +### TO-BE-REMOVED > > +# source "sound/oss/dmasound/Kconfig" > > Please note the dmasound drivers do not have ALSA equivalents. These belong to the latter, "dead old and inactive" ones :) Are these driver still used with the latest kernel? If users are willing to help, we can provide the port to ALSA drivers, too. thanks, Takashi
Hi Iwai-san, On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai <tiwai@suse.de> wrote: > On Fri, 12 May 2017 09:03:07 +0200, > Geert Uytterhoeven wrote: >> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote: >> > From: Takashi Iwai <tiwai@suse.de> >> > Subject: [PATCH] sound: Disable the build of OSS drivers >> > >> > OSS drivers are left as badly unmaintained, and now we're facing a >> > problem to clean up the hackish set_fs() usage in their codes. Since >> > most of drivers have been covered by ALSA, and the others are dead old >> > and inactive, let's leave them RIP. >> > >> > This patch is the first step: disable the build of OSS drivers. >> > We'll eventually drop the whole codes and clean up later. >> > >> > Signed-off-by: Takashi Iwai <tiwai@suse.de> >> > --- >> > sound/Kconfig | 26 ++++++++++++++------------ >> > 1 file changed, 14 insertions(+), 12 deletions(-) >> > >> > diff --git a/sound/Kconfig b/sound/Kconfig >> > index ee2e69a9ecd1..41eda578d08e 100644 >> > --- a/sound/Kconfig >> > +++ b/sound/Kconfig >> > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM >> > >> > If unsure, say Y. >> > >> > -source "sound/oss/dmasound/Kconfig" >> > +### TO-BE-REMOVED >> > +# source "sound/oss/dmasound/Kconfig" >> >> Please note the dmasound drivers do not have ALSA equivalents. > > These belong to the latter, "dead old and inactive" ones :) > > Are these driver still used with the latest kernel? If users are I believe so. > willing to help, we can provide the port to ALSA drivers, too. That would be great, thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, 12 May 2017 09:17:35 +0200, Geert Uytterhoeven wrote: > > Hi Iwai-san, > > On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai <tiwai@suse.de> wrote: > > On Fri, 12 May 2017 09:03:07 +0200, > > Geert Uytterhoeven wrote: > >> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote: > >> > From: Takashi Iwai <tiwai@suse.de> > >> > Subject: [PATCH] sound: Disable the build of OSS drivers > >> > > >> > OSS drivers are left as badly unmaintained, and now we're facing a > >> > problem to clean up the hackish set_fs() usage in their codes. Since > >> > most of drivers have been covered by ALSA, and the others are dead old > >> > and inactive, let's leave them RIP. > >> > > >> > This patch is the first step: disable the build of OSS drivers. > >> > We'll eventually drop the whole codes and clean up later. > >> > > >> > Signed-off-by: Takashi Iwai <tiwai@suse.de> > >> > --- > >> > sound/Kconfig | 26 ++++++++++++++------------ > >> > 1 file changed, 14 insertions(+), 12 deletions(-) > >> > > >> > diff --git a/sound/Kconfig b/sound/Kconfig > >> > index ee2e69a9ecd1..41eda578d08e 100644 > >> > --- a/sound/Kconfig > >> > +++ b/sound/Kconfig > >> > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM > >> > > >> > If unsure, say Y. > >> > > >> > -source "sound/oss/dmasound/Kconfig" > >> > +### TO-BE-REMOVED > >> > +# source "sound/oss/dmasound/Kconfig" > >> > >> Please note the dmasound drivers do not have ALSA equivalents. > > > > These belong to the latter, "dead old and inactive" ones :) > > > > Are these driver still used with the latest kernel? If users are > > I believe so. > > > willing to help, we can provide the port to ALSA drivers, too. > > That would be great, thanks! OK, we can go forward, then. But, looking at the tree again, I noticed that ALSA isn't built yet at all for m68k. I don't remember why it's disabled. Jaroslav, do you know the reason behind it? And, dmasound is a completely different implementation from the other OSS, thus it doesn't suffer from set_fs() hack. That is, we may still keep dmasound, while removing other OSS stuff. Meanwhile we'll try to support ALSA on m64k and eventually target to drop dmasound stuff. Does it sound more feasible? thanks, Takashi
Hi Iwai-san, On Fri, May 12, 2017 at 9:27 AM, Takashi Iwai <tiwai@suse.de> wrote: > On Fri, 12 May 2017 09:17:35 +0200, > Geert Uytterhoeven wrote: >> On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai <tiwai@suse.de> wrote: >> > On Fri, 12 May 2017 09:03:07 +0200, >> > Geert Uytterhoeven wrote: >> >> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote: >> >> > index ee2e69a9ecd1..41eda578d08e 100644 >> >> > --- a/sound/Kconfig >> >> > +++ b/sound/Kconfig >> >> > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM >> >> > >> >> > If unsure, say Y. >> >> > >> >> > -source "sound/oss/dmasound/Kconfig" >> >> > +### TO-BE-REMOVED >> >> > +# source "sound/oss/dmasound/Kconfig" >> >> >> >> Please note the dmasound drivers do not have ALSA equivalents. >> > >> > These belong to the latter, "dead old and inactive" ones :) >> > >> > Are these driver still used with the latest kernel? If users are >> >> I believe so. >> >> > willing to help, we can provide the port to ALSA drivers, too. >> >> That would be great, thanks! > > OK, we can go forward, then. > > But, looking at the tree again, I noticed that ALSA isn't built yet at > all for m68k. I don't remember why it's disabled. > Jaroslav, do you know the reason behind it? Because ALSA doesn't have any drivers that can be used on m68k platforms? > And, dmasound is a completely different implementation from the other > OSS, thus it doesn't suffer from set_fs() hack. That is, we may still > keep dmasound, while removing other OSS stuff. That's indeed good to know. > Meanwhile we'll try to support ALSA on m64k and eventually target to > drop dmasound stuff. > > Does it sound more feasible? Yes, definitely in the short run ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, May 12, 2017 at 09:27:56AM +0200, Takashi Iwai wrote: > But, looking at the tree again, I noticed that ALSA isn't built yet at > all for m68k. I don't remember why it's disabled. > Jaroslav, do you know the reason behind it? Might also just be because the m68k port had been dead in Debian for a while due the lack of TLS support in glibc on m68k. However, the port is active again and in pretty good shape now. I'm currently working on fixing debian-installer on m68k, so that people can install the port without having to resort to things like debootstrap. > And, dmasound is a completely different implementation from the other > OSS, thus it doesn't suffer from set_fs() hack. That is, we may still > keep dmasound, while removing other OSS stuff. Thanks! Highly appreciated. > Meanwhile we'll try to support ALSA on m64k and eventually target to > drop dmasound stuff. Ooooh, that would be awesome. If you need any testers on m68k, please let us know. I have plenty of m68k hardware for testing. > Does it sound more feasible? No idea whether it's feasible. But it sounds awesome :). Adrian
diff --git a/sound/Kconfig b/sound/Kconfig index ee2e69a9ecd1..41eda578d08e 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM If unsure, say Y. -source "sound/oss/dmasound/Kconfig" +### TO-BE-REMOVED +# source "sound/oss/dmasound/Kconfig" if !M68K && !UML @@ -112,17 +113,18 @@ source "sound/x86/Kconfig" endif # SND -menuconfig SOUND_PRIME - tristate "Open Sound System (DEPRECATED)" - select SOUND_OSS_CORE - help - Say 'Y' or 'M' to enable Open Sound System drivers. - -if SOUND_PRIME - -source "sound/oss/Kconfig" - -endif # SOUND_PRIME +### TO-BE-REMOVED +# menuconfig SOUND_PRIME +# tristate "Open Sound System (DEPRECATED)" +# select SOUND_OSS_CORE +# help +# Say 'Y' or 'M' to enable Open Sound System drivers. +# +# if SOUND_PRIME +# +# source "sound/oss/Kconfig" +# +# endif # SOUND_PRIME endif # !M68K