From patchwork Thu Nov 27 09:11:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5394271 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BBF75C11AC for ; Thu, 27 Nov 2014 09:24:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CAE51201EF for ; Thu, 27 Nov 2014 09:24:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9992201C8 for ; Thu, 27 Nov 2014 09:24:42 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XtvJW-0006pZ-1Z; Thu, 27 Nov 2014 09:24:38 +0000 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XtvJ4-0006OT-1L for ath10k@lists.infradead.org; Thu, 27 Nov 2014 09:24:13 +0000 Received: by mail-wg0-f50.google.com with SMTP id k14so5844788wgh.23 for ; Thu, 27 Nov 2014 01:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WP0M5hanIiEp+qKFxd2DSm/x73bgHUUmeqeRV8O43MQ=; b=JdTd7dSzjI29dplOk1Rw/ZvMZuAr44/7pZ/hA3tAtZmhqlMdJHbRZmNnsfiVGTeAk0 lyYBf6+sICPD2BtJuM8yXX/TWpJIX5+0j8hg3p0xUkMN1DckSRxq4ZLCZrfQPO5xlqHT rk+7fP/x+RWikN1PGQKb944JT7+eoSsk2AWp0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WP0M5hanIiEp+qKFxd2DSm/x73bgHUUmeqeRV8O43MQ=; b=kd5d38zKu4fZzfUUU9DYJLPXDBjN47SYndeQE+vhnstdR0Tjp/9BNTu3gieRaKgZyC 62zq77869OH+7VVkIkgkH8dvC/lodCk1jZOKdKSC1xsiox4fqNf3k9C2xKliR3qDlPhN 3gfUUiZ88W955n1VXUNpDjVhL0j1gbRga0Q+qs2jCFK6iDqTA3Nd/ZLK1C5EcYoWDVq1 ALjN/7i/vJYpsEn5eL0xigqULyydS9/tFsYBel9lG20kvy1tfpge+rJQtw1Amq0i2RL3 iVZofjeNdz3z/mR8ofIOJ+FhN/kcycDUXBmZNL/BOuLhvb8RoaAahKKYS7xKSLc7M049 tnBg== X-Gm-Message-State: ALoCoQkzdW7SKF7DkgWL4Chf70mKjfkGWUl7CPBxWmq14k9ScgneUpecdATG7uej+mP0bnP4z4ecUhQnZMqhgOmwmrc/TbwbIYJDAdxGRnYWrgGkQFKwWRcW2D2zC3L9XTuCOiBdQh6NHJ21d6/jmzQ3US9ewBlqDS8K51sbfDMqq50x9tm/DwA= X-Received: by 10.181.13.102 with SMTP id ex6mr48648844wid.78.1417080224608; Thu, 27 Nov 2014 01:23:44 -0800 (PST) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id fk16sm10747604wic.16.2014.11.27.01.23.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Nov 2014 01:23:44 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [PATCH v2 1/7] ath10k: fix wmi svc bitmap dbg print Date: Thu, 27 Nov 2014 10:11:15 +0100 Message-Id: <1417079481-22255-2-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1417079481-22255-1-git-send-email-michal.kazior@tieto.com> References: <1417079481-22255-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141127_012410_241797_6EDD1950 X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The dump print uses sizeof() but since service_map was a mere pointer the dump was too short. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi.c | 4 +++- drivers/net/wireless/ath/ath10k/wmi.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 23fee9a..c6c03e5 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2457,6 +2457,7 @@ static int ath10k_wmi_main_pull_svc_rdy_ev(struct sk_buff *skb, arg->eeprom_rd = ev->hal_reg_capabilities.eeprom_rd; arg->num_mem_reqs = ev->num_mem_reqs; arg->service_map = ev->wmi_service_bitmap; + arg->service_map_len = sizeof(ev->wmi_service_bitmap); n = min_t(size_t, __le32_to_cpu(arg->num_mem_reqs), ARRAY_SIZE(arg->mem_reqs)); @@ -2491,6 +2492,7 @@ static int ath10k_wmi_10x_pull_svc_rdy_ev(struct sk_buff *skb, arg->eeprom_rd = ev->hal_reg_capabilities.eeprom_rd; arg->num_mem_reqs = ev->num_mem_reqs; arg->service_map = ev->wmi_service_bitmap; + arg->service_map_len = sizeof(ev->wmi_service_bitmap); n = min_t(size_t, __le32_to_cpu(arg->num_mem_reqs), ARRAY_SIZE(arg->mem_reqs)); @@ -2541,7 +2543,7 @@ static void ath10k_wmi_event_service_ready(struct ath10k *ar, ath10k_debug_read_service_map(ar, svc_bmap, sizeof(svc_bmap)); ath10k_dbg_dump(ar, ATH10K_DBG_WMI, NULL, "wmi svc: ", - arg.service_map, sizeof(arg.service_map)); + arg.service_map, arg.service_map_len); /* only manually set fw features when not using FW IE format */ if (ar->fw_api == 1 && ar->fw_version_build > 636) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index 1b7141a..fc6b844 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h @@ -4577,6 +4577,7 @@ struct wmi_svc_rdy_ev_arg { __le32 eeprom_rd; __le32 num_mem_reqs; const __le32 *service_map; + size_t service_map_len; const struct wlan_host_mem_req *mem_reqs[WMI_MAX_MEM_REQS]; };