From patchwork Mon Jan 12 18:32:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Greear X-Patchwork-Id: 5616181 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2FC2AC058D for ; Mon, 12 Jan 2015 19:49:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6AB1E204DE for ; Mon, 12 Jan 2015 19:49:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9931D204D8 for ; Mon, 12 Jan 2015 19:49:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YAkzg-0003WY-P8; Mon, 12 Jan 2015 19:49:44 +0000 Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YAkzO-0002sO-JA for ath10k@lists.infradead.org; Mon, 12 Jan 2015 19:49:28 +0000 Received: from firewall.candelatech.com (unknown [50.251.239.81]) by mail2.candelatech.com (Postfix) with ESMTP id 9583940D738; Mon, 12 Jan 2015 11:48:44 -0800 (PST) Received: from ben-dt2.candelatech.com. (ben-dt2.candelatech.com [192.168.100.236]) by firewall.candelatech.com (Postfix) with ESMTP id 772045A0722; Mon, 12 Jan 2015 10:32:50 -0800 (PST) From: greearb@candelatech.com To: ath10k@lists.infradead.org Subject: [PATCH 4/8] ath10k: make dbglog debug messages be 'warn' level. Date: Mon, 12 Jan 2015 10:32:40 -0800 Message-Id: <1421087564-10384-4-git-send-email-greearb@candelatech.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1421087564-10384-1-git-send-email-greearb@candelatech.com> References: <1421087564-10384-1-git-send-email-greearb@candelatech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150112_114926_756873_0B94A5ED X-CRM114-Status: UNSURE ( 6.90 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) Cc: Ben Greear , linux-wireless@vger.kernel.org X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Ben Greear This only happens on firmware crash, and it appears this logic is not always perfect, so make sure the information is printed to logs at higher level. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/pci.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 0f7e845..dee0d5a 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1132,9 +1132,8 @@ static void ath10k_pci_dump_dbglog(struct ath10k *ar) return; } - ath10k_dbg(ar, ATH10K_DBG_PCI, - "debug log header, dbuf: 0x%x dropped: %i\n", - le32_to_cpu(dbg_hdr.dbuf), le32_to_cpu(dbg_hdr.dropped)); + ath10k_warn(ar, "debug log header, dbuf: 0x%x dropped: %i\n", + le32_to_cpu(dbg_hdr.dbuf), le32_to_cpu(dbg_hdr.dropped)); dbufp = le32_to_cpu(dbg_hdr.dbuf); /* i is for logging purposes and sanity check in case firmware buffers @@ -1154,11 +1153,10 @@ static void ath10k_pci_dump_dbglog(struct ath10k *ar) len = le32_to_cpu(dbuf.length); - ath10k_dbg(ar, ATH10K_DBG_PCI, - "[%i] next: 0x%x buf: 0x%x sz: %i len: %i count: %i free: %i\n", - i, le32_to_cpu(dbuf.next), le32_to_cpu(dbuf.buffer), - le32_to_cpu(dbuf.bufsize), len, - le32_to_cpu(dbuf.count), le32_to_cpu(dbuf.free)); + ath10k_warn(ar, "[%i] next: 0x%x buf: 0x%x sz: %i len: %i count: %i free: %i\n", + i, le32_to_cpu(dbuf.next), le32_to_cpu(dbuf.buffer), + le32_to_cpu(dbuf.bufsize), len, + le32_to_cpu(dbuf.count), le32_to_cpu(dbuf.free)); if (dbuf.buffer == 0 || len == 0) goto next;