From patchwork Fri Feb 6 12:02:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5790091 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E13BDBF6C3 for ; Fri, 6 Feb 2015 12:04:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 100DD200DB for ; Fri, 6 Feb 2015 12:04:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC1A9201CE for ; Fri, 6 Feb 2015 12:04:20 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YJhdu-00054q-E8; Fri, 06 Feb 2015 12:04:14 +0000 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YJhds-0004yM-Vm for ath10k@lists.infradead.org; Fri, 06 Feb 2015 12:04:13 +0000 Received: by mail-wi0-f176.google.com with SMTP id bs8so1913591wib.3 for ; Fri, 06 Feb 2015 04:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nmpHWE+AE95+VU1vv0qt5DOvPQRW4T9MWI382gQ/3+s=; b=pNqMI12BvmS0QbMc3BxhRni5WRe0H3Mgeb34Q31+E4c0aHo/v63yjG5N4mCW772weu iDbSa/G2gNLZe7QhXnWYJR/lPgY110/MS9GA16VZDTe8hlNtD+FJiN46xsMamcOHxDhT gIoy3m5TKQ+wG2Mb7Q7cGP+ocvuF8OPlHvHF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nmpHWE+AE95+VU1vv0qt5DOvPQRW4T9MWI382gQ/3+s=; b=G1DcJyjhzR83gksCQvWdT0QiBf3RR9vywgCUrbyyEw0jUqLZ97dClHJVw3laOCRNeW co2n79l03af/Ru6AaZ8+BgN0SAyScOjLNEe8nldsFiTqW1doj44WhjNkjfRgLD75jlE6 SxBGpCSX1k1zP8CAXMDLQg2hmEp10DWNcDqA1WLeBzpsPtuEYRUi+BUUr/jfx4ZMbF3k nNWXqpKYoFHGS1xWKaE8nSB/S6lX1zrmrjHi+R3zC3GS2N91qKyNN54ukaLvJEmPDC9I IYnZzV24DWbcorReXQxKZRHmiC2LHktPCwBEVARlq6++nm+0pWaKawaY0wVQwR1i6+wC Ui8g== X-Gm-Message-State: ALoCoQn1875tSxQfXUKt2/ukOMmbxNxMLIDe6+ynZxdxlqKKNS/uE7VawCb6xEmjWPhcoqscW3Lb12Dlf/TtXGBILQT6mIuVR1Tfj8VbHXzJJb2PMsnkFzchCeK2VPXMJU6j5N4wppa5AolEW6jbZqMQN6Nhoc2v68gjXYLaMVse5bmu968yq1I= X-Received: by 10.180.100.202 with SMTP id fa10mr2775321wib.10.1423224231006; Fri, 06 Feb 2015 04:03:51 -0800 (PST) Received: from bob.homerouter.cpe (apn-31-1-134-151.dynamic.gprs.plus.pl. [31.1.134.151]) by mx.google.com with ESMTPSA id kj8sm3070158wjc.29.2015.02.06.04.03.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Feb 2015 04:03:50 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [PATCH v3 1/7] ath10k: allow empty ssid vdev config Date: Fri, 6 Feb 2015 13:02:48 +0100 Message-Id: <1423224174-24764-2-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1423224174-24764-1-git-send-email-michal.kazior@tieto.com> References: <1423224174-24764-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150206_040413_161226_F2593426 X-CRM114-Status: UNSURE ( 7.92 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index 71614ba..c13a505 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1302,8 +1302,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index aeea1c7..0da1cdc 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4295,8 +4295,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))