From patchwork Thu Mar 26 10:03:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6097411 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0F8D89F399 for ; Thu, 26 Mar 2015 10:06:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 32B75201EC for ; Thu, 26 Mar 2015 10:06:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 363B320263 for ; Thu, 26 Mar 2015 10:06:26 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yb4gA-0003Jn-K3; Thu, 26 Mar 2015 10:06:22 +0000 Received: from mail-la0-x231.google.com ([2a00:1450:4010:c03::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yb4g7-0003Ao-SK for ath10k@lists.infradead.org; Thu, 26 Mar 2015 10:06:21 +0000 Received: by labto5 with SMTP id to5so41470525lab.0 for ; Thu, 26 Mar 2015 03:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=Ho/l5j3D4V4/MAj77e0uiaM1LX4tx4PlkdZlLn7T/i4=; b=HmE1XS0nUFIEYuzLKHFU2DAbWMDlh24LV6faskGgb66dsmbRBzATPy3dtsvYwb5bzv PFU1lxCqSmPOIC3YAVwZ/aRzf/AmFWikL84k4mOSVoeAHM9G6w9S4fZmAweuQTwd7Dzy rPLNwufZlZ34cYJwctZ2JAXtluziy9mablPRE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ho/l5j3D4V4/MAj77e0uiaM1LX4tx4PlkdZlLn7T/i4=; b=EWElvCjR+NTjMSa2wbQ0AR116igYCg5klKBO8NyGZu154pRMH2XT3/XA3EzALe/X5a kGQycCZSOhs8eINPAHtVylEIf4vst5knvSsgvdpmiGlOUR4Hr6R9p5R2Ja+tDNvL39Tb TZ3cvIS25goNrr+pTTEQ8o8W8LrZ5qiq2CzTQ8RvpxtQyDo0SdI6QZC3l85NKoEawwz1 q5i7BVhErat+5z+yhviYRLtMHPV/dJkE8t+zCo9BHCQZF1dG6WOAZgaKs4olTEBH/Gty 0LcyjixTtEMPiLQotH2hfEo5XLog5bOnDsxSZsfa0dTPlTlJoLyqQgupAe9cnP7aLrMi nGxQ== X-Gm-Message-State: ALoCoQl6Om8BKAx1Cwofu/906ekfoYYIUsnaBa4KM+Kzmys318tp4C2hUcUdQ13WR1Z5PZcjqjGX3gk3BtnjRrveMxfTihpFI7SLTmOtwjLVB+v7/oBwtaVEcaoY6kpKXDuGBojnRtY9v9roFYnaaOfZ9avaAwH/2V0xBbtJBKZox3SE0PCtCFA= X-Received: by 10.152.163.2 with SMTP id ye2mr12377885lab.89.1427364357353; Thu, 26 Mar 2015 03:05:57 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id s17sm118997lbp.40.2015.03.26.03.05.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Mar 2015 03:05:56 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [PATCH] ath10k: fix insufficient tracing buffer size Date: Thu, 26 Mar 2015 10:03:22 +0000 Message-Id: <1427364202-25235-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150326_030620_131279_A979F0CD X-CRM114-Status: UNSURE ( 7.38 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some trace messages were truncated and a kernel splat could be seen in the log: WARNING: CPU: 3 PID: 0 at /devel/src/linux/drivers/net/wireless/ath/ath10k/./trace.h:114 ftrace_raw_event_ath10k_log_dbg+0x20e/0x220 [ath10k_core]() Modules linked in: ath10k_pci(O) ath10k_core(O) ath iwldvm iwlwifi [last unloaded: iwlwifi] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G W O 4.0.0-rc3-wl-ath+ #703 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014 ffffffffa01d4cb0 ffff88001fd83998 ffffffff8191b86c ffffffff81e3b718 0000000000000000 ffff88001fd839d8 ffffffff8105573a ffff88001c0a5528 ffff88001bea9ae0 ffff88001c3dd940 00000000000d0018 ffff88001fd83a80 Call Trace: [] dump_stack+0x45/0x57 [] warn_slowpath_common+0x8a/0xc0 [] warn_slowpath_null+0x1a/0x20 [] ftrace_raw_event_ath10k_log_dbg+0x20e/0x220 [ath10k_core] [] ath10k_dbg+0xbb/0xd0 [ath10k_core] [] ? trace_clock_local+0x9/0x10 [] ath10k_wmi_event_service_ready+0x479/0x520 [ath10k_core] [] ? trace_buffer_unlock_commit+0x50/0x60 [] ath10k_wmi_tlv_op_rx+0x6b3/0x8b0 [ath10k_core] This could be reproduced with: trace-cmd record -e ath10k ifconfig wlan0 down ifconfig wlan0 up Fixes: 5c01aa3de918 ("ath10k: deduplicate wmi service ready logic") Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend") Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/trace.h b/drivers/net/wireless/ath/ath10k/trace.h index 5407887380ab..71dfcd96354b 100644 --- a/drivers/net/wireless/ath/ath10k/trace.h +++ b/drivers/net/wireless/ath/ath10k/trace.h @@ -46,7 +46,7 @@ static inline void trace_ ## name(proto) {} #undef TRACE_SYSTEM #define TRACE_SYSTEM ath10k -#define ATH10K_MSG_MAX 200 +#define ATH10K_MSG_MAX 400 DECLARE_EVENT_CLASS(ath10k_log_event, TP_PROTO(struct ath10k *ar, struct va_format *vaf),