From patchwork Tue Mar 31 10:26:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6128551 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B4A559F2EC for ; Tue, 31 Mar 2015 10:33:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D37AB201DD for ; Tue, 31 Mar 2015 10:33:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D43ED2018E for ; Tue, 31 Mar 2015 10:33:45 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YctU9-0007R8-Kr; Tue, 31 Mar 2015 10:33:29 +0000 Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YctU6-0007Nk-LL for ath10k@lists.infradead.org; Tue, 31 Mar 2015 10:33:27 +0000 Received: by lboc7 with SMTP id c7so9037309lbo.1 for ; Tue, 31 Mar 2015 03:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CAl4V4WKOiyP9xtlaCSm53zbk6WaVl8hku6cvTwuNcE=; b=cCXWJqpElAwGuvLoWTKduhOV1ElFdqcH9ek5JxXQoiz81KNOGarWCp+9KmA0pao3py nlEWOR/0xMqp+oMZtaQ1Fnmp8MIF07D8+WGrW5dwcb5t6G6xL/Fel6HWQaXqPVi3+h3L 8IedKr3aUBGTXwGoWaAv3uUEETfrysNYCk1OU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CAl4V4WKOiyP9xtlaCSm53zbk6WaVl8hku6cvTwuNcE=; b=e8lfm0/H0WfquJ8reeNw9AI4Kk2IxK+EpLxUQ5BQJB2iLjhDCMkrzyaWgYogP66Cja ZHaxy8NxtW41DmDgIbkD6UwZl+Pt4jHMDWXvPaFxoEx7cyOCI/s/m2lLq2PpH9z3qFlR zupHYBHqpGtHlKV1M3jcV7h0N+bH5YLGDYg/7i227t4dH9eX7FGSQ+qrCFXuGQTPM77m 2Y1T2zgvX6PrwGyHtwtJYUOXa1Lqa+2/EJFznevN7vE1nL1Tuo+VbfBtqFJlwzyFD/E2 ZszeRAmIAB3NmZDglKWt+Eddse3BKsU0t/VPB6/Qxrt8XZw7D8j4SlhXbUK6bUNj0gPQ qrhg== X-Gm-Message-State: ALoCoQnCXhkdq99yxtkXgnDoxqjTmzt/CUAbsmGosRKpHb1ImuZHx1TsLw8w9hiTHglh10u70vofTq+xYgAy0/kaCK8fmi8SNb8dakzO1bByr72yoxHE0P1KsAF2M5YlSrs6W0wX2KXb2KrAlihIkNL53Y4bC8QFEIIGdQKMN3Jh0rQUuFOw6yQ= X-Received: by 10.112.85.10 with SMTP id d10mr28145275lbz.62.1427797983393; Tue, 31 Mar 2015 03:33:03 -0700 (PDT) Received: from bob.homerouter.cpe (apn-46-169-246-95.dynamic.gprs.plus.pl. [46.169.246.95]) by mx.google.com with ESMTPSA id d3sm2553595lbc.39.2015.03.31.03.33.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 31 Mar 2015 03:33:02 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [PATCH v6 1/7] ath10k: allow empty ssid vdev config Date: Tue, 31 Mar 2015 10:26:20 +0000 Message-Id: <1427797586-5132-2-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1427797586-5132-1-git-send-email-michal.kazior@tieto.com> References: <1427797586-5132-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150331_033326_889186_73F7657A X-CRM114-Status: UNSURE ( 7.99 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index 7bfb45492027..ac3b4fd5b752 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1518,8 +1518,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 4778031b8635..da2fc1d99291 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4244,8 +4244,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))