From patchwork Fri May 8 09:13:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6363791 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 43DF9BEEE1 for ; Fri, 8 May 2015 09:17:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 54A3720220 for ; Fri, 8 May 2015 09:17:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DF282011E for ; Fri, 8 May 2015 09:17:41 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YqePW-0000gb-Cr; Fri, 08 May 2015 09:17:34 +0000 Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YqePS-0000LU-5T for ath10k@lists.infradead.org; Fri, 08 May 2015 09:17:31 +0000 Received: by lbbuc2 with SMTP id uc2so48907158lbb.2 for ; Fri, 08 May 2015 02:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WO8QryQZR5CBrfcA+syM5FKIBjyfR5Iwy0IN1x/xdLc=; b=PpKJWnceEPMtB/k25kqV5KBcTH987D9bNEOz7LzDJ5fQ3jiLNdOZhZov62xiK3/6sH Ea92dUXcWACL26ZZIW7os/q19uXMgokmwYST2OArI0rkH/+EjDglTTROs6WBQaI6q0PY nW8U1G2hMlCsYfpymT7jQ6ziu5eGYar8eYS5Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WO8QryQZR5CBrfcA+syM5FKIBjyfR5Iwy0IN1x/xdLc=; b=AfEpUhvb7iZ48Aj0RQ+9C5lYWQqjRfN8y+1Qo7zsLOuFR/kzmMM3nw6605ntjD4TIi AVr1mHdAnAaYlXvgQx5KA4fbC8xvbALN/PxS1sw53UIYf2lI/pisUufXfhj54Awo14MC JqpRlCHmFMnOX09/5nHf1LTPNbkIoMmMiY89Q0gtWFzuXv2ieONnWyJBJC0Zc3xVU1ES vG9qM3CIAaOjbjhOYquBbCeeydiTaUT/jyAp9ifZW03b9QYpzMtlmjOjG8JND+nR7Z/g ieI8X4tLGT0yB+x4+s2m0b1mFGhf6DIqmvAHviA/bshTVWl6P1JxtQ0EE1KxUvmL1rdv G55g== X-Gm-Message-State: ALoCoQnKx3UqYdHU5pT+pnEigKOur5BkNa+aBm09m32Wj16+lWSSoZoJ4UL9wvSY7TkHDDJ0vExeZs6UfirBUQ4yWTZzSSkvfXwxZ4nIDuh2ppKlJ2+hI5hWn6BD8bb2L1JwYZ3beYNOWjWrnY+ny5nvp/isrTXRDLksDFMRYfoaf0j5/6oEVII= X-Received: by 10.152.170.136 with SMTP id am8mr2234295lac.102.1431076622081; Fri, 08 May 2015 02:17:02 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id o5sm1028188lag.9.2015.05.08.02.17.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 May 2015 02:17:01 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [PATCH 2/3] ath10k: fix idle power consumption Date: Fri, 8 May 2015 09:13:07 +0000 Message-Id: <1431076388-24800-3-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1431076388-24800-1-git-send-email-michal.kazior@tieto.com> References: <1431076388-24800-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150508_021730_417317_4016F846 X-CRM114-Status: UNSURE ( 9.32 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: Janusz Dziedzic , linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Janusz Dziedzic mac80211 can update vif powersave state while disconnected. Firmware doesn't behave nicely and consumes more power than necessary if PS is disabled on a non-started vdev. Hence force-enable PS for non-running vdevs. This reduces power drain on QCA61X4 from 88mA to 36mA when interface is up and not associated. QCA988X wasn't measured. Signed-off-by: Janusz Dziedzic Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 425dbe271495..9f576ca99f86 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -1735,7 +1735,14 @@ static int ath10k_mac_vif_setup_ps(struct ath10k_vif *arvif) enable_ps = false; } - if (enable_ps) { + if (!arvif->is_started) { + /* mac80211 can update vif powersave state while disconnected. + * Firmware doesn't behave nicely and consumes more power than + * necessary if PS is disabled on a non-started vdev. Hence + * force-enable PS for non-running vdevs. + */ + psmode = WMI_STA_PS_MODE_ENABLED; + } else if (enable_ps) { psmode = WMI_STA_PS_MODE_ENABLED; param = WMI_STA_PS_PARAM_INACTIVITY_TIME;