| Message ID | 1437490215-11214-1-git-send-email-kevin@darbyshire-bryant.me.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes: > When using DFS channels on Ath10k, kernel log has repeated warning message > 'failed to process fft: -22' typically under medium/heavy traffic. > > This patch switches the warnings to driver debug (WMI events) mode only > thus reducing log file noise. > > DFS and spectral scan share underlying HW mechanisms and enabling one > (DFS) enables the other (spectral scan) as far as event reporting from > firmware to driver is concerned. Spectral scan events take no part in > processing of DFS radar pulses which are delivered as distinct events, > so the fft (spectral event) warning is harmless and DFS interference > detection/protection still occurs. > > Symptoms seen & fix tested in both debug & non-debug modes on TP-Link > Archer C7 v2 platform. > > Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> Thanks, applied. In the future please use v2, v3 to mark different versions of the patch so that I can easily find the latest version: https://www.kernel.org/doc/Documentation/SubmittingPatches
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 0791a43..1435614 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -3498,7 +3498,7 @@ void ath10k_wmi_event_spectral_scan(struct ath10k *ar, fftr, fftr_len, tsf); if (res < 0) { - ath10k_warn(ar, "failed to process fft report: %d\n", + ath10k_dbg(ar, ATH10K_DBG_WMI, "failed to process fft report: %d\n", res); return; }
When using DFS channels on Ath10k, kernel log has repeated warning message 'failed to process fft: -22' typically under medium/heavy traffic. This patch switches the warnings to driver debug (WMI events) mode only thus reducing log file noise. DFS and spectral scan share underlying HW mechanisms and enabling one (DFS) enables the other (spectral scan) as far as event reporting from firmware to driver is concerned. Spectral scan events take no part in processing of DFS radar pulses which are delivered as distinct events, so the fft (spectral event) warning is harmless and DFS interference detection/protection still occurs. Symptoms seen & fix tested in both debug & non-debug modes on TP-Link Archer C7 v2 platform. Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> --- drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)