From patchwork Tue Oct 27 19:02:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: punit vara X-Patchwork-Id: 7501401 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 780FCBEEA4 for ; Tue, 27 Oct 2015 19:04:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B33C0208D1 for ; Tue, 27 Oct 2015 19:04:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1D18208CE for ; Tue, 27 Oct 2015 19:04:41 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zr9Xx-0001oV-BR; Tue, 27 Oct 2015 19:04:37 +0000 Received: from mail-wi0-x242.google.com ([2a00:1450:400c:c05::242]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zr9Xv-0001ej-JQ for ath10k@lists.infradead.org; Tue, 27 Oct 2015 19:04:36 +0000 Received: by wicuv6 with SMTP id uv6so29613379wic.2 for ; Tue, 27 Oct 2015 12:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GogLxNvjpc2tQ1zG2STLrhEyZeFkQVuuxBfHkpWEmIU=; b=LvrLzIBkOoti4Q9AoeCQO5ihQLCvFZgjcrqnqt2OryrPKpeso7GDzf83cwEUCEhE2g 70BOZuq9emLgb/NfOjTHqkeQ76YUE8FKj1sBht+VtL4YqSO6qLCzg/MHBixKNvfJog9z b9iaAmQw8C9vN+la4xGEZqNQv5hF0xdCmSI5fS0IGbBeVHGd+FAaPHq25Mwd0BqhXKKb WIGGK+EQ/WdhkWApqY6l2Tr40XlCNNoeQhtxn9mYuWKmEUUwgpU9LzOjC6KumY84JF+s LXqYmLZW3V+QOvAPz7ZuXTbB0vXdGBsBIffsmqjVodznE9r4hZVrue4y3d2yEZ+Mc8Ed +1PA== X-Received: by 10.194.206.39 with SMTP id ll7mr28385187wjc.114.1445972654404; Tue, 27 Oct 2015 12:04:14 -0700 (PDT) Received: from localhost.localdomain ([163.47.15.144]) by smtp.gmail.com with ESMTPSA id hk5sm46320620wjb.6.2015.10.27.12.04.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Oct 2015 12:04:13 -0700 (PDT) From: Punit Vara To: kvalo@qca.qualcomm.com Subject: [RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret Date: Wed, 28 Oct 2015 00:32:42 +0530 Message-Id: <1445972565-14963-7-git-send-email-punitvara@gmail.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1445972565-14963-1-git-send-email-punitvara@gmail.com> References: <1445972565-14963-1-git-send-email-punitvara@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151027_120435_792455_E30F77D8 X-CRM114-Status: GOOD ( 10.67 ) X-Spam-Score: 0.6 (/) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Punit Vara , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RCVD_IN_SBL_CSS, RP_MATCHES_RCVD, T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return using ret Signed-off-by: Punit Vara --- drivers/net/wireless/iwlegacy/3945-mac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c index af1b3e6..ff4dc44 100644 --- a/drivers/net/wireless/iwlegacy/3945-mac.c +++ b/drivers/net/wireless/iwlegacy/3945-mac.c @@ -244,9 +244,7 @@ il3945_set_dynamic_key(struct il_priv *il, struct ieee80211_key_conf *keyconf, static int il3945_remove_static_key(struct il_priv *il) { - int ret = -EOPNOTSUPP; - - return ret; + return -EOPNOTSUPP; } static int @@ -529,7 +527,6 @@ il3945_tx_skb(struct il_priv *il, if (unlikely(tid >= MAX_TID_COUNT)) goto drop; } - /* Descriptor for chosen Tx queue */ txq = &il->txq[txq_id]; q = &txq->q;