From patchwork Wed Feb 10 16:58:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Protopopov X-Patchwork-Id: 8273331 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 909A2BEEE5 for ; Wed, 10 Feb 2016 17:00:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 983A1200D9 for ; Wed, 10 Feb 2016 17:00:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34D3D203AE for ; Wed, 10 Feb 2016 17:00:30 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aTY7d-000360-FA; Wed, 10 Feb 2016 17:00:09 +0000 Received: from mail-qg0-x229.google.com ([2607:f8b0:400d:c04::229]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aTY75-00027S-R5 for ath10k@lists.infradead.org; Wed, 10 Feb 2016 16:59:38 +0000 Received: by mail-qg0-x229.google.com with SMTP id b67so18156963qgb.1 for ; Wed, 10 Feb 2016 08:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Qu37R5QXpdMhwEwuoOqftRlzVKF+4s4Mps2UyGxyO68=; b=uG7CtIeMKSTZI5sUd+w0QQOJz2/zo2ScZCr5lra77UwGGUzmy0rtk7wTJ37n49gULg 7qJHS0jiJfDRZ98zcWhtOR0z17GqKyWtaM6G+GGPo97Bm4MaXfvIEFv4hxu90w9eSWAl Rd9SyNN9gLMLn+KDgS+B6cfalGZRqDFPze/wnXCKV8q8ETDPt8QDXhIgRvXDSILMs1hb k5uufRifa6NVkxwQeiKd8vHsG9Ib/HB5iLtMxHPeWNI46Lbz6i8UkFPh4YDA70r7ke5R KJehqYe/1iASLjNK1ZXKgtHyDZ7fOBJ/Je4YLIQR+tkzkcPOtNzq9xrISlpRtEg6IckX erVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Qu37R5QXpdMhwEwuoOqftRlzVKF+4s4Mps2UyGxyO68=; b=BpE7yzW1gNYJLPj/s5ljOm7/2kd9yGsZBJqVOtMoLGbSqR2+CKqO5DYIg4qIt1wE49 FEiORcSpvkURrBCAk+IJyvLq+9ocC9HtjefkYXRHkVFbRnTt5L31lcDrTA331zlcvNnd hqSxH7/Af8ndcPPJROsDP8mNa1DMXgeTVMreyZGHJKZeW0gVIa9gN+yH8EN/fpNmwQ9E Z/2BXN9+eu3xj7FdbXMwjhh5CWVJnPVjwGk7K1lCxEoq3tOFZh/OkVXbpZvwAAhmZFBL dbAGbjPyiu7vuyLjfwAlBYVmSq65u3+xfnS3eG+PoYPI8dytiOGsX7lOB4x3y5ICFLeX MrHg== X-Gm-Message-State: AG10YORB3dSK+sy672tPA7+jZMtBOQlGsjgsu0Xew48N4hk0Kfu0KI89TEvJuuwYK8rDjw== X-Received: by 10.140.133.133 with SMTP id 127mr12980449qhf.42.1455123554088; Wed, 10 Feb 2016 08:59:14 -0800 (PST) Received: from darkavanger325.localdomain (c-76-124-149-72.hsd1.nj.comcast.net. [76.124.149.72]) by smtp.gmail.com with ESMTPSA id z132sm1650819qka.14.2016.02.10.08.59.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 10 Feb 2016 08:59:13 -0800 (PST) From: Anton Protopopov To: Kalle Valo Subject: [PATCH] ath10k: fix erroneous return value Date: Wed, 10 Feb 2016 11:58:55 -0500 Message-Id: <1455123535-26751-1-git-send-email-a.s.protopopov@gmail.com> X-Mailer: git-send-email 2.6.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160210_085936_205085_CEC37203 X-CRM114-Status: UNSURE ( 8.53 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Anton Protopopov MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The ath10k_pci_hif_exchange_bmi_msg() function may return the positive value EIO instead of -EIO in case of error. Signed-off-by: Anton Protopopov Reviewed-by: Julian Calaby --- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index ee925c6..526acde 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1756,7 +1756,7 @@ static int ath10k_pci_hif_exchange_bmi_msg(struct ath10k *ar, DMA_FROM_DEVICE); ret = dma_mapping_error(ar->dev, resp_paddr); if (ret) { - ret = EIO; + ret = -EIO; goto err_req; }