From patchwork Fri Jul 8 12:59:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajkumar Manoharan X-Patchwork-Id: 9220825 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 21B266044F for ; Fri, 8 Jul 2016 13:00:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FBF12877F for ; Fri, 8 Jul 2016 13:00:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 018E028791; Fri, 8 Jul 2016 13:00:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 36DFC2877F for ; Fri, 8 Jul 2016 13:00:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bLVNs-0006iL-TE; Fri, 08 Jul 2016 12:59:56 +0000 Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bLVNq-0006et-W4 for ath10k@lists.infradead.org; Fri, 08 Jul 2016 12:59:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1467982794; x=1499518794; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yX5U9uKilXKwthQwJA7o80n6tD2suf4Lv9PSDXgfGwY=; b=VpHfzvoExowMaqSs8LLoDy3LzdtM2Av5Cra4sz8TBsoEJzwCoivnEROV MRoyy7V2WgGH0w2wVwz7iYTmnzA89vVUuOqmyl05qSQWx3lk4QGGcP2Qv 3UGhJQOUQUHetlQAtcXbEykDkoC8DAXNHj234kq2vHT7wdPA/xl+vSRnL c=; X-IronPort-AV: E=Sophos;i="5.28,329,1464678000"; d="scan'208";a="301962439" Received: from unknown (HELO ironmsg02-R.qualcomm.com) ([10.53.140.106]) by wolverine02.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Jul 2016 05:59:33 -0700 X-IronPort-AV: E=McAfee;i="5700,7163,8219"; a="766647837" Received: from nasanexm01g.na.qualcomm.com ([10.85.0.33]) by ironmsg02-R.qualcomm.com with ESMTP/TLS/RC4-SHA; 08 Jul 2016 05:59:33 -0700 Received: from aphydexm01a.ap.qualcomm.com (10.252.127.10) by NASANEXM01G.na.qualcomm.com (10.85.0.33) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 8 Jul 2016 05:59:32 -0700 Received: from aphydexm01b.ap.qualcomm.com (10.252.127.11) by aphydexm01a.ap.qualcomm.com (10.252.127.10) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 8 Jul 2016 18:29:27 +0530 Received: from aphydexm01b.ap.qualcomm.com ([10.252.127.11]) by aphydexm01b.ap.qualcomm.com ([10.252.127.11]) with mapi id 15.00.1178.000; Fri, 8 Jul 2016 18:29:27 +0530 From: "Manoharan, Rajkumar" To: Krishna Chaitanya Subject: Re: ath10k + iw set bitrates is causing FW crash Thread-Topic: ath10k + iw set bitrates is causing FW crash Thread-Index: AQHR2G+T1eIkIme5UE+r3U2t7k/kPqAM760AgAFgbAP//8JJgIAAbFIJ Date: Fri, 8 Jul 2016 12:59:26 +0000 Message-ID: <1467982766213.21223@qti.qualcomm.com> References: <1467972560885.99812@qti.qualcomm.com>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.106.107.6] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160708_055955_107915_2AE7E9DF X-CRM114-Status: UNSURE ( 8.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-wireless , ath10k Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP I think security failures are due to peer unmap & map upon reassoc. Can you please try below change? -Rajkumar diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 5e1cc8f4c43c..f7f04bb46fc8 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -5745,8 +5745,9 @@ static void ath10k_sta_rc_update_wk(struct work_struct *wk) sta->addr, smps, err); } - if (changed & IEEE80211_RC_SUPP_RATES_CHANGED || - changed & IEEE80211_RC_NSS_CHANGED) { + if ((changed & IEEE80211_RC_SUPP_RATES_CHANGED || + changed & IEEE80211_RC_NSS_CHANGED) && + (arvif->vif->type == NL80211_IFTYPE_ADHOC)) { ath10k_dbg(ar, ATH10K_DBG_MAC, "mac update sta %pM supp rates/nss\n", sta->addr);