From patchwork Fri Aug 19 12:14:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajkumar Manoharan X-Patchwork-Id: 9290141 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7D7BE60574 for ; Fri, 19 Aug 2016 12:15:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E3D3293E6 for ; Fri, 19 Aug 2016 12:15:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 62FB8293F3; Fri, 19 Aug 2016 12:15:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F3CC3293E6 for ; Fri, 19 Aug 2016 12:15:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1baihi-0007bw-5n; Fri, 19 Aug 2016 12:15:18 +0000 Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1baihf-0006rd-1V for ath10k@lists.infradead.org; Fri, 19 Aug 2016 12:15:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1471608914; x=1503144914; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=4+WWKr19QwKQ8fH8Mk/Zxi3Adb0etH0c3ppTcCnERu8=; b=fuwclWu1pYs4wjrDMuZ+YSc9YDfFLhTzf8x/T7RH5ytE8vZxA5h8pCqn mhfgfZ0ahLfPNhHkxnmtZACeecG31koMznhXtectJTMwNP3RHN45SvOTT G/fDHt7vwYVYFtjI97sQp192/JnIZ7nR28PEHoxeXr+fMKd5TJePZRWRJ k=; X-IronPort-AV: E=Sophos;i="5.28,544,1464678000"; d="scan'208";a="217863607" Received: from unknown (HELO ironmsg02-R.qualcomm.com) ([10.53.140.106]) by wolverine01.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Aug 2016 05:14:54 -0700 X-IronPort-AV: E=McAfee;i="5700,7163,8261"; a="792238894" X-Amp-Result: CLEAN Received: from nasanexm01d.na.qualcomm.com ([10.85.0.84]) by ironmsg02-R.qualcomm.com with ESMTP/TLS/RC4-SHA; 19 Aug 2016 05:14:54 -0700 Received: from eusanexr01b.eu.qualcomm.com (10.85.0.99) by NASANEXM01D.na.qualcomm.com (10.85.0.84) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 19 Aug 2016 05:14:53 -0700 Received: from aphydexm01b.ap.qualcomm.com (10.252.127.11) by eusanexr01b.eu.qualcomm.com (10.85.0.99) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 19 Aug 2016 05:14:50 -0700 Received: from aphydexm01b.ap.qualcomm.com ([10.252.127.11]) by aphydexm01b.ap.qualcomm.com ([10.252.127.11]) with mapi id 15.00.1178.000; Fri, 19 Aug 2016 17:44:48 +0530 From: "Manoharan, Rajkumar" To: "Valo, Kalle" , "ath10k@lists.infradead.org" Subject: Re: master-pending: ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core] Thread-Topic: master-pending: ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core] Thread-Index: AQHR+WKBpW0G1eC0nkm/bf6WuNY7dKBQMBmH Date: Fri, 19 Aug 2016 12:14:47 +0000 Message-ID: <1471608887214.2763@qti.qualcomm.com> References: <874m6i15ct.fsf@kamboji.qca.qualcomm.com>, <878tvtyo1b.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <878tvtyo1b.fsf@kamboji.qca.qualcomm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.106.107.6] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160819_051515_299334_37487D80 X-CRM114-Status: UNSURE ( 5.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP [...] >> >> [ 277.244673] ------------[ cut here ]------------ >> [ 277.244685] WARNING: CPU: 2 PID: 2162 at lib/debugobjects.c:263 debug_print_object+0x85/0xa0 >> [ 277.244707] ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core] > > I bisected this to: > > [v2] ath10k: implement NAPI support > > https://patchwork.kernel.org/patch/9240975/ > > I'll reply to that patch for more info. > Oops.. my bad.. Sorry for the regression..Good that it is captured at earliest. Thanks Kalle for reporting the issue. It seems during deinit, driver is not waiting for NAPI completion. What debug options should be enabled to see this warning? If possible, could you please try below change? -Rajkumar diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 33380fba5948..29fc9052e51a 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1759,6 +1759,7 @@ void ath10k_pci_ce_deinit(struct ath10k *ar) void ath10k_pci_flush(struct ath10k *ar) { + napi_synchronize(&ar->napi); ath10k_pci_rx_retry_sync(ar); ath10k_pci_buffer_cleanup(ar); }