From patchwork Fri Feb 10 12:26:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 9566669 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4E93260572 for ; Fri, 10 Feb 2017 12:27:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B8091FF73 for ; Fri, 10 Feb 2017 12:27:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3002528556; Fri, 10 Feb 2017 12:27:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E9A4D1FF73 for ; Fri, 10 Feb 2017 12:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tMg9RCzmzOn5bNeJvim0cibWvAd+PT0EszMTB9ta+v4=; b=llnS3ltdeUP9pp sZp0PvcdhYCLrZlAfctP8YjKyqro2F14e/dMM/eFLUPDufhVuU4e6Envc6A89nt2gJvVsQ4llW0e1 K2WFP7rb+LFlh41B+3IeCs2/coZAW7TJrlsqvnwE2BT8gKxC+Xy4amMQMlE5t/RhP6Dy3g2dkagDy L43KWU0wBnWJU/ch2lIKnXjgCDe07FfMoDnuvADN0HQLZkMMP9gmzz2nkXX9XezPFmG0rznbf4q+y M7n3h7IPsaAJokyyfnKzt0GRhWP0A3Xd2V53EHVeLsMdLu5h3c4vXlO0BrR/e0eP+AhrmAmkmrqUZ tPODn06tAFa2kBRYTBXA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1ccAIm-0007Jy-F7; Fri, 10 Feb 2017 12:27:48 +0000 Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1ccAIZ-00072i-JW for ath10k@lists.infradead.org; Fri, 10 Feb 2017 12:27:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1486729655; x=1518265655; h=subject:from:to:cc:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3cUcXt4XbC951swen5U759Y7PNqOV5oIAWsiPDyvJJw=; b=HOvpegEaBwUFmigSPdurzP6SbeZHuVLIVB/zgOmmM4XripT1E9eeQx1B X9EHHzY0oKLDWDuFUt5q90CqPSlLDcOx9Nq8o9LjkI2TXqRYu7zaPAWXd pw+hDA1SA5L4h5K0LN5VuLLxVtsIdpZBRp0/1bKewvqrtwFLw9jOnTStw Q=; X-IronPort-AV: E=Sophos;i="5.35,141,1484035200"; d="scan'208";a="261806388" Received: from unknown (HELO Ironmsg03-R.qualcomm.com) ([10.53.140.107]) by wolverine01.qualcomm.com with ESMTP; 10 Feb 2017 04:27:17 -0800 X-IronPort-AV: E=McAfee;i="5800,7501,8434"; a="1306949532" Received: from nasanexm02a.na.qualcomm.com ([10.85.0.41]) by Ironmsg03-R.qualcomm.com with ESMTP/TLS/RC4-SHA; 10 Feb 2017 04:27:17 -0800 Received: from eusanexr01a.eu.qualcomm.com (10.85.0.97) by nasanexm02a.na.qualcomm.com (10.85.0.41) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 10 Feb 2017 04:27:16 -0800 Received: from potku.adurom.net (10.80.80.8) by eusanexr01a.eu.qualcomm.com (10.85.0.97) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 10 Feb 2017 04:27:14 -0800 Subject: [PATCH v2 2/4] ath10k: add directory to board data error message From: Kalle Valo To: Date: Fri, 10 Feb 2017 14:26:44 +0200 Message-ID: <148672960431.8556.7607639090307029208.stgit@potku.adurom.net> In-Reply-To: <148672934198.8556.5588600166627442652.stgit@potku.adurom.net> References: <148672934198.8556.5588600166627442652.stgit@potku.adurom.net> User-Agent: StGit/0.17.1-17-ge4e0 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01G.na.qualcomm.com (10.85.0.33) To eusanexr01a.eu.qualcomm.com (10.85.0.97) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170210_042735_875734_D1851DA2 X-CRM114-Status: UNSURE ( 8.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-wireless@vger.kernel.org Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This way user has a better idea what file exactly is missing. This is needed when we switch to using request_firmware_direct() which doesn't print any errors anymore. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 9674c08464ab..f395d3a98bc5 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -1168,7 +1168,8 @@ static int ath10k_core_fetch_board_file(struct ath10k *ar) ar->bd_api = 1; ret = ath10k_core_fetch_board_data_api_1(ar); if (ret) { - ath10k_err(ar, "failed to fetch board data\n"); + ath10k_err(ar, "failed to fetch board-2.bin or board.bin from %s\n", + ar->hw_params.fw.dir); return ret; }