From patchwork Thu Feb 2 19:08:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Gottschall X-Patchwork-Id: 9553093 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6C11760453 for ; Thu, 2 Feb 2017 19:08:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EEDB28411 for ; Thu, 2 Feb 2017 19:08:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 51A5F28435; Thu, 2 Feb 2017 19:08:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MIME_QP_LONG_LINE,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B1D6228411 for ; Thu, 2 Feb 2017 19:08:37 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cZMkC-0006Iw-0E; Thu, 02 Feb 2017 19:08:32 +0000 Received: from nm.newmedia-net.de ([217.113.179.122] helo=webmail.newmedia-net.de) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cZMk7-0006G3-9v for ath10k@lists.infradead.org; Thu, 02 Feb 2017 19:08:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dd-wrt.com; s=mikd; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To; bh=51zYsoZ6nfZ4+jcCda/vkfBSHznzF+J9zeyMnXEOTfU=; b=kj1CAhryRAScZ2wIFSYPfuZbbi0O0MKsj2UvQLTpE5wT2I0ek2ZoxyHwldxCfCH0Qcdf6MfAfzo2m0tt3d/h/8h6Cq9gZ3rHbU4SVHgviopxGvqigzSKgjhqDPPyGPu9LNvkTsIkWHaNsMzMfXbxKH2cVxh+eRxK7/L/bzn3Ods=; To: Ben Greear , "Valo, Kalle" References: <87y3xtrmn2.fsf@kamboji.qca.qualcomm.com> <44480bab-0cf7-f4e3-7612-b1cf5d4c040f@dd-wrt.com> <1a58440c-80c9-0a86-aae9-213edc5b0019@candelatech.com> <8bcf2ea6-802f-f249-8e2d-96ec03553a9b@candelatech.com> <23b1bd75-a7f9-08e7-5d7b-f67081b89e1b@candelatech.com> <5e23ea91-429e-eff6-7443-e4d4f5981735@dd-wrt.com> <785bdbc1-fcf5-921b-2092-6142d51aa0ce@candelatech.com> From: Sebastian Gottschall Message-ID: <14bd9f40-a79c-5032-778f-2f2ae92afccc@dd-wrt.com> Date: Thu, 2 Feb 2017 20:08:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <785bdbc1-fcf5-921b-2092-6142d51aa0ce@candelatech.com> X-SA-Exim-Connect-IP: 93.195.23.251 X-SA-Exim-Mail-From: s.gottschall@dd-wrt.com Subject: Re: 9984 VHT X-SA-Exim-Version: 4.2.1 (built Thu, 26 May 2011 15:22:33 +0200) X-SA-Exim-Scanned: Yes (on webmail.newmedia-net.de) X-NMN-MailScanner-Information: Please contact the ISP for more information X-NMN-MailScanner-ID: 1cZMjh-0002Mj-Og X-NMN-MailScanner: Found to be clean X-NMN-MailScanner-From: s.gottschall@dd-wrt.com X-Received: from [93.195.23.251] (helo=[10.88.193.141]) by webmail.newmedia-net.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1cZMjh-0002Mj-Og; Thu, 02 Feb 2017 20:08:02 +0100 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170202_110828_114407_7D7DB04C X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "ath10k@lists.infradead.org" Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Am 02.02.2017 um 20:05 schrieb Ben Greear: > On 02/02/2017 10:42 AM, Sebastian Gottschall wrote: >> Am 02.02.2017 um 19:24 schrieb Ben Greear: >>> On 02/02/2017 08:18 AM, Ben Greear wrote: >>>> On 02/01/2017 10:45 AM, Sebastian Gottschall wrote: >>>>> Am 01.02.2017 um 17:48 schrieb Ben Greear: >>>>>> On 01/30/2017 02:28 AM, Sebastian Gottschall wrote: >>>>>>> Hello >>>>>>> >>>>>>> with recent 9984 firmares vht160 seem to crash the firmware >>>>>>> itself for no reason i see. >>>>>>> is there any internal structure change in these newer firmwares >>>>>>> we need to consider? >>>>>>> i also tested the even more recent firmware >>>>>>> firmware-5.bin_10.4-3.4-00068 from codeaurora. this one doesnt >>>>>>> crash but the vdev_start returns with a error >>>>>>> >>>>>>> i compared the more recent wmi headers from the qca drivers, but >>>>>>> wasnt able to find anything which could explain the behaviour >>>>>>> >>>>>>> Sebastian >>>>>>> >>>>>>> >>>>>> >>>>>> Hello Sebastian, >>>>>> >>>>>> Could you share the hostapd/supplicant config file you are using? >>>>>> >>>>>> And, what kernel (or backports kernel) are you using? I'd like to >>>>>> see how 160Mhz works on my firmware.... >>>>> always state of art for sure >>>> >>>> Using a somewhat hacked 4.9.2+ kernel and my CT firmware, I get >>>> failure to start CAC: >>>> >>>> 1486052184.818710: Mode: IEEE 802.11a Channel: 100 Frequency: 5500 >>>> MHz >>>> 1486052184.818714: DFS 8 channels required radar detection >>>> 1486052184.818717: DFS all channels available, (SKIP CAC): no >>>> 1486052184.818719: DFS 0 chans unavailable - choose other channel: no >>>> 1486052184.818722: vap0: interface state COUNTRY_UPDATE->DFS >>>> 1486052184.818725: DFS start CAC on 5500 MHz >>>> 1486052184.818733: vap0: DFS-CAC-START freq=5500 chan=100 >>>> sec_chan=1, width=2, seg0=114, seg1=0, cac_time=60s >>>> 1486052184.818737: nl80211: Start radar detection (CAC) 5500 MHz >>>> (ht_enabled=1, vht_enabled=1, bandwidth=160 MHz, cf1=5570 MHz, >>>> cf2=0 MHz) >>>> 1486052184.818742: * freq=5500 >>>> 1486052184.818745: * vht_enabled=1 >>>> 1486052184.818747: * ht_enabled=1 >>>> 1486052184.818749: * bandwidth=160 >>>> 1486052184.818751: * channel_width=5 >>>> 1486052184.818754: * center_freq1=5570 >>>> 1486052184.818756: * center_freq2=0 >>>> 1486052184.823437: nl80211: Failed to start radar detection: -16 >>>> (Device or resource busy) >>>> 1486052184.823444: DFS start_dfs_cac() failed, -1 >>>> >>>> >>>> I'll go dig around to see if I can figure out why... >>> >>> I hacked ath10k to enable radar detection on 160Mhz bandwidths. Now >>> hostapd >>> starts. >>> >>> I can reproduce the FW failure. It is because FW 3.3-25 release >>> started asserting >>> if the freq2 was zero in VHT160 mode. It seems to use both freq1 >>> and freq2, and not >>> how the driver or linux seems to normally use them. >> its even worse. starting from 3.3 it uses freq2 instead of freq1. but >> i made a patch for it. but it still wont work. vdev_start still fails > > Well it would have been helpful from the start to have known about > this patch. i wasnt sure about it at that time. since it did not work > > Could you post it? ch->max_power = arg->max_power; ch->reg_power = arg->max_reg_power; > > Kalle: Since the firmware API changed, how do you want to handle the > differences here? > > Thanks, > Ben > > --- wmi.c (revision 3267) +++ wmi.c (working copy) @@ -1637,11 +1637,12 @@ flags |= WMI_CHAN_FLAG_DFS; ch->mhz = __cpu_to_le32(arg->freq); + ch->band_center_freq2 = 0; ch->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1); if (arg->mode == MODE_11AC_VHT80_80) ch->band_center_freq2 = __cpu_to_le32(arg->band_center_freq2); - else - ch->band_center_freq2 = 0; + if (arg->mode == MODE_11AC_VHT160) + ch->band_center_freq2 = __cpu_to_le32(arg->band_center_freq1); ch->min_power = arg->min_power;